From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F8F4C4706C for ; Tue, 9 Jan 2024 20:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nms+6qKSDnptkuauzhN5DCuPcV8hBqj114DE0gi0gdU=; b=PEqUSQisC+YTaG ogPG+0XcjiF0dRDi77xoIZTwGkulKrLFO8bdhjcpd0Jy4DdDpHqG7fpxySni8dl+xWPxhdLUTJ57y dBEhqoDOYko5pJPcrBHByOOS8EywOAZA7UhD3acfzz3H7UlDcsPNN+9qYLWcioF9J2LjuC7OBWUr2 MNZC3gfl0Y9Wa6DYyE/NOru+rXB/PokZJo+N+I0FDWFPIA52YXf7M5FHWZqD6+vToDNZvph+JYmOd 1xz73vngtzGHCtsGq4QYu+SQq1yIo7v7HP0n+18ENXbag2kOk1FL9mwjBNG/ftIlJs4xrm3jN2Vrw S+oP/b9Ea98bIzXkl55g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNIVH-009QN4-1U; Tue, 09 Jan 2024 20:15:15 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNIVF-009QMB-0Y for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 20:15:14 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-33770772136so1334265f8f.3 for ; Tue, 09 Jan 2024 12:15:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704831309; x=1705436109; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M+B0yD7FjBgqTqLo7b2/IVuy2rnma81MvruhVPGvifo=; b=Hl5ZRrmb9PHtrMlcq4RmrgMS6dybRgBry+oZcrNfM1wlyETrFSFVsB7VaUglsfbxHM X1SNWNGNDi0C3H/OdqMsWXuC9ZYqFZ+bcu2Rhqdzm/+KT7qQ6XWvp123LxZslxUcLmOZ Gxn4ECP+Ca/M9HPXBk6WoQRe6I7ktScr8QKM04M1/IVEl74nmEn92y9KYstcUwg2jXVD aTfmdnp6zr5jXVfaTmbNT1GP1OfYg+w+xYFuHhP1wmZxzFp8eZz3cPDnqMBAXEDAz0eN jQ8eBhMr5fWdbQsUdbo+vABDiwjXhOJ7jJh/xM+FuUevnOVqLdwfn2qPZJYuHmN+bqhN T54Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704831309; x=1705436109; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M+B0yD7FjBgqTqLo7b2/IVuy2rnma81MvruhVPGvifo=; b=O9n97f8Rir1J7ReSXLC0D4WPK0jtdQ/K6kJum8t+ikrjr7+lZ1JMK5ViAZkEF4Imgj QdwoYzxLopIzSWUew1l7wIqCAmjvgWWYw818zmlC+EFU40Dqy/qAWNDrpIXqXrp0J9SS ZEz+/e5reA5xtw3S2PrT4zXWs6ahXyf/Py4VoAXQ7fv47x1DNE2Gc95C/8QlbV6IUQ6t KfRRsq904KJ35cROIWjwNc/aIdhFZPph0JA9o5/mbYtv5ejG8kjFtg+JbwLGxxcy+4i7 Q4w9ErVaVtlAx7Tb61Y83njXc+rgjkzMTUX3awxGxdmKVK3/Mp3aplqDf+NpzVYuY2rq VtWQ== X-Gm-Message-State: AOJu0Yzi0TqpvI7OUtSbS7RcdMbQ4pMer91lOwbq7jEtkCPyHJrTiVAI welEQGMGd+GCbVKUkGC/NGE= X-Google-Smtp-Source: AGHT+IHCUv6AIBjSaTr/8HPaqeDyMqGvcLyT6MaYhYhF7PYV0/3Jv2044yKOg30ZXyxDXKOcj8h8FQ== X-Received: by 2002:a5d:5406:0:b0:336:5b14:525f with SMTP id g6-20020a5d5406000000b003365b14525fmr1021417wrv.132.1704831309212; Tue, 09 Jan 2024 12:15:09 -0800 (PST) Received: from jernej-laptop.localnet (213-161-3-116.dynamic.telemach.net. [213.161.3.116]) by smtp.gmail.com with ESMTPSA id cg4-20020a5d5cc4000000b003377c5b8a43sm45539wrb.93.2024.01.09.12.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 12:15:08 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: fuyao , Jakub Kicinski Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Chen-Yu Tsai , Samuel Holland , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, =?utf-8?B?6bqm5YGl5bu6?= Subject: Re: [PATCH] gmac: sun8i: r40: add gmac tx_delay support Date: Tue, 09 Jan 2024 21:15:07 +0100 Message-ID: <22143664.EfDdHjke4D@jernej-laptop> In-Reply-To: <20240102075807.1a4cac92@kernel.org> References: <20240102075807.1a4cac92@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_121513_208889_F5581ECA X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 02. januar 2024 ob 16:58:07 CET je Jakub Kicinski napisal(a): > On Thu, 21 Dec 2023 15:16:54 +0800 fuyao wrote: > > I don't see it in the user manual also. > > > > it works fine in 100M, but it doesn't work good in 1G without tx_delay > > in my board. > > > > Read the sdk from allwinner I found in: > > > > https://sourcegraph.com/github.com/tinalinux/linux-3.10/-/blob/arch/arm/boot/dts/sun8iw11p1.dtsi?L1826 > > https://sourcegraph.com/github.com/tinalinux/linux-3.10@r40-v1.y/-/blob/drivers/net/ethernet/allwinner/sunxi-gmac.c?L877 > > > > And I add it to my board, it works fine. > > > > So, I think it may be exist register but not documented. > > Unless Allwinner can chime in we should at least document the situation > clearly in the commit message (incl. what HW+config was tested, exactly) > and add a comment in the code? > I agree. Fuyao, please do that. Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel