From mboxrd@z Thu Jan 1 00:00:00 1970 From: jernej.skrabec@siol.net (Jernej =?utf-8?B?xaBrcmFiZWM=?=) Date: Mon, 31 Jul 2017 19:18:28 +0200 Subject: [PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode In-Reply-To: References: <20170730164150.26302-1-jernej.skrabec@siol.net> <20170730164150.26302-5-jernej.skrabec@siol.net> Message-ID: <2215267.q3CNAWEAR3@jernej-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chen-Yu, Dne ponedeljek, 31. julij 2017 ob 07:02:18 CEST je Chen-Yu Tsai napisal(a): > On Mon, Jul 31, 2017 at 12:41 AM, Jernej Skrabec > > wrote: > > Currently ccu_frac_helper_set_rate() doesn't wait for a lock bit to be > > set before returning. Because of that, unstable clock may be used. > > > > Add a wait for lock in the helper function. > > > > Signed-off-by: Jernej Skrabec > > Can you provide a Fixes: tag? fixes: 89a3dfb78707 ("clk: sunxi-ng: Add fractional lib") As we discussed on IRC, it is safe to call ccu_helper_wait_for_lock() even on platforms where lock bit is not present, since it just returns without effect. Regards, Jernej > > Otherwise this looks good.