From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037A0C43381 for ; Fri, 15 Feb 2019 23:09:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4C4320836 for ; Fri, 15 Feb 2019 23:09:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dlvCjHFM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4C4320836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LA+vInIVLVaWpgoM9K89o2+irytSBz9Oyv9dH1Oo7zY=; b=dlvCjHFMMG1Zme 2a+qTEzk0WRQ1seOEGT2XFJQiVf8UI6NoZbVTVi+uQ+0Jh8RARuCKhijkvuNxPxLjQMKJNMANfaou Hs0zkCGljiYToqKEIWUlQ/mPg5beCopp3uRN5B2nptKHbzunyQUvINkc/59Qegk9/blUzbeD3hzUT 7s1fKUAeaN2YjZhhqpjysZjlarqmKz6gWRSLlKaRxGwPqd0LFR64CmpEGnw9RTWEWgmZdHrb0n+jH 3scokVPGBUZOq4V9WWSbEYX/CHBfwZhTy3tzsxMsfyDbHKhMdbc9+fvjJUyfFvpLsrE2IrG/X4S24 pFcXN2xRPbwvDluwj90Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gumbO-0001Yx-3Z; Fri, 15 Feb 2019 23:09:02 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gumbJ-0001Xj-Tb; Fri, 15 Feb 2019 23:08:59 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gumbE-0003WA-4F; Sat, 16 Feb 2019 00:08:52 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Enric Balletbo i Serra , dianders@chromium.org Subject: Re: [PATCH] ARM: dts: rockchip: add chosen node on veyron chromebooks Date: Sat, 16 Feb 2019 00:08:50 +0100 Message-ID: <22158501.cNvkU8jGDh@diego> In-Reply-To: <20190215115150.32299-1-enric.balletbo@collabora.com> References: <20190215115150.32299-1-enric.balletbo@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190215_150858_099603_0BA50BD6 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , kernel@collabora.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Enric, Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra: > In order to use earlycon, the stdout-path property needs to be set > in the chosen node. > > Signed-off-by: Enric Balletbo i Serra What's the reason for adding this only for the Chromebook variants? Uart2 is pretty much the standard output for all devices, so I'd assume at least all veyron boards should use uart2 as well, making this ideally live in the rk3288-veyron.dtsi instead? Heiko > --- > > arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi > b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi index > b54746df3661..8890967ed572 100644 > --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi > +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi > @@ -62,6 +62,10 @@ > pwm-off-delay-ms = <10>; > }; > > + chosen { > + stdout-path = "serial2:115200n8"; > + }; > + > gpio-charger { > compatible = "gpio-charger"; > charger-type = "mains"; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel