From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B84B2C7618D for ; Tue, 14 Mar 2023 20:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9lMnbarudtjl+poveWOWjyoaCEsQxJLMGHlbBBwn9TU=; b=T6Wo6kOJa8QaE2 iT9XxQV6vKLfi6uDnqazwhFPPcFsjLLE2dnJMZp07Oc4+kUavk4pEbM1kBDjy3ioHD/XY2F/+i+q9 ee7cD5WYJfg+6fwowyi3BHVkBjvxytQSE0L5Zby3RnNqEZyanZPgNMp3alkMUWM4lsBN9fZ6UxxVE uvGQDIY5W4Q5yBJVekRAal+NFBg/le8rMiMBgf9jlXPALfIRAowfYSwb4Ep0Z2eXtMMIUMeTUuueb 26ZkXC4vXbK/lJkpzRFNE1Vm5vmJU03hHdOhar1FwrVx76QQC9YAX8VGKXvyhJAlc1uylzdlO6eo/ /gSeDcb5UUZ64W5rLozw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcAsb-00BQnE-14; Tue, 14 Mar 2023 20:04:17 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcAsY-00BQmI-2P for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 20:04:16 +0000 Received: by mail-ed1-x52a.google.com with SMTP id x13so19526709edd.1 for ; Tue, 14 Mar 2023 13:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678824253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FPsjGLHEk2fgihOY0CRt86zGCJvphTuiaNQiTQsSdI8=; b=niwvqGj4rz9lE9IYdY/3oo8dPQUpl+arw5E1AnCutPKcaNCEP3cksSZrxw89aTHZh9 MImVlNjxF6RRXBEUPA23BzAj0QZJj0KoRfM0h2M6T5T6u5qO78weld3wkfTN2Ca+A3If hPu7PGGeAHrftZ9QCXZTWmMzxwvReK69bRahRthU0LX/c5De42X0MdxrWSmk5Gmr93KB 9vNzhvNx3QjNVOqSw68H8GVSmFXaeKVB1Y8Y/0nEGjY5M9LQ3BDLZuJd1QmDSdO7xFwr P0fNTtQIWFuFa+MoR4b1zDkfFalD2vqIvdhql41+DhjVShW8ZUZz8WxbXI+F9kNjI34i JeNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678824253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FPsjGLHEk2fgihOY0CRt86zGCJvphTuiaNQiTQsSdI8=; b=GTAIbqW6O44XSybEnxWAMU+UC+7596IupjYS0AGxpq0n+hJTAiCcjE9YS2ipTZQUYo sqNJO/gBE7b1DQQNlzVS5U01iinFo4E1YBMIm0YizuACWd6EIDooDyfHI4JzOxlnyWwV tuXKYptNT1Wh7Bc1T0BHbPoFFn4fO2REIV9DDo9xXcAfzo5Z3+NoIL0flpK2ELa/yKzh 90Fv857JsIucMKT+H1yzqRKG5j9Gftv0l6/MPmE+XmuduNMrEN0Sn4TW4aWGOCdWgDKw O3oxzKCVPN1DjiX6InsptcSqwu0HgDqt2XYKQ+F9jq/VIdjV9+6HJ8stZdP+MsHGfQ/q 6fuQ== X-Gm-Message-State: AO0yUKXHknDtoa6wnMlrdPiogeDz9XlYOHR0t/Ewr3ut5MruzokPCfPi odL3Swiy6WpymxXPWk6FWjc= X-Google-Smtp-Source: AK7set+oYbAeJ/U09NE2UZA16bmg8V2CkrqR5DzKLghgbnkXuMEp72tKp2I0vc56SOYdAmC9FNqhOw== X-Received: by 2002:a17:906:9f0a:b0:92b:d4f6:7f4c with SMTP id fy10-20020a1709069f0a00b0092bd4f67f4cmr4526093ejc.2.1678824253254; Tue, 14 Mar 2023 13:04:13 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id r9-20020a1709061ba900b0092b65c54379sm1527520ejg.104.2023.03.14.13.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 13:04:12 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Chen-Yu Tsai , Samuel Holland , Emma Anholt , Rob Herring Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] drm: Use of_property_present() for testing DT property presence Date: Tue, 14 Mar 2023 21:04:10 +0100 Message-ID: <2217075.iZASKD2KPV@jernej-laptop> In-Reply-To: <20230310144705.1542207-1-robh@kernel.org> References: <20230310144705.1542207-1-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_130414_782207_C5D91C95 X-CRM114-Status: GOOD ( 22.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 10. marec 2023 ob 15:47:05 CET je Rob Herring napisal(a): > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > Signed-off-by: Rob Herring > --- > drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 2 +- > drivers/gpu/drm/drm_mipi_dsi.c | 2 +- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_backend.c | 2 +- > drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +- For sun4i: Reviewed-by: Jernej Skrabec Best regards, Jernej > drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c > b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c index > 9e5f2b4dc2e5..fab139b324af 100644 > --- a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c > +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c > @@ -313,7 +313,7 @@ imx8qxp_pixel_link_find_next_bridge(struct > imx8qxp_pixel_link *pl) } > > /* specially select the next bridge with companion PXL2DPI */ > - if (of_find_property(remote, "fsl,companion-pxl2dpi", NULL)) > + if (of_property_present(remote, "fsl,companion- pxl2dpi")) > bridge_sel = ep_cnt; > > ep_cnt++; > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index b41aaf2bb9f1..7900a4707d7c 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -329,7 +329,7 @@ int mipi_dsi_host_register(struct mipi_dsi_host *host) > > for_each_available_child_of_node(host->dev->of_node, node) { > /* skip nodes without reg property */ > - if (!of_find_property(node, "reg", NULL)) > + if (!of_property_present(node, "reg")) > continue; > of_mipi_dsi_device_add(host, node); > } > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index ce6b76c45b6f..2359dca80492 > 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -964,7 +964,7 @@ static void adreno_get_pwrlevels(struct device *dev, > gpu->fast_rate = 0; > > /* You down with OPP? */ > - if (!of_find_property(dev->of_node, "operating-points-v2", NULL)) > + if (!of_property_present(dev->of_node, "operating-points-v2")) > ret = adreno_get_legacy_pwrlevels(dev); > else { > ret = devm_pm_opp_of_add_table(dev); > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c > b/drivers/gpu/drm/sun4i/sun4i_backend.c index 38070fc261f3..b11dbd50d73e > 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c > @@ -792,7 +792,7 @@ static int sun4i_backend_bind(struct device *dev, struct > device *master, dev_set_drvdata(dev, backend); > spin_lock_init(&backend->frontend_lock); > > - if (of_find_property(dev->of_node, "interconnects", NULL)) { > + if (of_property_present(dev->of_node, "interconnects")) { > /* > * This assume we have the same DMA constraints for all our the > * devices in our pipeline (all the backends, but also the > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c > b/drivers/gpu/drm/sun4i/sun8i_mixer.c index bafee05f6b24..11d5244a5aa5 > 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c > @@ -391,7 +391,7 @@ static int sun8i_mixer_bind(struct device *dev, struct > device *master, mixer->engine.ops = &sun8i_engine_ops; > mixer->engine.node = dev->of_node; > > - if (of_find_property(dev->of_node, "iommus", NULL)) { > + if (of_property_present(dev->of_node, "iommus")) { > /* > * This assume we have the same DMA constraints for > * all our the mixers in our pipeline. This sounds > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index ea22c9bf223a..bec1e0cdddb3 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -3018,7 +3018,7 @@ static int vc4_hdmi_cec_init(struct vc4_hdmi > *vc4_hdmi) struct device *dev = &pdev->dev; > int ret; > > - if (!of_find_property(dev->of_node, "interrupts", NULL)) { > + if (!of_property_present(dev->of_node, "interrupts")) { > dev_warn(dev, "'interrupts' DT property is missing, no CEC\n"); > return 0; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel