From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: support non-iommu buffer path
Date: Tue, 19 Apr 2016 08:27:10 +0200 [thread overview]
Message-ID: <2221474.O4M7g09IWn@diego> (raw)
In-Reply-To: <1461032372-14630-1-git-send-email-mark.yao@rock-chips.com>
Am Dienstag, 19. April 2016, 10:19:32 schrieb Mark Yao:
> Some rockchip vop not support iommu, need use non-iommu
> buffer for it. And if we get iommu issues, we can compare
> the issues with non-iommu path, the would help the debug.
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 65
> +++++++++++++++++++-------- 1 file changed, 47 insertions(+), 18
> deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index f556a8f..90729c0 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
[...]
> @@ -497,6 +514,18 @@ static int rockchip_drm_platform_probe(struct
> platform_device *pdev) continue;
> }
>
> + iommu = of_parse_phandle(port->parent, "iommus", 0);
> + if (!iommu || !of_device_is_available(iommu->parent)) {
> + dev_warn(dev, "No available iommu found for %s\n",
> + port->parent->full_name);
> + dev_warn(dev, "Force non-iommu buffer for all crtc\n");
As stated in the patch-description, this is somewhat common for _some_ vops
[like the Cortex-A9s I'm still hoping to support at some point in the future
:-D ], so this should probably be either a dev_dbg or a dev_info as maximum
and also condensed into one line of output like:
dev_dbg(dev, "no iommu attached for %s, using non-iommu buffers\n",
port->parent->full_name);
Heiko
next prev parent reply other threads:[~2016-04-19 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 2:19 [PATCH] drm/rockchip: support non-iommu buffer path Mark Yao
2016-04-19 6:27 ` Heiko Stübner [this message]
2016-04-20 2:53 ` [PATCH v2] " Mark Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2221474.O4M7g09IWn@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).