From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27FF4C47404 for ; Fri, 4 Oct 2019 21:45:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAAB72133F for ; Fri, 4 Oct 2019 21:45:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pxaQyKD+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAAB72133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3Fl2Ri8ny3mOjt1YK4nz//WtNj7B0jBPr2zWo4SjC/Q=; b=pxaQyKD+RCxd7F EvFPcLG4WU7lsUVaAH/g1+V3XVYNUTEma2mBZQkLnV9KUNcDJgnwqbM2kM3jtCY7zV/rplmf5tEjq JbpOxBbVKf3+kxYzdPvXLeQ6VXeyfQ/uBTGw4ms5PATjGX2gjd2ZVmB0kqlJq26tAw7bFATpyfP5B Swu9dtCxkr9eGWT1Gt+7RKRT/sS4XKcKlCUIC1CS1pY5A5YxeggOv2sjpwT9e5gtDdrVhP26nCU+B 9IrRuuRbBn8Epl83ec1VHx7zfTrbr3MFoei5Lsm2vDpOy89wmzY5THHjAnlN0xw2tfdX1KEmsQ7aH Ta4VAjzVaddQN3/WrlTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGVO6-0002Wv-7x; Fri, 04 Oct 2019 21:45:22 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGVO4-0002WJ-1G; Fri, 04 Oct 2019 21:45:21 +0000 Received: from 94.112.246.102.static.b2b.upcbusiness.cz ([94.112.246.102] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGVNt-0006sD-N6; Fri, 04 Oct 2019 23:45:09 +0200 From: Heiko Stuebner To: Vivek Unune Subject: Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box Date: Fri, 04 Oct 2019 23:45:08 +0200 Message-ID: <2223294.9I8gkMH88G@phil> In-Reply-To: <20190929234615.GA5355@vivek-desktop> References: <20190929032230.24628-1-npcomplete13@gmail.com> <54c67ca8-8428-48ee-9a96-e1216ba02839@gmail.com> <20190929234615.GA5355@vivek-desktop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191004_144520_227318_0B78DA69 X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Felipe Balbi , Felipe Balbi , linux-kernel@vger.kernel.org, Vicente Bergas , linux-rockchip@lists.infradead.org, robh+dt@kernel.org, akash@openedev.com, ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vivek, Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune: > On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote: > > On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote: > > > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3 > > > = > > > Signed-off-by: Vivek Unune > > > --- > > > arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > = > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > > > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > > > index 0d1f5f9a0de9..c133e8d64b2a 100644 > > > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > > > @@ -644,7 +644,7 @@ > > > status =3D "okay"; > > > u2phy0_host: host-port { > > > - phy-supply =3D <&vcc5v0_host>; > > > + phy-supply =3D <&vcc5v0_typec>; > > > status =3D "okay"; > > > }; > > > @@ -712,7 +712,7 @@ > > > &usbdrd_dwc3_0 { > > > status =3D "okay"; > > > - dr_mode =3D "otg"; > > > + dr_mode =3D "host"; > > > }; > > > &usbdrd3_1 { > > = > > Hi Vivek, > > = > > which is the relationship of your patch and this commit: > > = > > e1d9149e8389f1690cdd4e4056766dd26488a0fe > > arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire > > = > > with respect to this other commit: > > = > > c09b73cfac2a9317f1104169045c519c6021aa1d > > usb: dwc3: don't set gadget->is_otg flag > > = > > ? > > = > > I did not test reverting e1d9149e since c09b73cf was applied. > > = > > Regards, > > Vicen=E7. > > = > = > Hi Vicen=E7, > = > Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3 = > Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms > with usb-c port. After applying the fix, it worked. > = > I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg > flag") and it will be interesting to test it. This might render > my fix unecessary. So I'll let this patch sit here for now. Once you've done the testing, can you please respond with the result (both positive and negative results please). Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel