From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8E81C77B7D for ; Thu, 18 May 2023 21:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lDYngzJcSJkY694oW1LlOX42D3b/Bz98+8MINS91T0s=; b=NQYFAGvGjQu+XB 7hm3wvjL35LZIFioZ6qqcxf7WehqBCckvPFKsL2cmDS4v4ufDKZguNUmaW0U+Y1cWOL0iWYMdPjhJ dEGtgu0Oe8BN0/pxwgTDh0m40uk+PV2O6UkWKsweQYuyY61Q4gBy1g3/gnyQFi2Rs/G5vDadNF17C Dya02SnBY9xW6NbjZrgy/nAm0wyqkMXh9KX2nqxbYJGCzlnrZ51w5JCHwcqphV7judUt7Po1Px6yb AarvnohFZHPeh/+g6yyx4YCmGxC8kEvGjVh5n2aOKShHMsiWlUs3+4LSwpEvYPgKCu0Moi3/Ek5BM SVz9uxLuoJqYYRli5GAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzl3m-00EEeN-0C; Thu, 18 May 2023 21:21:18 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzl3i-00EEdj-22 for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2023 21:21:16 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-96f53c06babso89263066b.3 for ; Thu, 18 May 2023 14:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684444872; x=1687036872; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4iUdnG3B6bDinPXQQdTMNWQPFcDR+hVyW1eiXtt7wfo=; b=HXMqCulr0NH7kvtItyAe8SCEfLu/LEkiLlkw8VCp6mzMsfa2MrjqIuOGAF9rQrlGSv QYNp05dZJHNXaN1ywFXwpSjmMOJejbtyYGsdKaDVWa9NtZTDkBkTwUZJLFR9V/OJu4oi Fpzr7zeKT+BI8868Tpd98EeeQaQLDfsRFKTFHFScEKcntw8pbAPIefuwM3NMcV9yHbID 32+FUUf+QcYH8KU/txsbJxxLV4AtPbLjdnLS28+PyILufsYxCY+cuQocSN/hj4XxS6dP 2gdqkEf8IU1SlCefQIoSltLQi3CeTgo5G31jeSR3FnKWLnV00vEOCCyEI7qEM4qzs3ES 5YJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684444872; x=1687036872; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4iUdnG3B6bDinPXQQdTMNWQPFcDR+hVyW1eiXtt7wfo=; b=AmWx4TlHn6wzA/EQ6VrZd20MHKsGZn9K6NzedHf988xw4dxV8GZKcaJxpASFnbOHWG oIGDe1bZKxh70NgJOKQhCD8kWeqV/uFIpGtPS1dRzRzcN6R90y7zQh29ApQvUT2sk2dN 21i5jqeGe0bfcrGSiJSDEawqENgB9+pN6u6qSAd5x5P5ofKnCEfA7YoVeqcHBYxDsmK/ 35zBGk2lsmgUBlXin2iT5ysCitfVoUUxy8/cJ6xvIUDKQc7HMhPj5Jts+BK+w5FUVHP9 NmuwiB3u8XDndnXpaAg2k3yOlRZ2jeRnytmBUaiEPhbHl7oboWQi9OQ4zkWQhOzrYYgB PW+Q== X-Gm-Message-State: AC+VfDxIsFHxoMDpxIOXln6vWa9hdI3ttEinziDlsPV+oOBXiR+PlqPs DvOFT+O+dzy01hoOtsdM0AI= X-Google-Smtp-Source: ACHHUZ4DVEeLBoJ3ljcDD6txqqTPOrPhKaAMy3wbbDw7gBrvZEJBms7KoupvsqOZZ2BRvfmUhObApw== X-Received: by 2002:a17:907:97cf:b0:967:142b:ff07 with SMTP id js15-20020a17090797cf00b00967142bff07mr475021ejc.21.1684444871844; Thu, 18 May 2023 14:21:11 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id w25-20020a170906b19900b0095707b7dd04sm1420365ejy.42.2023.05.18.14.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 14:21:11 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Linus Walleij , Bartosz Golaszewski , Conor Dooley , andy.shevchenko@gmail.com, Jonathan McDowell Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v3 2/5] pinctrl: axp209: Add support for GPIO3 on the AXP209 Date: Thu, 18 May 2023 23:21:08 +0200 Message-ID: <2224092.iZASKD2KPV@jernej-laptop> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_142114_694493_66A79040 X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 16. maj 2023 ob 19:47:29 CEST je Jonathan McDowell napisal(a): > The AXP209 device has a 4th GPIO which has a slightly different register > setup, where the control + status bits are held in a single register > rather than sharing AXP20X_GPIO20_SS with GPIOs 0-2. > > Signed-off-by: Jonathan McDowell Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > drivers/pinctrl/pinctrl-axp209.c | 42 ++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-axp209.c b/drivers/pinctrl/pinctrl-axp209.c > index 0bc1b381a2b8..b3ba25435c34 100644 > --- a/drivers/pinctrl/pinctrl-axp209.c > +++ b/drivers/pinctrl/pinctrl-axp209.c > @@ -30,6 +30,11 @@ > #define AXP20X_GPIO_FUNCTION_OUT_HIGH 1 > #define AXP20X_GPIO_FUNCTION_INPUT 2 > > +#define AXP20X_GPIO3_FUNCTIONS GENMASK(2, 1) > +#define AXP20X_GPIO3_FUNCTION_OUT_LOW 0 > +#define AXP20X_GPIO3_FUNCTION_OUT_HIGH 2 > +#define AXP20X_GPIO3_FUNCTION_INPUT 4 > + > #define AXP20X_FUNC_GPIO_OUT 0 > #define AXP20X_FUNC_GPIO_IN 1 > #define AXP20X_FUNC_LDO 2 > @@ -73,6 +78,7 @@ static const struct pinctrl_pin_desc axp209_pins[] = { > PINCTRL_PIN(0, "GPIO0"), > PINCTRL_PIN(1, "GPIO1"), > PINCTRL_PIN(2, "GPIO2"), > + PINCTRL_PIN(3, "GPIO3"), > }; > > static const struct pinctrl_pin_desc axp22x_pins[] = { > @@ -130,6 +136,14 @@ static int axp20x_gpio_get(struct gpio_chip *chip, unsigned int offset) > unsigned int val; > int ret; > > + /* AXP209 has GPIO3 status sharing the settings register */ > + if (offset == 3) { > + ret = regmap_read(pctl->regmap, AXP20X_GPIO3_CTRL, &val); > + if (ret) > + return ret; > + return !!(val & BIT(0)); > + } > + > ret = regmap_read(pctl->regmap, AXP20X_GPIO20_SS, &val); > if (ret) > return ret; > @@ -144,6 +158,17 @@ static int axp20x_gpio_get_direction(struct gpio_chip *chip, > unsigned int val; > int reg, ret; > > + /* AXP209 GPIO3 settings have a different layout */ > + if (offset == 3) { > + ret = regmap_read(pctl->regmap, AXP20X_GPIO3_CTRL, &val); > + if (ret) > + return ret; > + if (val & AXP20X_GPIO3_FUNCTION_INPUT) > + return GPIO_LINE_DIRECTION_IN; > + > + return GPIO_LINE_DIRECTION_OUT; > + } > + > reg = axp20x_gpio_get_reg(offset); > if (reg < 0) > return reg; > @@ -184,6 +209,15 @@ static void axp20x_gpio_set(struct gpio_chip *chip, unsigned int offset, > struct axp20x_pctl *pctl = gpiochip_get_data(chip); > int reg; > > + /* AXP209 has GPIO3 status sharing the settings register */ > + if (offset == 3) { > + regmap_update_bits(pctl->regmap, AXP20X_GPIO3_CTRL, > + AXP20X_GPIO3_FUNCTIONS, > + value ? AXP20X_GPIO3_FUNCTION_OUT_HIGH : > + AXP20X_GPIO3_FUNCTION_OUT_LOW); > + return; > + } > + > reg = axp20x_gpio_get_reg(offset); > if (reg < 0) > return; > @@ -200,6 +234,14 @@ static int axp20x_pmx_set(struct pinctrl_dev *pctldev, unsigned int offset, > struct axp20x_pctl *pctl = pinctrl_dev_get_drvdata(pctldev); > int reg; > > + /* AXP209 GPIO3 settings have a different layout */ > + if (offset == 3) { > + return regmap_update_bits(pctl->regmap, AXP20X_GPIO3_CTRL, > + AXP20X_GPIO3_FUNCTIONS, > + config == AXP20X_MUX_GPIO_OUT ? AXP20X_GPIO3_FUNCTION_OUT_LOW : > + AXP20X_GPIO3_FUNCTION_INPUT); > + } > + > reg = axp20x_gpio_get_reg(offset); > if (reg < 0) > return reg; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel