From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44DA6C433EF for ; Tue, 11 Jan 2022 07:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VfDJoUfNmH0OEQnNvo4abE8ewtB2kCl+94Fj2yvClHk=; b=MbiPe1wLlwOYZw L5L1XGBay2ZvrgkZWs7l3w19SpOoOgEJtCc+fhnIvtoIq+YO/bTFrLXEXDZLVhrexjhlW+N675NbV nkmjy9RcLiyETAVDUUvAhN0GrwzKMej+JolyTcAAIESGMDuDQAf4t2G0SnjV9YRqmtMPE5Xqxq/Sk Kibthu1sIVAq167/OgvhiwanQ+/klyJjBz0+EBlS6VvjUYhCPAc0yR7B+5R1ZQhTAjT2W61WG/T+G FnOo0L/cnZpjh2v3SAugmm1COXcH7WU5ERoeFUGjJl+j6g8oxGqGauHkDJ9sgiyDOpn83JaBtLu0i mdYZ3qAddlmoEJluMSPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7BS2-00F4TK-BP; Tue, 11 Jan 2022 07:20:14 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7BRy-00F4Ra-Ij for linux-arm-kernel@lists.infradead.org; Tue, 11 Jan 2022 07:20:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1641885610; x=1673421610; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3Jyu/v5o+vrp+3w/SDYYyY+040QxdlcF7dPATNH70YY=; b=ai+2TEtQQ6ZnWrojwKvpT5/xDxO+43R+bnCRabfFISaEV6GGbBmX6KdG PE5ZvXNxG0TforKLFgadPIsZcC91F0vqOdsBalSHBFiHJihW3I0LKyYs7 IGQR2PVeYKVetp1ZSPaUjeV1gGspXfEiq88Dh5AU13tFAC6IcjfbIbf+o KumFxMef+cocTn39XbwQjUJigCC0ldMgGLuj8Yt1+/T7mCC9ALkO3VlvB oYe1OzergCmPL4tlVtMLSrQUBDfMP8D3KFZ7fE6G7CsZNRmJ0Cf0vhDXy 4yQpCiX5cnJfP4ZJu/V9gZTHY6U5nClaD0R9xDV/9QugZkqXfzh3l6mlV g==; X-IronPort-AV: E=Sophos;i="5.88,279,1635199200"; d="scan'208";a="21419129" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 11 Jan 2022 08:20:05 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 11 Jan 2022 08:20:05 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 11 Jan 2022 08:20:05 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1641885605; x=1673421605; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3Jyu/v5o+vrp+3w/SDYYyY+040QxdlcF7dPATNH70YY=; b=mImTkfGmWhTa5RFiG3xqVVSjwgAI1LZUvKi0XIHdgYU8Zm6qcUKmUQsi TvPt56HycPYVu1Tnz56KlkuWZ9KXy/YWcywQ73zemf/wBiN9fm9v7tg0y eEoWnBaKApayIQbueD7cWVPSf+uMrMszryddorLvWzSl0lEneX5ZZqC57 E1EnT37MxwmcuoY+HqAOR0XFrMFn7U3TmbnDAUrimKJVGBPa+JOR+APFL MfnXChOGpusAfSWZf6Eskz08QPV8FXnEXpA4xrc9/xrK9CMBTtmTYN+ZZ wNJYdyEgQ/uTDY2zJBj6ocpI19nABSiAS+UDcHyWkLgDY5DmIg1SptL41 Q==; X-IronPort-AV: E=Sophos;i="5.88,279,1635199200"; d="scan'208";a="21419127" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 11 Jan 2022 08:20:04 +0100 Received: from steina-w.localnet (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 152F8280065; Tue, 11 Jan 2022 08:20:04 +0100 (CET) From: Alexander Stein To: Tim Harvey Cc: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Device Tree Mailing List , open list , Linux ARM Mailing List Subject: Re: (EXT) Re: [PATCH] arm64: dts: imx8mm-venice-gw73xx-0x: add dt overlays for serial modes Date: Tue, 11 Jan 2022 08:20:01 +0100 Message-ID: <2226437.ElGaqSPkdT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20211214213630.14819-1-tharvey@gateworks.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_232010_992527_09FC8507 X-CRM114-Status: GOOD ( 19.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 11. Januar 2022, 01:00:21 CET schrieb Tim Harvey: > [SNIP] > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > b/arch/arm64/boot/dts/freescale/Makefile index a14a6173b765..5ec8d59347b6 > > 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -44,6 +44,9 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw71xx-0x.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw72xx-0x.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw73xx-0x.dtb > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw73xx-0x-rs232-rts.dtbo > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw73xx-0x-rs422.dtbo > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw73xx-0x-rs485.dtbo > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw7901.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw7902.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-beacon-kit.dtb > > > [SNIP] > I'm mostly interested to see if my approach to dt fragments here and > the naming of the files makes sense to others. > > This patch causes the kernel to build dtbo files for: > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtbo > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs422.dtbo > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs485.dtbo > > The intention is that these files are used by boot firmware (U-Boot) > to adjust the dtb before passing it to the kernel. Hi Tim, do these dtbo actually work? I'm wondering because I was trying to useoverlays myself and noticed that the had to be compiled with -@ for u-boot to be able to apply them. Apparently there are 2 possibilities: * Set "DTC_FLAGS_[dtb] := -@" yourself See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ commit/?id=e426d63e752bdbe7d5ba2d872319dde9ab844a07 * Use dedicated overlay target See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ commit/?id=15d16d6dadf6947ac7f9a686c615995c5a426ce2 You use neither of them. IIRC just naming the target file .dtbo will not apply symbols (-Q) during dtc call. Can you verify using 'V=1' Also I'm wondering which way is the best to go. Best regards, Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel