From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4752DC43381 for ; Wed, 13 Mar 2019 11:47:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16263214AE for ; Wed, 13 Mar 2019 11:47:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SA89T+2n"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="g/rhhetW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16263214AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DSg+vyBXiwfvJ7NFhBS4oefIodUtsEcB8VdxCZOdTEs=; b=SA89T+2nqMaHit U76tA3lxT4kW08Qdh3Q0KdGbcUd+sDqeJN0mM3DEGgho9OzTsAnNea9T7pkvgSQYo/uTA+Ir5C3Ct a1WuFsFWuUyXU/8ZPNuxh12lOBjzYYZZEDBP6A7mcBoyHpbpGzAECx8tm6tsw9YaEQNiS3+t61dih mLJXJczwlq3E4QSwk5JXu7aMcBhLDqLCo/K7+8QcG0MAvFxEnzYsHStr7tk4xYpkHnUNq2sF4mK3E SsbeMox0q+HMA7RnziVG/6kSfdqBu3bZM4E9B9WB8ELUCyYm8MT7zO7E813oMQ2R70/JN1Q7lHYZc tOvk7f6s3j8thT2mbvDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h42MI-0003Bi-Jy; Wed, 13 Mar 2019 11:47:42 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h426w-00017o-D8; Wed, 13 Mar 2019 11:31:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=T00soNYtSqJMTUT2Y9Ykz58n+Kwg4j15KAFkiqZxrmI=; b=g/rhhetWsAp42BIJfvE/+Bemch Bqo3Z3HhTzjT8B1rp1hImnzkDEfgMdSH1KPnDSKsDXnnabCGbwMp+pU9sL9Ub5L+WMI2f81f/lgZ4 PQY9XhWKmgjXiuCvPF4mtLI+TDXCf8ilvwtF0OnlXHIUww1Jf70n2/g5UqRFUeqYxYTCDXq2QOi3v k/0JE+b3Kp64kWBwoegAs+pEmzrCzkagpI2M/Thn8Ml1WE1yAtITffbMQ0rd09edqIX3+P7xKx+9a Ti8ARMo0QZau/Ay2rtqE4NL611qidde0YnOef5BycQ20VSUH+jS3SfcazYpxsAwuXMSo7F05WsWG5 2Ow14E2A==; Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3oSS-000640-Hr; Tue, 12 Mar 2019 20:57:09 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h3oQX-0004oL-Gj; Tue, 12 Mar 2019 21:55:09 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: David Summers Subject: Re: [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi Date: Tue, 12 Mar 2019 21:55:08 +0100 Message-ID: <2230941.OycJZGmSUK@diego> In-Reply-To: References: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> <383c9884-4885-34e1-9ef7-96e936bb211d@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_165708_798708_7823B2E3 X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , devicetree@vger.kernel.org, Robin Murphy , linux-rockchip@lists.infradead.org, robh+dt@kernel.org, frowand.list@gmail.com, Tony McKahan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 12. M=E4rz 2019, 21:41:24 CET schrieb David Summers: > On 11/03/2019 22:18, Robin Murphy wrote: > > On 2019-03-09 3:39 pm, David Summers wrote: > >> Signed-off-by: David Summers > >> Signed-off-by: Stefan Wahren > >> Tested-by: Tony McKahan > >> Reviewed-by: Robin Murphy > > = > > Erm, I don't think I did... :( > > = > > Please see section 13 of Documentation/process/submitting-patches.rst > > for what that tag means. > > = > > FWIW this is the kind of patch I might have considered formally > > reviewing if I had enough first-hand experience of the Tinker Board or > > Realtek SDIO modules to judge correctness, but sadly I have zero of > > either. > > = > > Robin. > > = > >> Test-by: TheSaint @ ArchLinux ARM > = > Apols Robin. I read to much into your understanding of the comments that > were talked to be added.... > = > Yes Stefan but at least as much, maybe more work into this patch than I > did. He was the man that made it close to what we could mainline. I only > added very little, but then again I was also the one pushing for mainlini= ng. > = > So if only one sign off - Probably Stefan did most. Nope, that was the reason for my Co-developed-by question. If you look into the submitting patches document there is a special tag Co-Developed-by to give credit to the author that is not the "patch-from". And in this case all authors also get a signed-off-by line. > = > Heiko: Same question as before do you want me to resend which cleared up > signoff? Just send me an email - and I'll do whatever is best for you. As in the other mail, resending for things like that is not necessary in my case. I just need to hunt down the relevant information as you can see :-D Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel