From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8003C433EF for ; Mon, 11 Apr 2022 15:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ymuqPkAk7VZktqY3Tlxba5XZ7g/pklAoKw0TzFY86zw=; b=U0tu0tZ7wYra1p i8I8HuNvhQ6ponVQWfanzC05VcLX6e2idNs23d1lOecXHQ8pPQIhoKE8sS+syzvPbpBoSqsPhcTU8 yxvgkMqpxVJeHtQTL1TGt4TkB/IHozMzawX9WXYefU+qS9ChoXM9VPGIcRl2kRmEgif6HsWCbigLr C7rMRzTu9ro2qt9c6dPauFy+KHIVsV9ZUNVa7aSw0dnjcipgi2bTY6m+SDAWW+F440YyGRQ0507Qp upJMZY/67AKqEAPALueNt+RnlnLZ7trCuWTkJWCSNbhQmlaKm96sq1Wp5mutVjly6o4j6pRScqaAW wGJW1RBqKnqYTmQ0scOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndvx6-009YWs-Sg; Mon, 11 Apr 2022 15:27:41 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndvuY-009XBV-75 for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 15:25:04 +0000 Received: by mail-wm1-x32e.google.com with SMTP id n126-20020a1c2784000000b0038e8af3e788so8741056wmn.1 for ; Mon, 11 Apr 2022 08:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RzsEqdN9GWBZCp9gbidm1vb5G8aw4lFe2X8gpnY6F9U=; b=JQrYEIFBxiKgk+B/U4eSm8qQmxNxlhQQJSFEVnH4IiJtIEp3Iyxq5LhWBdVbC9LXNE fjx+B0j5+rGkH6hhrv3Vhu2BCOPj7AWkXgjJ8+uaYU2cbY/BVn09qPoZtz4r7WmtCgRc 6jAhjsJke1LITOa0Vfldz77wZj1VlbRfWgN7pe8I6kxAzvSOYjNJJc4Nw7MG9YNr4aUG SGm8GZ0/H9xwhSw4bjPRJ9LCkvogFt2nujW+EA73cCJFafK8gHwzuZw+mRbDJ1aVEqlI 0njk9NS0L8d1rnRwHRpEArL4g96GYrOCP53MSQAnvE3aRkjnwc2JjwMeLuM8fqhl4EFJ Kb9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RzsEqdN9GWBZCp9gbidm1vb5G8aw4lFe2X8gpnY6F9U=; b=gtrmYKsZKyGzvUIqZzwQ3dhKKWlew2w0HivtcwdHHgdpm0kDaWGPhfY20seVgFHPtT 4hCBCd1jzzptmHuUAcpvDZHFvt6MNsVQ2F/6ZnGS+O6kzv6N6nasaDtx0hk3re6HIaiA CXB6B3ef8HOMFyJEL5WVqSmA0rMn4opfHvSc71+3RoSX7TNhZmeoSU4zwoDKv35F1UpA d6XH4SaGZkzHNnGsRX6nfq75chla3bUDewtdJoZP3aJ+bYRaUpc6y0FM8d9fAVUJXBAs ZtRDqah/xF8uKnhuvmbt+nuzZCF7pLjJxv1lEdJCu/pVp+EHJkrPT2B6MRZAreCJkVtR UrCA== X-Gm-Message-State: AOAM530CkxB+uXJd8d7VHEgWcGWjuANZEVhAKfoupqiMQacDjMTFllcV dcW5MHSvpAXsg5WEwwNr2eA= X-Google-Smtp-Source: ABdhPJwEBfXcqXbo6nKoX7IGK2b48hhx00NtVYuq45Z9JeLIYxRw6WPyZdqv7NpnPbruES0SS+KWOQ== X-Received: by 2002:a1c:f607:0:b0:381:1db:d767 with SMTP id w7-20020a1cf607000000b0038101dbd767mr28969100wmc.165.1649690700192; Mon, 11 Apr 2022 08:25:00 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm9126970wrr.67.2022.04.11.08.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 08:24:59 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland Cc: Andre Przywara , Samuel Holland , Alexandre Belloni , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] clk: sunxi-ng: sun6i-rtc: Mark rtc-32k as critical Date: Mon, 11 Apr 2022 17:24:58 +0200 Message-ID: <2233461.ElGaqSPkdT@kista> In-Reply-To: <20220411050100.40964-1-samuel@sholland.org> References: <20220411050100.40964-1-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_082502_309630_3E914305 X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 11. april 2022 ob 07:00:59 CEST je Samuel Holland napisal(a): > Because some newer hardware variants have multiple possible parents for > the RTC's timekeeping clock, this driver models it as a "rtc-32k" clock. > However, it does not add any consumer for this clock. This causes the > common clock framework to disable it, preventing RTC time access. > > Since the RTC's timekeeping clock should always be enabled, regardless > of which drivers are loaded, let's mark this clock as critical instead > of adding a consumer in the RTC driver. > > Fixes: d91612d7f01a ("clk: sunxi-ng: Add support for the sun6i RTC clocks") > Signed-off-by: Samuel Holland Acked-by: Jernej Skrabec Best regards, Jernej > --- > > drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu- sun6i-rtc.c > index 8a10bade7e0d..3d9c9ce5a3db 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c > +++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c > @@ -241,6 +241,7 @@ static struct clk_init_data rtc_32k_init_data = { > .ops = &ccu_mux_ops, > .parent_hws = rtc_32k_parents, > .num_parents = ARRAY_SIZE(rtc_32k_parents), /* updated during probe */ > + .flags = CLK_IS_CRITICAL, > }; > > static struct ccu_mux rtc_32k_clk = { > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel