From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B24C10F0E for ; Fri, 12 Apr 2019 18:55:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5419120869 for ; Fri, 12 Apr 2019 18:55:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t73Aq0Jt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5419120869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MBkgoWOcMzuflKB/BWsHD+0vufZHZHWRWxZaT2J8q9U=; b=t73Aq0JtfdhwXJ Ag6FqnHUUYtwpYBXSgFgWt7SpCi1ZHCehAA2e5rTtFR+MZB5GdTJDokRlEY5CciOCbX6nZ7AYqaxp EpJTBd6XIectNqaMuRaZf3JySS8zkWVcoatq1zfGUZhRIUeNMxhb3OZbTPZ84auBWxvyN0XMeMm+y 1EZKUcNJM/Il+0Nn1FNwKo6WZinLwW2tXta6i0LZgZjaZmSnNJIMDNl7brCbrSvhpV/Y7OEnuc4ps yr/QTPhOw08W9JbZzOpiaT3ckMpFDfDUE6bcJOToI2mYT/sBLhti6LhnPnaHG5RVFsadqQvZoQVt1 LbDwwATIeemU71OMEGlg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hF1Kj-0001KC-JE; Fri, 12 Apr 2019 18:55:29 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hF1Kf-0001I6-Gz; Fri, 12 Apr 2019 18:55:27 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hF1Kc-0007TD-Mi; Fri, 12 Apr 2019 20:55:22 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Matthias Kaehlcke Subject: Re: [PATCH] clk: rockchip: rk3288: Limit use of USB PHY clock to USB Date: Fri, 12 Apr 2019 20:55:21 +0200 Message-ID: <2234566.NSlXb2d66Y@diego> In-Reply-To: <20190412180255.GW112750@google.com> References: <20190411175917.173566-1-mka@chromium.org> <2029012.W0xZ3ly3fY@diego> <20190412180255.GW112750@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_115525_714385_19B00062 X-CRM114-Status: GOOD ( 30.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, Douglas Anderson , linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 12. April 2019, 20:02:55 CEST schrieb Matthias Kaehlcke: > On Fri, Apr 12, 2019 at 11:30:37AM +0200, Heiko St=FCbner wrote: > > Am Freitag, 12. April 2019, 02:16:57 CEST schrieb Matthias Kaehlcke: > > > Hi Heiko, > > > = > > > On Thu, Apr 11, 2019 at 09:03:07PM +0200, Heiko St=FCbner wrote: > > > > Hi Matthias, > > > > = > > > > Am Donnerstag, 11. April 2019, 19:59:17 CEST schrieb Matthias Kaehl= cke: > > > > > The USB PHY clock can be configured as (grand) parent of uart0_sc= lk and > > > > > sclk_gpu. It has been observed that UART0 doesn't work reliably i= n high > > > > > speed mode with the PHY clock as input when certain USB devices a= re > > > > > plugged to the USB HOST1 port (see https://crrev.com/c/320543). > > > > > = > > > > > Prefix the name of the PHY clock with a '.' in the non-USB muxes = to > > > > > effectively remove the clock as input from these muxes. > > > > > = > > > > > Signed-off-by: Matthias Kaehlcke > > > > > --- > > > > > drivers/clk/rockchip/clk-rk3288.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > = > > > > > diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rock= chip/clk-rk3288.c > > > > > index 5a67b7869960..677bc5485201 100644 > > > > > --- a/drivers/clk/rockchip/clk-rk3288.c > > > > > +++ b/drivers/clk/rockchip/clk-rk3288.c > > > > > @@ -200,8 +200,8 @@ PNAME(mux_aclk_cpu_src_p) =3D { "cpll_aclk_cp= u", "gpll_aclk_cpu" }; > > > > > PNAME(mux_pll_src_cpll_gpll_p) =3D { "cpll", "gpll" }; > > > > > PNAME(mux_pll_src_npll_cpll_gpll_p) =3D { "npll", "cpll", "gpll"= }; > > > > > PNAME(mux_pll_src_cpll_gpll_npll_p) =3D { "cpll", "gpll", "npll"= }; > > > > > -PNAME(mux_pll_src_cpll_gpll_usb480m_p) =3D { "cpll", "gpll", "us= bphy480m_src" }; > > > > > -PNAME(mux_pll_src_cpll_gll_usb_npll_p) =3D { "cpll", "gpll", "us= bphy480m_src", "npll" }; > > > > > +PNAME(mux_pll_src_cpll_gpll_usb480m_p) =3D { "cpll", "gpll", ".u= sbphy480m_src" }; > > > > > +PNAME(mux_pll_src_cpll_gll_usb_npll_p) =3D { "cpll", "gpll", ".u= sbphy480m_src", "npll" }; > > > > = > > > > In general I like to have things like the clock-tree described fully > > > > and let the kernel handle correct sourcing ... but: > > > > = > > > > As you write this seems like a systemic problem when just connecting > > > > random peripherals can create unstable clock source frequencies, > > > > so I tend to agree here ... but: > > > > = > > > > Can we please find a more "talking" name for this ... because as wi= th the > > > > above someone will find the "." and submit a fix for it ;-) . > > > > = > > > > So just name it "unstable_dummy" or so? > > > = > > > I looked for some common pattern, but couldn't find one. I liked the > > > '.' since it leaves the name of the clock mostly intact, just hiding > > > it (similar to a leading '.' in a Linux file system). But I agree that > > > it might not be expressive enough. I still like the idea to keep the > > > clock name around for reference, maybe we could name it > > > "unstable:usbphy480m_src" or similar. If you don't object I'll send a > > > patch with this some time tomorrow. > > = > > I've just adapted the patch to use the new parent-name you suggested > > and applied it for 5.2 So no need to resend :-) . > = > Pefect, thanks! > = > I don't see the patch in the git.kernel.org repo (nor > https://lore.kernel.org/patchwork/patch/1060781/), looks like the push > is still pending. oops, I really had forgotten the push ... done now with your patch at https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/lo= g/?h=3Dv5.2-clk/next Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel