From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08EE0C433EF for ; Sun, 24 Apr 2022 20:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J4M40qG2p4fC3n+RZXM8tvq86vKyWN73x65GhM3+Byk=; b=hAyLze7RgpKYqF djR/GG/wlSRv1NePv91hXsZqCeTuY+5nB6RYmZYzIVb2p0ViWM/qEGj16Wcx2uxHQQykF8N91yLKq JkTcxdRYmhXrLpWcWKPbv1LBztQIFVOnxpwbO9i9DcxXO7hI7zHLDjTNMClOKUQCJEMa+asZ9Gmxl 5NBu0UDIvaoXnZxf/HncI/PFisk8INso6LFH7r3b2t8txUVBMlAPMQqNVNYfP9MBPB+rtdZhP/l0c GDhbmcjl0InwnAnjyqoGs/maRIluUTogbuh+OScBp9Z3UtGIv/M2rntizJ+lS0NF9fMru0NXMbFh6 OhCywnF1DDJAXlGhpTeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1niiQ8-007JZD-8b; Sun, 24 Apr 2022 20:01:24 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1niiQ5-007JXp-5S for linux-arm-kernel@lists.infradead.org; Sun, 24 Apr 2022 20:01:22 +0000 Received: by mail-ed1-x535.google.com with SMTP id a21so4019074edb.1 for ; Sun, 24 Apr 2022 13:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Sf7MisxX3LNkimFSGyyrRktC622uWreucLzzkMFjVxE=; b=ZCIOZskE2WztPBVoBucejcl7KLi6eC4H3SnAqCPc8CvXVbhaKCFqwAOkouOeE3XIw4 Xy2c+vTyka6xFaVskcbnlsDda6uY8l17JywdD5/voUCg6WN8WfLqOfGDW68e9t+zTrEt 0EHyLLmWu+HgvGreor3M+2VVypMDBiYfpZCtdFON1ARa2E2BpkOlpCgpPhP2fFI1EA+5 ObzvHgO+fm64AsNH8zzoWadVcDd/LHj4R65koel07f0BbMnNw0Gw4WNP2zXSvvs9gpKM tU7yAiznylfXsOKwsrA50rAMWixxISSD1TGwBbMsRoIYHTLavXJU2TUKruLGGZJBkdTh YiiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sf7MisxX3LNkimFSGyyrRktC622uWreucLzzkMFjVxE=; b=XurWjOxsQPyMrmXY1l4VLRYlHvoMVqOd0HdRwXL4p619TGa1/KaZFs/EwYqHPJ6op4 QUJEeikOIstMmyopx+OLCfq894YNva40jWSMv+1f7YG0i7wi0Y3uEEE4Z6aHOCPCJn0K wVw7vWFm3NwUzJA0mBLa1Rr9iL0E0fORHd4RM1dXIZhSjyDxr1lp/kUzpbhAHwfhvFQl qCF6rDhZpjpTyWfW+8sSJbLrifKRbHUMB3BXi9ThFJ2yo9K1ok/6Po3OfdGiRXSmvoBg ioZ80W7xKTeaSPSV6uMfIOPjSOeCptedUmHfDxWRRvMW31sWeKp4fDCE8JnUE8RdaYEz tv1A== X-Gm-Message-State: AOAM530nKEm+Is0eG7fI1DNXAX3d/wp6W7RGLh/F72E/iA8L+HCmU3HG NxDYzAI1KvDpATs+epO4i8o= X-Google-Smtp-Source: ABdhPJw9EYpgPzBF7aomsbu5Pu2r+fJI1zxuI2gBwhN5+KDIqR1ckuUKzGAma1SNoXggt53pH+Sczw== X-Received: by 2002:a50:ed11:0:b0:425:c3d1:4547 with SMTP id j17-20020a50ed11000000b00425c3d14547mr12150359eds.410.1650830476615; Sun, 24 Apr 2022 13:01:16 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id x17-20020a170906297100b006e49a9535f3sm2893176ejd.114.2022.04.24.13.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Apr 2022 13:01:16 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Maxime Ripard , Samuel Holland Cc: Samuel Holland , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v3 09/14] drm/sun4i: Allow VI layers to be primary planes Date: Sun, 24 Apr 2022 22:01:15 +0200 Message-ID: <2236113.ElGaqSPkdT@kista> In-Reply-To: <20220424162633.12369-10-samuel@sholland.org> References: <20220424162633.12369-1-samuel@sholland.org> <20220424162633.12369-10-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220424_130121_234146_6B80616D X-CRM114-Status: GOOD ( 19.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 24. april 2022 ob 18:26:27 CEST je Samuel Holland napisal(a): > D1's mixer 1 has no UI layers, only a single VI layer. That means the > mixer can only be used if the primary plane comes from this VI layer. > Add the code to handle this case. > > Signed-off-by: Samuel Holland Reviewed-by: Jernej Skrabec Best regards, Jernej Skrabec > --- > > (no changes since v2) > > Changes in v2: > - Use Jernej's patches for mixer mode setting. > > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c b/drivers/gpu/drm/sun4i/ sun8i_vi_layer.c > index bb7c43036dfa..f7d0b082d634 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > @@ -542,6 +542,7 @@ struct sun8i_vi_layer *sun8i_vi_layer_init_one(struct drm_device *drm, > struct sun8i_mixer *mixer, > int index) > { > + enum drm_plane_type type = DRM_PLANE_TYPE_OVERLAY; > u32 supported_encodings, supported_ranges; > unsigned int plane_cnt, format_count; > struct sun8i_vi_layer *layer; > @@ -560,12 +561,15 @@ struct sun8i_vi_layer *sun8i_vi_layer_init_one(struct drm_device *drm, > format_count = ARRAY_SIZE(sun8i_vi_layer_formats); > } > > + if (!mixer->cfg->ui_num && index == 0) > + type = DRM_PLANE_TYPE_PRIMARY; > + > /* possible crtcs are set later */ > ret = drm_universal_plane_init(drm, &layer->plane, 0, > &sun8i_vi_layer_funcs, > formats, format_count, > sun8i_layer_modifiers, > - DRM_PLANE_TYPE_OVERLAY, NULL); > + type, NULL); > if (ret) { > dev_err(drm->dev, "Couldn't initialize layer\n"); > return ERR_PTR(ret); > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel