From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework
Date: Mon, 22 Jul 2013 19:07:15 +0200 [thread overview]
Message-ID: <2236509.stVfXyPhpt@amdc1227> (raw)
In-Reply-To: <02cf01ce81f3$6777e5f0$3667b1d0$%kim@samsung.com>
On Tuesday 16 of July 2013 16:09:24 Kukjin Kim wrote:
> Heiko St?bner wrote:
> > This converts the mentioned platforms to use the newly introduced
> > driver
> > for the common clock framework for them.
> >
> > With this the whole legacy clock structure can go away too.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> >
> > arch/arm/boot/dts/s3c2416-smdk2416.dts | 7 +
> > arch/arm/boot/dts/s3c2416.dtsi | 42 ++
> > arch/arm/mach-s3c24xx/Kconfig | 14 +-
> > arch/arm/mach-s3c24xx/Makefile | 5 +-
> > arch/arm/mach-s3c24xx/clock-s3c2416.c | 171 --------
> > arch/arm/mach-s3c24xx/clock-s3c2443.c | 212 ----------
> > arch/arm/mach-s3c24xx/common-s3c2443.c | 677
> > --------------------------->
> > ----
>
> In this case, to use '-D' in format-patch would be better :-)
>
> > arch/arm/mach-s3c24xx/common.c | 18 +-
> > arch/arm/mach-s3c24xx/common.h | 8 +
> > arch/arm/mach-s3c24xx/mach-s3c2416-dt.c | 45 +-
> > arch/arm/mach-s3c24xx/mach-smdk2416.c | 9 +-
> > arch/arm/mach-s3c24xx/mach-smdk2443.c | 9 +-
> > 12 files changed, 102 insertions(+), 1115 deletions(-)
> > delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c2416.c
> > delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c2443.c
> > delete mode 100644 arch/arm/mach-s3c24xx/common-s3c2443.c
> >
> > diff --git a/arch/arm/boot/dts/s3c2416-smdk2416.dts
> > b/arch/arm/boot/dts/s3c2416-smdk2416.dts
> > index 59594cf..9caeb89 100644
> > --- a/arch/arm/boot/dts/s3c2416-smdk2416.dts
> > +++ b/arch/arm/boot/dts/s3c2416-smdk2416.dts
> > @@ -19,6 +19,13 @@
> >
> > reg = <0x30000000 0x4000000>;
> >
> > };
> >
> > + fixed-rate-clocks {
> > + xti {
> > + compatible = "samsung,clock-xti";
> > + clock-frequency = <12000000>;
> > + };
> > + };
> > +
> >
> > serial at 50000000 {
> >
> > status = "okay";
> > pinctrl-names = "default";
> >
> > diff --git a/arch/arm/boot/dts/s3c2416.dtsi
> > b/arch/arm/boot/dts/s3c2416.dtsi
> > index e6555bd..c19d99c 100644
> > --- a/arch/arm/boot/dts/s3c2416.dtsi
> > +++ b/arch/arm/boot/dts/s3c2416.dtsi
> > @@ -8,6 +8,7 @@
> >
> > * published by the Free Software Foundation.
> > */
> >
> > +#include <dt-bindings/clock/samsung,s3c2443-clock.h>
> >
> > #include "s3c24xx.dtsi"
> > #include "s3c2416-pinctrl.dtsi"
> >
> > @@ -28,26 +29,53 @@
> >
> > compatible = "samsung,s3c2416-irq";
> >
> > };
> >
> > + clocks: clock-controller at 0x4c000000 {
>
> + clock: clock-controller at 0x4c000000 {
>
> for keeping same format for Samsung stuff...
>
Also please remove the "0x" from node name.
> > + compatible = "samsung,s3c2416-clock";
> > + reg = <0x4c000000 0x40>;
> > + #clock-cells = <1>;
> > + };
> > +
> >
> > pinctrl at 56000000 {
> >
> > compatible = "samsung,s3c2416-pinctrl";
> >
> > };
> >
> > + timer at 51000000 {
> > + clocks = <&clocks PCLK_PWM>;
>
> + clocks = <&clock PCLK_PWM>;
>
> And I'm not sure using definition PCLK_PWM is better here...
Care to explain your doubts about it? I think this is fine.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-07-22 17:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 22:57 [PATCH v2 0/6] Convert S3C2416 ad S3C2443 to common clock framework Heiko Stübner
2013-07-09 22:57 ` [PATCH v2 1/6] clk: samsung: move common plls registration into separate function Heiko Stübner
2013-07-10 16:59 ` Yadwinder Singh Brar
2013-07-11 7:46 ` Tomasz Figa
2013-07-11 8:52 ` Heiko Stübner
2013-08-02 21:35 ` Mike Turquette
2013-07-09 22:58 ` [PATCH v2 2/6] clk: samsung: fix error handling in pll register functions Heiko Stübner
2013-07-11 7:50 ` Tomasz Figa
2013-07-09 22:59 ` [PATCH v2 3/6] clk: samsung: add plls used in s3c2416 and s3c2443 Heiko Stübner
2013-07-11 8:16 ` Tomasz Figa
2013-07-11 8:50 ` Heiko Stübner
2013-07-11 9:25 ` Tomasz Figa
2013-07-09 22:59 ` [PATCH v2 4/6] ARM: S3C24XX: enable legacy clock code only when SAMSUNG_CLOCK selected Heiko Stübner
2013-07-09 23:00 ` [PATCH v2 5/6] clk: samsung: add clock-driver for s3c2416, s3c2443 and s3c2450 Heiko Stübner
2013-07-11 9:13 ` Tomasz Figa
2013-07-09 23:00 ` [PATCH v2 6/6] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework Heiko Stübner
2013-07-16 7:09 ` Kukjin Kim
2013-07-22 17:07 ` Tomasz Figa [this message]
2013-07-24 12:59 ` Kukjin Kim
2013-07-24 14:01 ` Tomasz Figa
2013-08-05 17:03 ` Kukjin Kim
2013-07-10 8:47 ` [PATCH v2 0/6] Convert S3C2416 ad S3C2443 " Thomas Abraham
2013-08-05 17:05 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2236509.stVfXyPhpt@amdc1227 \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox