From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C521BC10F14 for ; Tue, 15 Oct 2019 20:11:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F3D420873 for ; Tue, 15 Oct 2019 20:11:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A1OQKhUP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F3D420873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i72wxzJktlF0iPADay+P4DY+7TMiRZNzeGkh9HYUP0I=; b=A1OQKhUPJlxsLB jUNxg8kII+llZtsk2Ux8DIYjE6PfRvUd2TX+pdgfYtu01esd5dFFCtTSqPX4kgmFhkqzhvxtfBmB5 XxRldh1Oa1HEPq2huCe0HWzykIVTwTw38y8epzENGJ9EZd93KXNcwnJdeitSSnVu6dryWTdIip1M3 p6usSvg/YZn0VV5WL1X7zlmjb/yfpx45j4TjW2QAaS4jY4EJSrtCg2g9gBMNbjx9oHMJygaAI04Bw 5HiB6I+IkIKpfm02w5oUwlIS5c+Vn6BEhnTrT+o1LErz7KXTnbPBSf2EKLx158CJg2rPV71gTSnFk iuwQE5oxrT+lPACxQrPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKT9t-0007Ji-Tb; Tue, 15 Oct 2019 20:11:05 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKT9g-000793-Bi; Tue, 15 Oct 2019 20:10:54 +0000 Received: from remote.shanghaihotelholland.com ([46.44.148.63] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKT9c-00080l-5K; Tue, 15 Oct 2019 22:10:48 +0200 From: Heiko Stuebner To: Johan Jonker Subject: Re: [PATCH 2/2] include: dt-bindings: rockchip: remove RK_FUNC defines Date: Tue, 15 Oct 2019 22:10:42 +0200 Message-ID: <2236841.lnJlJmhppS@phil> In-Reply-To: <20191015191000.2890-2-jbx6244@gmail.com> References: <20191015191000.2890-1-jbx6244@gmail.com> <20191015191000.2890-2-jbx6244@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191015_131052_550323_678DAF79 X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Johan, Am Dienstag, 15. Oktober 2019, 21:10:00 CEST schrieb Johan Jonker: > The defines RK_FUNC_1, RK_FUNC_2, RK_FUNC_3 and RK_FUNC_4 > are no longer used, so remove them to prevent > that someone start using them again. That won't work. Devicetree provides a slightly flexible promise of backwards compatibilty. So a new kernel should still work old devicetrees. (not exactly sure if this means dt-binaries and sources or only binaries) So while I think RK_FUNC_0-n should not be used anymore, we should probably just mark them as "deprecated" in a first step. Heiko > Signed-off-by: Johan Jonker > --- > include/dt-bindings/pinctrl/rockchip.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/dt-bindings/pinctrl/rockchip.h b/include/dt-bindings/pinctrl/rockchip.h > index dc5c1c73d..2798b6c03 100644 > --- a/include/dt-bindings/pinctrl/rockchip.h > +++ b/include/dt-bindings/pinctrl/rockchip.h > @@ -50,9 +50,5 @@ > #define RK_PD7 31 > > #define RK_FUNC_GPIO 0 > -#define RK_FUNC_1 1 > -#define RK_FUNC_2 2 > -#define RK_FUNC_3 3 > -#define RK_FUNC_4 4 > > #endif > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel