Re: [PATCH 25/28] iio: pressure: mprls0025pa: use = { } instead of memset()

Jonathan Cameron
2025-06-14T12:26:53Z

On Wed, 11 Jun 2025 17:39:17 -0500
David Lechner <dlechner@baylibre.com> wrote:

> Use { } instead of memset() to zero-initialize stack memory to simplify
> the code.
>
> The initialize of the cmd value is trivial so it can be moved to the
> array initializer as well.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> drivers/iio/pressure/mprls0025pa_i2c.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/pressure/mprls0025pa_i2c.c b/drivers/iio/pressure/mprls0025pa_i2c.c
> index 1a48f8d43d716b28b8fceb8e1a06d63a73a74a86..79811fd4a02b370b3fde8bd67a5115a3934f8614 100644
> --- a/drivers/iio/pressure/mprls0025pa_i2c.c
> +++ b/drivers/iio/pressure/mprls0025pa_i2c.c
> @@ -44,10 +44,7 @@ static int mpr_i2c_write(struct mpr_data *data, const u8 cmd, const u8 unused)
> {
> int ret;
> struct i2c_client *client = to_i2c_client(data->dev);
> - u8 wdata[MPR_PKT_SYNC_LEN];
> -
> - memset(wdata, 0, sizeof(wdata));
> - wdata[0] = cmd;
> + u8 wdata[MPR_PKT_SYNC_LEN] = { cmd };

Slight preference for trailing comma after cmd,

>
> ret = i2c_master_send(client, wdata, MPR_PKT_SYNC_LEN);
> if (ret < 0)
>