From: Luca Weiss <luca@z3ntu.xyz>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2 3/3] ARM: qcom_defconfig: order items with savedefconfig
Date: Sat, 23 Jul 2022 20:17:50 +0200 [thread overview]
Message-ID: <2246145.ElGaqSPkdT@g550jk> (raw)
In-Reply-To: <2a865367-47b2-ccde-869e-942252a08c5c@linaro.org>
On Samstag, 23. Juli 2022 19:36:17 CEST Krzysztof Kozlowski wrote:
> On 23/07/2022 11:58, Luca Weiss wrote:
> > See also
> > https://lore.kernel.org/linux-arm-msm/20191104210943.101393-1-luca@z3ntu.x
> > yz/ (never applied for some reason)
>
> Mentioned patch is incorrect so should not be applied - it removes at
> least TMPFS which is not desired. I did not check other removed symbols.
For this example: TMPFS is still enabled after this, it's selected by other
options, like DRM or COMMON_CLK.
Imo not doing this just hides the brokeness as options wouldn't get selected
anyways when you do "make qcom_defconfig". Savedefconfig afterwards just puts
reality into the defconfig file. And yes, if some option gets lost then some
dependency for it probably needs to get enabled as well and this should get
fixed.
Regards
Luca
>
>
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-23 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 15:53 [PATCH v2 0/3] ARM: qcom: defconfig: socinfo + cleanup Krzysztof Kozlowski
2022-07-21 15:53 ` [PATCH v2 1/3] ARM: qcom_defconfig: enable socinfo driver Krzysztof Kozlowski
2022-07-21 15:53 ` [PATCH v2 2/3] ARM: qcom: include defconfig in MAINTAINERS Krzysztof Kozlowski
2022-07-21 18:43 ` Konrad Dybcio
2022-07-21 15:53 ` [PATCH v2 3/3] ARM: qcom_defconfig: order items with savedefconfig Krzysztof Kozlowski
2022-07-23 9:58 ` Luca Weiss
2022-07-23 17:30 ` Krzysztof Kozlowski
2022-07-23 17:36 ` Krzysztof Kozlowski
2022-07-23 18:17 ` Luca Weiss [this message]
2022-07-23 18:44 ` Krzysztof Kozlowski
2022-07-23 18:52 ` Luca Weiss
2022-07-23 20:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2246145.ElGaqSPkdT@g550jk \
--to=luca@z3ntu.xyz \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).