From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input
Date: Tue, 04 Apr 2017 13:05:47 +0300 [thread overview]
Message-ID: <2246751.IOz92zzvZ6@avalon> (raw)
In-Reply-To: <1491213319-7668-1-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Monday 03 Apr 2017 11:55:19 Geert Uytterhoeven wrote:
> The X2 crystal oscillator on the Koelsch development board provides a
> 74.25 MHz clock, not a 148.5 MHz clock.
>
> Fixes: cd21cb46e14aae3a ("ARM: shmobile: koelsch: Add DU external pixel
> clocks to DT") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Confirmed by schematics, user manual, and physical inspection of 2
> Koelsch instances (my scope has not enough bandwidth to measure the
> actual frequency).
Stupid question, have you tested the corresponding (HDMI) DU output ? If so,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Probably this was copied from r8a7790-lager.dts, as Lager does have two
> identical crystal oscillators X2 and X13.
>
> Note that X2 is socketed, so it can be changed.
> ---
> arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> b/arch/arm/boot/dts/r8a7791-koelsch.dts index
> 59beb8402a36007b..001e6116c47c7c3b 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -292,7 +292,7 @@
> x2_clk: x2-clock {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> - clock-frequency = <148500000>;
> + clock-frequency = <74250000>;
> };
>
> x13_clk: x13-clock {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-04-04 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 9:55 [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input Geert Uytterhoeven
2017-04-03 10:35 ` Simon Horman
2017-04-04 10:05 ` Laurent Pinchart [this message]
2017-04-04 10:31 ` Geert Uytterhoeven
2017-04-04 11:10 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2246751.IOz92zzvZ6@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).