From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/14] ARM: shmobile: Rename to sh7372_init_early()
Date: Fri, 09 Aug 2013 12:40:20 +0200 [thread overview]
Message-ID: <2247193.aNvcSgPl4V@avalon> (raw)
In-Reply-To: <20130809094926.6530.46771.sendpatchset@w520>
Hi Magnus,
Thank you for the patch.
Shouldn't the subject line mention what you rename ? :-) Same comment for the
other patches in this series.
On Friday 09 August 2013 18:49:26 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Rename sh7372_add_early_device_dt() into sh7372_init_early()
> and make it static since we have no sh7372 DT reference board
> code. Also, in case of DT we do not use any early console or
> early timers, so get rid of early platform stuff and early
> console for the DT case.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> arch/arm/mach-shmobile/include/mach/sh7372.h | 1 -
> arch/arm/mach-shmobile/setup-sh7372.c | 10 ++--------
> 2 files changed, 2 insertions(+), 9 deletions(-)
>
> --- 0007/arch/arm/mach-shmobile/include/mach/sh7372.h
> +++ work/arch/arm/mach-shmobile/include/mach/sh7372.h 2013-08-08
> 15:46:38.000000000 +0900 @@ -63,7 +63,6 @@ extern void sh7372_map_io(void);
> extern void sh7372_earlytimer_init(void);
> extern void sh7372_add_early_devices(void);
> extern void sh7372_add_standard_devices(void);
> -extern void sh7372_add_early_devices_dt(void);
> extern void sh7372_clock_init(void);
> extern void sh7372_pinmux_init(void);
> extern void sh7372_pm_init(void);
> --- 0007/arch/arm/mach-shmobile/setup-sh7372.c
> +++ work/arch/arm/mach-shmobile/setup-sh7372.c 2013-08-08
15:48:51.000000000
> +0900 @@ -1135,15 +1135,9 @@ void __init sh7372_add_early_devices(voi
>
> #ifdef CONFIG_USE_OF
>
> -void __init sh7372_add_early_devices_dt(void)
> +static void __init sh7372_init_early(void)
> {
> shmobile_setup_delay(800, 1, 3); /* Cortex-A8 @ 800MHz */
> -
> - early_platform_add_devices(sh7372_early_devices,
> - ARRAY_SIZE(sh7372_early_devices));
> -
> - /* setup early console here as well */
> - shmobile_setup_console();
> }
>
> static const char *sh7372_boards_compat_dt[] __initdata = {
> @@ -1153,7 +1147,7 @@ static const char *sh7372_boards_compat_
>
> DT_MACHINE_START(SH7372_DT, "Generic SH7372 (Flattened Device Tree)")
> .map_io = sh7372_map_io,
> - .init_early = sh7372_add_early_devices_dt,
> + .init_early = sh7372_init_early,
> .nr_irqs = NR_IRQS_LEGACY,
> .init_irq = sh7372_init_irq,
> .handle_irq = shmobile_handle_irq_intc,
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-08-09 10:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:47 [PATCH 00/14] ARM: shmobile: Cleanups and machine descriptor rework Magnus Damm
2013-08-09 9:47 ` [PATCH 01/14] ARM: shmobile: r8a7779: Remove ->init_machine() special case Magnus Damm
2013-08-09 9:48 ` [PATCH 02/14] ARM: shmobile: r8a7740: " Magnus Damm
2013-08-09 9:48 ` [PATCH 03/14] ARM: shmobile: sh7372: " Magnus Damm
2013-08-09 9:48 ` [PATCH 04/14] ARM: shmobile: sh73a0: " Magnus Damm
2013-08-09 10:47 ` Laurent Pinchart
2013-08-28 6:40 ` Magnus Damm
2013-08-28 12:08 ` Laurent Pinchart
2013-08-28 12:19 ` Magnus Damm
2013-08-30 0:30 ` Laurent Pinchart
2013-08-30 6:58 ` Magnus Damm
2013-08-09 9:48 ` [PATCH 05/14] ARM: shmobile: Remove r8a7740_add_early_devices_dt() Magnus Damm
2013-08-09 9:48 ` [PATCH 06/14] ARM: shmobile: Remove sh73a0_init_irq_dt() Magnus Damm
2013-08-09 9:49 ` [PATCH 07/14] ARM: shmobile: Remove r8a7779 ->nr_irqs Magnus Damm
2013-08-09 9:49 ` [PATCH 08/14] ARM: shmobile: Remove sh73a0 ->nr_irqs Magnus Damm
2013-08-09 9:49 ` [PATCH 09/14] ARM: shmobile: Rename to sh7372_init_early() Magnus Damm
2013-08-09 10:40 ` Laurent Pinchart [this message]
2013-08-09 9:49 ` [PATCH 10/14] ARM: shmobile: Rename to emev2_init_early(), use smp_set_ops() Magnus Damm
2013-08-09 10:41 ` Laurent Pinchart
2013-08-28 7:03 ` Magnus Damm
2013-08-28 7:53 ` Laurent Pinchart
2013-08-09 9:49 ` [PATCH 11/14] ARM: shmobile: Rename to r8a7779_init_early(), " Magnus Damm
2013-08-09 9:49 ` [PATCH 12/14] ARM: shmobile: Rename to r8a7740_init_early() Magnus Damm
2013-08-09 9:50 ` [PATCH 13/14] ARM: shmobile: Rename to r8a7778_init_early() Magnus Damm
2013-08-09 9:50 ` [PATCH 14/14] ARM: shmobile: Rename to sh73a0_init_early(), use smp_set_ops() Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2247193.aNvcSgPl4V@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).