public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Rui Miguel Silva <rmfrfs@gmail.com>,
	Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: (EXT) Re: [PATCH 5/8] media: imx: imx7_mipi_csis: store colorspace in set_fmt as well
Date: Mon, 07 Feb 2022 10:55:33 +0100	[thread overview]
Message-ID: <22528721.6Emhk5qWAg@steina-w> (raw)
In-Reply-To: <Yf3uZ9fzQ4UM76gs@pendragon.ideasonboard.com>

Hi Laurent,

Am Samstag, 5. Februar 2022, 04:26:31 CET schrieb Laurent Pinchart:
> Hi Alexander,
> 
> Thank you for the patch.
> 
> On Fri, Feb 04, 2022 at 01:15:11PM +0100, Alexander Stein wrote:
> > Without this the default (SMPTE 170M) from init_cfg stays unchanged.
> > Even after configuring 'srgb' colorspace (or 'raw')
> > $ media-ctl -V "'csis-32e30000.mipi-csi':0 [colorspace:srgb]"
> > the colorspace does not change at all:
> > $ media-ctl --get-v4l2 "'csis-32e30000.mipi-csi':0"
> > 
> >   [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:smpte170m xfer:709
> >   
> >    ycbcr:601 quantization:lim-range]
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  drivers/staging/media/imx/imx7-mipi-csis.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c
> > b/drivers/staging/media/imx/imx7-mipi-csis.c index
> > a22d0e6b3d44..7b0e57efcf82 100644
> > --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> > @@ -1062,6 +1062,7 @@ static int mipi_csis_set_fmt(struct v4l2_subdev *sd,
> > 
> >  	fmt->code = csis_fmt->code;
> >  	fmt->width = sdformat->format.width;
> >  	fmt->height = sdformat->format.height;
> > 
> > +	fmt->colorspace = sdformat->format.colorspace;
> 
> Looks good, but shouldn't you also store the other colorspace-related
> fields (ycbcr_enc, quantization and xfer_func) ?

Thanks for that feedback. Sounds reasonable, will do that. 

Regards,
Alexander




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-07  9:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 12:15 [PATCH 0/8] imx7/imx8mm media / csi patches Alexander Stein
2022-02-04 12:15 ` [PATCH 1/8] media: imx: Store the type of hardware implementation Alexander Stein
2022-02-05  3:21   ` Laurent Pinchart
2022-02-07  9:22     ` (EXT) " Alexander Stein
2022-02-08  1:26       ` Laurent Pinchart
2022-02-04 12:15 ` [PATCH 2/8] media: imx: Forward " Alexander Stein
2022-02-05  3:41   ` Laurent Pinchart
2022-02-04 12:15 ` [PATCH 3/8] media: imx: Use dedicated format handler for i.MX7/8 Alexander Stein
2022-02-05  4:04   ` Laurent Pinchart
2022-02-07 12:08     ` (EXT) " Alexander Stein
2022-02-04 12:15 ` [PATCH 4/8] media: imx: Fail conversion if pixel format not supported Alexander Stein
2022-02-05  4:07   ` Laurent Pinchart
2022-02-05  7:51     ` Dorota Czaplejewicz
2022-02-07  9:52       ` (EXT) " Alexander Stein
2022-02-08  1:14         ` Laurent Pinchart
2022-02-04 12:15 ` [PATCH 5/8] media: imx: imx7_mipi_csis: store colorspace in set_fmt as well Alexander Stein
2022-02-05  3:26   ` Laurent Pinchart
2022-02-07  9:55     ` Alexander Stein [this message]
2022-02-04 12:15 ` [PATCH 6/8] media: imx: imx7_media-csi: Add support for additional Bayer patterns Alexander Stein
2022-02-05  3:40   ` Laurent Pinchart
2022-02-07 10:01     ` (EXT) " Alexander Stein
2022-02-04 12:15 ` [PATCH 7/8] media: imx: utils: Add more Bayer formats Alexander Stein
2022-02-05  3:31   ` Laurent Pinchart
2022-02-07 10:35     ` (EXT) " Alexander Stein
2022-02-04 12:15 ` [PATCH 8/8] [DNI] arm64: dts: tqma8mqml: add IMX327 MIPI-CSI overlay Alexander Stein
2022-02-05  3:16 ` [PATCH 0/8] imx7/imx8mm media / csi patches Laurent Pinchart
2022-02-07  8:59   ` (EXT) " Alexander Stein
2022-02-08  1:20     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22528721.6Emhk5qWAg@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=dorota.czaplejewicz@puri.sm \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rmfrfs@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox