From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66413C433EF for ; Mon, 7 Feb 2022 09:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m7X+Buk2NUEuR1mZAEnqjAl+c0Uo/+KdnnOCR3h3njo=; b=bGtj/mp1lvnSLx jq1ZEkuNx/hKIMlTtFj0AS7yzXYoUJybtHCT8lhqJyXuuum0S7t+8gC/ZRUyx+WEz2K7OqlNHGPhY 5CzV3/M/RU7DSyJovbfPDno5BROURpcsfEqiBM66wun+UkicKYg0JP8LuPYUH/WZ8yjkyza55g6wX KzB/Jfx2Tff8eYhkrjB8Xvp1wPT9f55nyLx8tjf3eQbU2GRWfr9lx7ei5Di7QzKeLwnxEyMN/e7PY RAWgc7rxgXrIRvo1+ZyDS1gPU1xLu5bn8rqXKEGtfblI7PeaowBNxGTz9TIvEJjg+/CbfJKh9kN7u cweASB7PlG4M63hjiA3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH0kL-009geO-Ne; Mon, 07 Feb 2022 09:55:45 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH0kD-009gbx-On for linux-arm-kernel@lists.infradead.org; Mon, 07 Feb 2022 09:55:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1644227737; x=1675763737; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZZVRjRyATxf2Qkee+j9MOy2u+QDZKwKyc2bx88y3hm0=; b=l/NTX8K3KBVeMsdhw/VvVALyLCVJsGmM6w573VVtapcAtNk9yA5aHi8j htEO3uDdyKNmmQSuw03xTxL6x3DWJq8x6s4pFwmRM1J74M6axJ6bE1JZd ww0EaFOjWAryaLroYxgnZeK0Lp4Ds2u7p5QqC9y0PkrYmrr3TQzXqEYtc h7YZL/Qkdr8f06YQEj1nP0vzjA/g/yqwXe0vK4t+I7Gh+w8m7w+y8Rs+m 1hGqP/0JVVgQhdA8CGBa6N8FFTnxanh3fUj+BEM/02h+eB/48A0ZNYy8H ssKc2zE9Azd0Fl4mdQcetOZOOIz4U3VLn7Df0mhW+GIp+OeWyksuZ06VC A==; X-IronPort-AV: E=Sophos;i="5.88,349,1635199200"; d="scan'208";a="21927972" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 07 Feb 2022 10:55:35 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 07 Feb 2022 10:55:35 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 07 Feb 2022 10:55:35 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1644227735; x=1675763735; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZZVRjRyATxf2Qkee+j9MOy2u+QDZKwKyc2bx88y3hm0=; b=lbxml+8Wn9Pzsc8pbu6YdlJ4pqaflfVEsVk/UDk89REMBuvD/cP50XUq mzkyiaoDX+QZhACO0e6MBTAZB36UgXq6nTYFDb4wmBcTgxShyXiBrWSh6 zqVAs8Npx/cz57tKRElBvS0ev3Y1wbfS37iyD3Qdmjq0FU0AEBXErpFKg JrKqWXL2U4X6dX1QTAGjZNw54k4jDRY2kPkhLjDKYM0v/qe6JebMjdl4R FuEsH4Cy94yIBmu+bDDaoHjjeyWtnBKIKT0e45gXnNL6XvweRMRCO10ku zd9x6lHhy3PrHis0cx13prilAP1MUcm2KlpX37FRvyp39WYx5oFbzvgvM g==; X-IronPort-AV: E=Sophos;i="5.88,349,1635199200"; d="scan'208";a="21927971" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 07 Feb 2022 10:55:35 +0100 Received: from steina-w.localnet (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 930E1280065; Mon, 7 Feb 2022 10:55:35 +0100 (CET) From: Alexander Stein To: Laurent Pinchart Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rui Miguel Silva , Dorota Czaplejewicz , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: (EXT) Re: [PATCH 5/8] media: imx: imx7_mipi_csis: store colorspace in set_fmt as well Date: Mon, 07 Feb 2022 10:55:33 +0100 Message-ID: <22528721.6Emhk5qWAg@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20220204121514.2762676-1-alexander.stein@ew.tq-group.com> <20220204121514.2762676-6-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220207_015538_166597_CED5AACF X-CRM114-Status: GOOD ( 20.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, Am Samstag, 5. Februar 2022, 04:26:31 CET schrieb Laurent Pinchart: > Hi Alexander, > > Thank you for the patch. > > On Fri, Feb 04, 2022 at 01:15:11PM +0100, Alexander Stein wrote: > > Without this the default (SMPTE 170M) from init_cfg stays unchanged. > > Even after configuring 'srgb' colorspace (or 'raw') > > $ media-ctl -V "'csis-32e30000.mipi-csi':0 [colorspace:srgb]" > > the colorspace does not change at all: > > $ media-ctl --get-v4l2 "'csis-32e30000.mipi-csi':0" > > > > [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:smpte170m xfer:709 > > > > ycbcr:601 quantization:lim-range] > > > > Signed-off-by: Alexander Stein > > --- > > > > drivers/staging/media/imx/imx7-mipi-csis.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c > > b/drivers/staging/media/imx/imx7-mipi-csis.c index > > a22d0e6b3d44..7b0e57efcf82 100644 > > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > > @@ -1062,6 +1062,7 @@ static int mipi_csis_set_fmt(struct v4l2_subdev *sd, > > > > fmt->code = csis_fmt->code; > > fmt->width = sdformat->format.width; > > fmt->height = sdformat->format.height; > > > > + fmt->colorspace = sdformat->format.colorspace; > > Looks good, but shouldn't you also store the other colorspace-related > fields (ycbcr_enc, quantization and xfer_func) ? Thanks for that feedback. Sounds reasonable, will do that. Regards, Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel