From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A41E2C433EF for ; Mon, 25 Apr 2022 15:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4w4F9P2oBoRyliSQbk6eqYf9NeijgFkl73fmbOI4rQI=; b=m1yceSQcrMkw3R DqJEhO8xxA7tqWoyQOC0/8jdgb+/Zjo+/7hx4wWWYTJNRT0UHglCoRR4m3pgE4WPi7H/HCpcghHln bfKkwns6Ix727RNlsrkSy80h5oVTyH+Vwjs3ygKG0cOMwXOlDtdur167Uxl9QjEDY9/UUCSYVBgAA E0dxYiSkea3jFKbM4bg7i6JzYreilg0ObzcmRFOrQqxz3t/5ta9PpN/qKx1YW9E++BMIoXZ4r2Q9C zO3+CLN+JPoyiBN8iSLKqoDCc7zVflxjP45AniqSJfq0pRJwefPZ9fZkLLvlh+a0nUDe4aptKSDOA rxF2jiD57RTfLXcfBd3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj11G-00ABOC-MI; Mon, 25 Apr 2022 15:52:58 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj11C-00ABMm-Tk for linux-arm-kernel@lists.infradead.org; Mon, 25 Apr 2022 15:52:56 +0000 Received: by mail-ed1-x533.google.com with SMTP id p18so13797553edr.7 for ; Mon, 25 Apr 2022 08:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9Oa5NtzGoFrsnzBgz2IkcumAm6ed+VSYE7BO1a3Ir24=; b=EigDBthRvJnsJo+9WGyQqWjg7PowmmzypMiC8CAR7LXfVN0PErUQdRx1RjTfiw4gyH Ee/9Tz8scBrSxmd2kS0fEhDXXWDoDEXtwtrlfZHv6FCexExa+hC+Y28nXmIh1BH4NQiZ 38rCs5GLxbskzJ2hxkt/Idpb8OIRHdqQiNUcHNyGr09IzFxDdD6ZjtDzxbNGVScxWxA8 gbqfgrntqMiIo1NzquxXzc6b6pQii5YbFQG3SACzOxfdYDrb1dgpTgZu8qP8qYVrJxcD XCqcowMpwzVkbsgRfIg8Ygnkkbq/iRf0jNQpNVZ5yWMp9ezfC1mrJWjd9sikNFP5kGHr ILFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9Oa5NtzGoFrsnzBgz2IkcumAm6ed+VSYE7BO1a3Ir24=; b=s3/6L+ii0Zq9R6tUVddWtOK3WeTpu4ixOYtc1InB1jaMpz68vRP4eheRIZlqCvxeOE QfvIOdfPPE2dauIx+8IJXxG5PhLeF0sCmimlQoPPQHb23ZESCRiyghcvE9mw9FCwOa42 Sz+1u8LGhV71stsG0bwGDGLb2XM3qsZL75gJM7W2R+cX0UY7pBtbgUNQsB9+zd367K0P ZutlD5ifehgr7edXX7PihQuzukA3gViQ+L0Tjwctr6ry2ZpgZ9PEAF78rojFILuKcort XTRliwBb0gEknwEBZRTMnlbrblngtvgjkuxTzKRlUSSlNomfSETnA1P3RM69kcfjgTNk 214Q== X-Gm-Message-State: AOAM533liwMBnihC/l+8N+oFRRQVVYO0TzOKGdLeFDNwThazBPWfOlHL zfX0egzjkJjv1PIBcBn1gzo= X-Google-Smtp-Source: ABdhPJzY0KqwmNprJw4wgl5ETDVJprVLMo9vqPy+8A0f/235e2cgQsITwXEEgGimRqQZseTw0/tsbg== X-Received: by 2002:a05:6402:5189:b0:425:d7ca:caa4 with SMTP id q9-20020a056402518900b00425d7cacaa4mr10535349edd.177.1650901971712; Mon, 25 Apr 2022 08:52:51 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id d6-20020a170906304600b006ef5da1b1besm3739347ejd.221.2022.04.25.08.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 08:52:51 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mripard@kernel.org, Ian Cowan Cc: paul.kocialkowski@bootlin.com, mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, ian@linux.cowan.aero Subject: Re: [PATCH] staging: sunxi: cedrus: centralize cedrus_open exit Date: Mon, 25 Apr 2022 17:52:50 +0200 Message-ID: <22617338.6Emhk5qWAg@kista> In-Reply-To: <20220423180111.91602-1-ian@linux.cowan.aero> References: <20220423180111.91602-1-ian@linux.cowan.aero> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_085255_027999_987FF894 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ian, Dne sobota, 23. april 2022 ob 20:01:11 CEST je Ian Cowan napisal(a): > Refactor the cedrus_open() function so that there is only one exit to > the function instead of 2. This prevents a future change from preventing > the mutex from being unlocked after a successful exit. > > Signed-off-by: Ian Cowan If this patch would be part of series and "future" would mean next patch, I would be ok with that. However, in current form I don't see any benefit in changing it. Doing another hop lessens readability IMO. Let us worry about the future when/if it comes. Best regards, Jernej > --- > drivers/staging/media/sunxi/cedrus/cedrus.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/ media/sunxi/cedrus/cedrus.c > index 68b3dcdb5df3..5236d9e4f4e8 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c > @@ -348,14 +348,14 @@ static int cedrus_open(struct file *file) > > v4l2_fh_add(&ctx->fh); > > - mutex_unlock(&dev->dev_mutex); > - > - return 0; > + ret = 0; > + goto succ_unlock; > > err_ctrls: > v4l2_ctrl_handler_free(&ctx->hdl); > err_free: > kfree(ctx); > +succ_unlock: > mutex_unlock(&dev->dev_mutex); > > return ret; > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel