From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D52C2D0BF for ; Tue, 10 Dec 2019 18:26:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56B19206EC for ; Tue, 10 Dec 2019 18:26:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h8dfngzF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56B19206EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=T3VOJXVZ3/sSzB19h/+z0ad2KmuFj9r5DC9nudBeAqA=; b=h8dfngzFvJDyac0TnKrv3tZp9Y ++26d5anWiGSND80Wwk/JKL3l//nFaghd0Rb9ueG05cjFMbfk2hLDjOVk24h85oZf9ZKa1lmwcnEQ FxGVMljlsIvYE3/sSNPfz/8SeOw3Jf/OcBNnzW32VhBfHwWGS5jRI1i3UJpEp048D0Oo9hy+OAnFK GvzdS1x9if7VRDXntXDKH5S+T4a3pSEfh4Wg71+tzFCurJ6hZE04AblP8BtZmB9lOlcS+CJ0FjteK exu5sW5ONqa56dgmVFeZOastKBR2SQ/NrvVpCp7BbzfxUDKbYaNzOetJHVJxluwrdReBpHhBgMeLT DZCrnpDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iekDe-00071w-Qe; Tue, 10 Dec 2019 18:26:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iekDc-00071W-LS for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2019 18:26:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 060981FB; Tue, 10 Dec 2019 10:26:44 -0800 (PST) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 86FA53F6CF; Tue, 10 Dec 2019 10:26:43 -0800 (PST) Subject: Re: [PATCH 04/15] firmware: arm_scmi: Add names to scmi devices created To: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20191210145345.11616-1-sudeep.holla@arm.com> <20191210145345.11616-5-sudeep.holla@arm.com> From: Cristian Marussi Message-ID: <22634361-320b-e08e-d7f2-34a95038e838@arm.com> Date: Tue, 10 Dec 2019 18:26:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191210145345.11616-5-sudeep.holla@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_102644_744789_4E420502 X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi On 10/12/2019 14:53, Sudeep Holla wrote: > Now that scmi bus provides option to create named scmi device, let us > create the default devices with names. This will help to add names for > matching to respective drivers and eventually to add multiple devices > and drivers per protocol. > > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_scmi/driver.c | 36 +++++++++++++++++++++++++++++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 2952fcd8dd8a..0bbdc7c9eb0f 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -829,6 +829,40 @@ scmi_create_protocol_device(struct device_node *np, struct scmi_info *info, > scmi_set_handle(sdev); > } > > +#define MAX_SCMI_DEV_PER_PROTOCOL 2 > +struct scmi_prot_devnames { > + int protocol_id; > + char *names[MAX_SCMI_DEV_PER_PROTOCOL]; > +}; > + > +static struct scmi_prot_devnames devnames[] = { > + { SCMI_PROTOCOL_POWER, { "genpd" },}, > + { SCMI_PROTOCOL_PERF, { "cpufreq" },}, > + { SCMI_PROTOCOL_CLOCK, { "clocks" },}, > + { SCMI_PROTOCOL_SENSOR, { "hwmon" },}, > + { SCMI_PROTOCOL_RESET, { "reset" },}, > +}; > + > +static inline void > +scmi_create_protocol_devices(struct device_node *np, struct scmi_info *info, > + int prot_id) > +{ > + int loop, cnt; > + > + for (loop = 0; loop < ARRAY_SIZE(devnames); loop++) { > + if (devnames[loop].protocol_id != prot_id) > + continue; > + > + for (cnt = 0; cnt < ARRAY_SIZE(devnames[loop].names); cnt++) { > + const char *name = devnames[loop].names[cnt]; > + > + if (name) > + scmi_create_protocol_device(np, info, prot_id, > + name); > + } > + } > +} > + > static int scmi_probe(struct platform_device *pdev) > { > int ret; > @@ -897,7 +931,7 @@ static int scmi_probe(struct platform_device *pdev) > continue; > } > > - scmi_create_protocol_device(child, info, prot_id, NULL); > + scmi_create_protocol_devices(child, info, prot_id); > } > > return 0; > -- > 2.17.1 > I'm a little bit puzzled by the builtin fixed define MAX_SCMI_DEV_PER_PROTOCOL, but I have not really an alternative solution as of now, so looks good to me. Reviewed-by: Cristian Marussi Cheers Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel