From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2091C52D7F for ; Wed, 14 Aug 2024 08:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v93U00J3W/G+3iiDSm+KOsmeueDudNy3zc5gSs6I6cA=; b=pjfdXTpO+Op6t/HypBNH4tejDc RZTXaDHJzWrmpz9GzWvZ8l4L5FV7bxHb/UlFQIykpTk80HlbaU1hH7fH9hlYQluBO48oZeoc75Jmb SYD90bn2FIUcv47uIarUFxnnFYmRBTw4F+oxO8EnfCkpPmVA5LNZzxB+rdtiZHFSBXyTXjAebiwCv RgSAl1agMn6DsY0h2WEgKgBRRThAomdSLDIwYJ9XpbuWYez4aIed3j+HfSpQYafSrXz8ZF4AaW8Sz gZcPbhrpcIBybP3RdHvPtiUi6YhjhtBSklmpeaR2nHMwXsjTiIUHaivTjgGoXElC0sgN6AyLnpJ5n DkdiMjyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1se9fk-00000006GxN-3Zip; Wed, 14 Aug 2024 08:48:01 +0000 Received: from mail-lf1-f49.google.com ([209.85.167.49]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1se9f1-00000006Gof-1Mi5; Wed, 14 Aug 2024 08:47:16 +0000 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52f025bc147so7419425e87.3; Wed, 14 Aug 2024 01:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723625233; x=1724230033; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v93U00J3W/G+3iiDSm+KOsmeueDudNy3zc5gSs6I6cA=; b=Yn2AleP5dHZTxrsDMZZBZI60zrVUyN9iQiUd6LaQnqGoTqv0DbrhA8Nb5uGByYBjer h/D9MW/bL8cGyNm4/zmLkdSeG4MSM3GjE5MzxEQZtBGi8cpgT871Ki7GGNsETEYTZ8qi CsI2zTwskl29k+XjXJu0nw8D3dJwKxJihJnredSpIUQ9BtDbbDOq/45dNvupolIjpfd+ rhQEdeHMr37J6QMTjTzGRRsB9WlJO0i/1g5re8cbFWiNJlOnEJI4kq1rN36VD7EV5dW8 xdAgpYhboIFXGfE7OPIGOBVr6tcVL8/FJ8kYGRPLUT2U+L28+mKP2CvWJlohufr2ct2G S7eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723625233; x=1724230033; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v93U00J3W/G+3iiDSm+KOsmeueDudNy3zc5gSs6I6cA=; b=rOKFH+glRDOZZR3yu1DLuHJSf0DqekEuHEa3uYTatKnQ+NiEy6mojBUedd8hFA7Sh7 sR5BmtN6yG/P95M8+QKO8c4VBP99370hkqj6qmGMC7Pthl7lFmWsI7zdDJvJNviH7Qau mLqadoiI4NWt0CEfWCzkTa0/ptt43IFLhIPZckSYc5fXIFMpTUWClryrbMSFt2EMiFrV pLGLaMhaZVWnlPWsJryadMf6JYJqwHuX+Irn/jwHp1LYZKzF1PKjD5Nw7jNz2V6PanmH MR6RqLDKc2jhrQ4/HQ+QBOrkX3kabzC/7oWJ1qNf1dewLfbcS0eILWXwX3na8MuxmXi7 ++gg== X-Forwarded-Encrypted: i=1; AJvYcCUkAVp3YIitn8BtaW8h1GOkytF4p9q1tR9hsKYZ0gxKn6SBwb4YgVSJO/lK/rwylGhRmfbH9IqLVARfTBFxnTFL/49gzZvp52X/HcpS55uIJK8STgAdV+354Karv1T+2dX3HZfYHUACT7+Q/UQlpDhUZqTW5fDgBzc= X-Gm-Message-State: AOJu0YwcoHuWwVI/cJrcfUkuxEl9f67VVlX4cUNQBVWyR7Vcf4rC7acf 6i1An4TsHkfKEymHnuWi9rtAe0/nPzXC5r6EccRyLBT3Q8N5RveuhpBSRhrjZMOUyA== X-Google-Smtp-Source: AGHT+IH4EjACtsvCABaDeBjsVWwwYox558+OITuZDnWDDQJqpAVHjQXpEtVnsv3StoTxLrge71ISzA== X-Received: by 2002:a05:6512:118f:b0:516:d219:3779 with SMTP id 2adb3069b0e04-532edbd5a4emr1271567e87.58.1723625232130; Wed, 14 Aug 2024 01:47:12 -0700 (PDT) Received: from latitude-fedora.localnet ([194.247.191.114]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53200f42241sm1180073e87.265.2024.08.14.01.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 01:47:11 -0700 (PDT) From: Alexey Charkov To: Jacobe Zang , robh@kernel.org, krzk+dt@kernel.org, heiko@sntech.de, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, conor+dt@kernel.org, linux-rockchip@lists.infradead.org Cc: efectn@protonmail.com, dsimic@manjaro.org, jagan@edgeble.ai, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, arend@broadcom.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, megi@xff.cz, duoming@zju.edu.cn, bhelgaas@google.com, minipli@grsecurity.net, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, nick@khadas.com, Sai Krishna , Arend van Spriel Subject: Re: [PATCH v10 4/5] wifi: brcmfmac: Add optional lpo clock enable support Date: Wed, 14 Aug 2024 11:47:09 +0300 Message-ID: <2269063.vFx2qVVIhK@latitude-fedora> In-Reply-To: <721da64c-42ec-4be6-8ad3-e2685a84823a@broadcom.com> References: <20240813082007.2625841-1-jacobe.zang@wesion.com> <20240813082007.2625841-5-jacobe.zang@wesion.com> <721da64c-42ec-4be6-8ad3-e2685a84823a@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_014715_419562_C85B77C5 X-CRM114-Status: GOOD ( 26.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arend, Jacobe, On Tuesday, August 13, 2024 2:57:28=E2=80=AFPM GMT+3 Arend van Spriel wrote: > On 8/13/2024 10:20 AM, Jacobe Zang wrote: > > WiFi modules often require 32kHz clock to function. Add support to > > enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check > > to the top of brcmf_of_probe. Change function prototypes from void > > to int and add appropriate errno's for return values that will be > > send to bus when error occurred. >=20 > I was going to say it looks good to me, but.... >=20 > > Co-developed-by: Ondrej Jirman > > Signed-off-by: Ondrej Jirman > > Co-developed-by: Arend van Spriel > > Signed-off-by: Arend van Spriel > > Reviewed-by: Sai Krishna > > Signed-off-by: Jacobe Zang > > --- > >=20 > > .../broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 +- > > .../broadcom/brcm80211/brcmfmac/common.c | 3 +- > > .../wireless/broadcom/brcm80211/brcmfmac/of.c | 53 +++++++++++-------- > > .../wireless/broadcom/brcm80211/brcmfmac/of.h | 9 ++-- > > .../broadcom/brcm80211/brcmfmac/pcie.c | 3 ++ > > .../broadcom/brcm80211/brcmfmac/sdio.c | 22 +++++--- > > .../broadcom/brcm80211/brcmfmac/usb.c | 3 ++ > > 7 files changed, 61 insertions(+), 36 deletions(-) >=20 > [...] >=20 > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c > > b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c index > > e406e11481a62..f19dc7355e0e8 100644 > > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c > > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c >=20 > [...] >=20 > > @@ -113,33 +118,39 @@ void brcmf_of_probe(struct device *dev, enum > > brcmf_bus_type bus_type,>=20 > > of_node_put(root); > > =09 > > } > >=20 > > - if (!np || !of_device_is_compatible(np, "brcm,bcm4329-fmac")) > > - return; > > - > >=20 > > err =3D brcmf_of_get_country_codes(dev, settings); > > if (err) > > =09 > > brcmf_err("failed to get OF country code map (err=3D%d) \n", err); > > =09 > > of_get_mac_address(np, settings->mac); > >=20 > > - if (bus_type !=3D BRCMF_BUSTYPE_SDIO) > > - return; > > + if (bus_type =3D=3D BRCMF_BUSTYPE_SDIO) { >=20 > Don't like the fact that this now has an extra indentation level and it > offers no extra benefit. Just keep the original if-statement and return > 0. Consequently the LPO clock code should move just before the if-stateme= nt. > > + if (of_property_read_u32(np, "brcm,drive-strength",=20 &val) =3D=3D 0) > > + sdio->drive_strength =3D val; > >=20 > > - if (of_property_read_u32(np, "brcm,drive-strength", &val) =3D=3D 0) > > - sdio->drive_strength =3D val; > > + /* make sure there are interrupts defined in the node */ > > + if (!of_property_present(np, "interrupts")) > > + return 0; > >=20 > > - /* make sure there are interrupts defined in the node */ > > - if (!of_property_present(np, "interrupts")) > > - return; > > + irq =3D irq_of_parse_and_map(np, 0); > > + if (!irq) { > > + brcmf_err("interrupt could not be=20 mapped\n"); > > + return 0; > > + } > > + irqf =3D irqd_get_trigger_type(irq_get_irq_data(irq)); > > + > > + sdio->oob_irq_supported =3D true; > > + sdio->oob_irq_nr =3D irq; > > + sdio->oob_irq_flags =3D irqf; > > + } > >=20 > > - irq =3D irq_of_parse_and_map(np, 0); > > - if (!irq) { > > - brcmf_err("interrupt could not be mapped\n"); > > - return; > > + clk =3D devm_clk_get_optional_enabled(dev, "lpo"); > > + if (!IS_ERR_OR_NULL(clk)) { > > + brcmf_dbg(INFO, "enabling 32kHz clock\n"); > > + return clk_set_rate(clk, 32768); > > + } else { > > + return PTR_ERR_OR_ZERO(clk); > >=20 > > } >=20 > Change this to: > > + clk =3D devm_clk_get_optional_enabled(dev, "lpo"); > > + if (IS_ERR_OR_NULL(clk)) { > > + return PTR_ERR_OR_ZERO(clk); Perhaps in this case we should go for IS_ERR and PTR_ERR respectively.=20 devm_clk_get_optional_enabled would return NULL when the optional clock is = not=20 found, so NULL is not an error state but serves as a dummy clock that can b= e=20 used with clk_set_rate. This way we won't skip over the interrupts initialization below in case the= =20 clock is absent. > > + } > > + brcmf_dbg(INFO, "enabling 32kHz clock\n"); > > + clk_set_rate(clk, 32768); >=20 > As said above this should be moved before the if-statement: > > - if (bus_type !=3D BRCMF_BUSTYPE_SDIO) > > - return 0; > >=20 > > - irqf =3D irqd_get_trigger_type(irq_get_irq_data(irq)); > >=20 > > - sdio->oob_irq_supported =3D true; > > - sdio->oob_irq_nr =3D irq; > > - sdio->oob_irq_flags =3D irqf; > > + return 0; > >=20 > > } Best regards, Alexey