From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13A19C05027 for ; Tue, 14 Mar 2023 19:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2KCjKvydKUQ3u3XqUDv8/jQvOVehMPQZHFhsSSHoMeI=; b=h3CLakGTzkGGUT rd+IuLkF5lUzG0CjQdxf32iwVR75BrkTOswhAxIy+NgqRyTyE2d/3NjQrNCUfgQHyMYrbbgi2RX83 0iM1CmT1yZaD9Hg/gbgGe0ywuQGe45vFU+evqCFF8Pdk8WDfGiLV8Y7ZyVBw6QlJ0fyCF5pe5T8J3 G2TZSxVkof0kv/5wdKqjT9uYWtXkOORpbqGylRWfRIpmC5V+xC7NHoyOan9KtSlm6RS1Wx//VOZ+L 37JpsMhe1tz/Embvo+7ZYwO8iOEtyXEACnzN7UjIOMyZDFPAPCG3ZnmD2gpFhDg0oeNpKH/CWLGnv fmnr/cjRO6dqNVgu8Vjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcAi8-00BOCn-08; Tue, 14 Mar 2023 19:53:28 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcAi5-00BOB9-0C for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 19:53:26 +0000 Received: by mail-ed1-x52d.google.com with SMTP id eh3so10834187edb.11 for ; Tue, 14 Mar 2023 12:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678823604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vsp8Tj0Vktuf9bbrjDiQaJ9V5M9finhOPDw8dAUIlFQ=; b=QRy9UBfQi/bmZP2AMa6LauQh1VorDM8ZrVcpeEFJYZ0LnAdvOX5JcghVGOPDf9/TCR Xlk2evnPwBe60SCL69UtvMbHoKjI8gItlfvKSKOUzlFyhzZT01xFoux8YD20tQTXYEX3 c6QlWOR9qWYRN4QLaTLo+cJlnTO1sRmnUOm3au7yxfk9EkmGVge91mhj0KHUV5TfILZa kbof++5IA8CBHsvpSOONobt2u4aPz3OyyubfLNXApoUzYEEBms6jR1RANbdfRpW0LcrQ 7NiGinbujqirCtCbGGGLsTi48KwMpfqyUF2YtVAjd9gizGEAGeTmoq9uxYdAeVZ3+s4B v4qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678823604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vsp8Tj0Vktuf9bbrjDiQaJ9V5M9finhOPDw8dAUIlFQ=; b=HqQGOu+agMZKnxcACpBZSjN/sCH9A7+6cInh99aPcttXQt/muri22RzFEzpmT9ozNs OtQ7RKnJq090V0d8fBduFp5TK98xL+Q0HoiEHDgFLvUHxrwTGnRASDZnn8Z1doT8Mry/ EnA2PnTRzAUpt3zjWFRCY0pddqSYEPo9miH6cZ2/Bdlz2C+tE5tE7bIRikNTCI2JsuSY wqi6qcXMBMOWkco9YysNmFveh9Zl8OoiP1RyBSErJ5LVsN1oocU05J2VaPSr9EKVYrvO eurjbuVaimOhHZ8TfYQikBbJPRdE7ZuBAUjfrpGAuy/7QXnaAmnMW6NRt+OMkBif4bwe xuqA== X-Gm-Message-State: AO0yUKXgATIWuVoUy6piK1tjJRuDuclw1rmGBqcagpYi8JE8F+HHuoQe EskrmaNIYGR4m+oZ49hZFQM= X-Google-Smtp-Source: AK7set/aZQdUOqZ2pfdQ1/SmUcMim+rOjI0ri/3qpQg1f1JZzTN0Sb5PQFFOEMQcK+x6rxZijFw+9w== X-Received: by 2002:a17:906:dc3:b0:839:74cf:7c4f with SMTP id p3-20020a1709060dc300b0083974cf7c4fmr4344319eji.8.1678823603740; Tue, 14 Mar 2023 12:53:23 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id rq4-20020a17090788c400b00927341bf69dsm1523827ejc.88.2023.03.14.12.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 12:53:23 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mchehab@kernel.org, Zheng Wang Cc: hverkuil@xs4all.nl, wens@csie.org, samuel@sholland.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: Re: [PATCH v2] media: cedrus: fix use after free bug in cedrus_remove due to race condition Date: Tue, 14 Mar 2023 20:53:22 +0100 Message-ID: <2274018.ElGaqSPkdT@jernej-laptop> In-Reply-To: <20230313163120.3741811-1-zyytlz.wz@163.com> References: <20230313163120.3741811-1-zyytlz.wz@163.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_125325_099729_6A273856 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 13. marec 2023 ob 17:31:20 CET je Zheng Wang napisal(a): > In cedrus_probe, dev->watchdog_work is bound with cedrus_watchdog function. > In cedrus_device_run, it will started by schedule_delayed_work. If there is > an unfinished work in cedrus_remove, there may be a race condition and > trigger UAF bug. > > CPU0 CPU1 > > |cedrus_watchdog > > cedrus_remove | > v4l2_m2m_release | > kfree(m2m_dev) | > > | v4l2_m2m_get_curr_priv > | > | m2m_dev //use > > Fix it by canceling the worker in cedrus_remove. > > Fixes: 7c38a551bda1 ("media: cedrus: Add watchdog for job completion") > Signed-off-by: Zheng Wang > --- > v2: > - use cancel_delayed_work_sync instead and add Fixes > label suggested by Hans Verkuil > --- > drivers/staging/media/sunxi/cedrus/cedrus.c | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Jernej Skrabec Best regards, Jernej > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c > b/drivers/staging/media/sunxi/cedrus/cedrus.c index > a43d5ff66716..a50a4d0a8f71 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c > @@ -547,6 +547,7 @@ static int cedrus_remove(struct platform_device *pdev) > { > struct cedrus_dev *dev = platform_get_drvdata(pdev); > > + cancel_delayed_work_sync(&dev->watchdog_work); > if (media_devnode_is_registered(dev->mdev.devnode)) { > media_device_unregister(&dev->mdev); > v4l2_m2m_unregister_media_controller(dev->m2m_dev); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel