Re: [PATCH 1/2] bus: imx-aipstz: allow creating pdevs for child buses

[Alexander Stein <alexander.stein@ew.tq-group.com>]

Hi,

Am Dienstag, 8. Juli 2025, 01:46:27 CEST schrieb Laurentiu Mihalcea:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> devm_of_platform_populate() passes a NULL as the bus OF match table
> to the underlying of_platform_populate(), meaning child bus devices
> of the AIPSTZ bridge will not have its children devices created. Since
> some SoCs (e.g. i.MX8MP) use this particular setup (e.g. SPBA bus, which
> is a child of AIPSTZ5 and has multiple child nodes), the driver needs to
> support it.
> 
> Therefore, replace devm_of_platform_populate() with of_platform_populate()
> and pass a reference to the bus OF match table to it. For now, the only
> possible child buses are simple buses.
> 
> Since the usage of devres is dropped, the complementary operation of
> of_platform_populate() needs to be called during the driver's removal.
> 
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> Fixes: 796cba2dd4d9 ("bus: add driver for IMX AIPSTZ bridge")
> Reported-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Closes: https://lore.kernel.org/lkml/5029548.31r3eYUQgx@steina-w/#t

Thanks, with this SAI devices are probed again.

Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> ---
>  drivers/bus/imx-aipstz.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/imx-aipstz.c b/drivers/bus/imx-aipstz.c
> index 6610251f41c7..5fdf377f5d06 100644
> --- a/drivers/bus/imx-aipstz.c
> +++ b/drivers/bus/imx-aipstz.c
> @@ -26,6 +26,11 @@ static void imx_aipstz_apply_default(struct imx_aipstz_data *data)
>  	writel(data->default_cfg->mpr0, data->base + IMX_AIPSTZ_MPR0);
>  }
>  
> +static const struct of_device_id imx_aipstz_match_table[] = {
> +	{ .compatible = "simple-bus", },
> +	{ }
> +};
> +
>  static int imx_aipstz_probe(struct platform_device *pdev)
>  {
>  	struct imx_aipstz_data *data;
> @@ -49,7 +54,13 @@ static int imx_aipstz_probe(struct platform_device *pdev)
>  	pm_runtime_set_active(&pdev->dev);
>  	devm_pm_runtime_enable(&pdev->dev);
>  
> -	return devm_of_platform_populate(&pdev->dev);
> +	return of_platform_populate(pdev->dev.of_node, imx_aipstz_match_table,
> +				    NULL, &pdev->dev);
> +}
> +
> +static void imx_aipstz_remove(struct platform_device *pdev)
> +{
> +	of_platform_depopulate(&pdev->dev);
>  }
>  
>  static int imx_aipstz_runtime_resume(struct device *dev)
> @@ -83,6 +94,7 @@ MODULE_DEVICE_TABLE(of, imx_aipstz_of_ids);
>  
>  static struct platform_driver imx_aipstz_of_driver = {
>  	.probe = imx_aipstz_probe,
> +	.remove = imx_aipstz_remove,
>  	.driver = {
>  		.name = "imx-aipstz",
>  		.of_match_table = imx_aipstz_of_ids,
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/