From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79AABC3271E for ; Thu, 11 Jul 2024 06:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QBuVxZ+CIJsoZMfw6oza9mwGhGFZwvp47x+oLEaEdKc=; b=wMHXBBLMCkdtVzZqgThmzVm1Sn mkFC9uYpQfdxWAtiQ9Xpt8Sk9pXSMImc6ZHkUThNOH36Z/X2T6La5FFlyuoC4cKM0Ny6wIKwrp9ye y/C8VQRyrj+LCmRoOCzZWdaP1P8uWmsysuYItbN1f47MPvdn3hkuiLFaRMvlSEu117czS3p69Oyl8 qWj9AsE/mIVPYd/XmeNoDSB07vN56mBObiEGA9+FxiDuqhjG9N6VUxBeURnkzCnicQ3gFKV55bDpo EH6Ha9MGdUVZmuOhVLxFgVV5xb0hkDjVyB/G+/ElsA4+gMSmLojbFEYN/58Aflri0TLlBgMJNziu6 P44RL3NQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRn07-0000000Cr3s-0ivu; Thu, 11 Jul 2024 06:09:55 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRmzo-0000000Cr1g-3DjL for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 06:09:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1720678176; x=1752214176; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QBuVxZ+CIJsoZMfw6oza9mwGhGFZwvp47x+oLEaEdKc=; b=DtqX4Bs+KSdEYIy+zwS7MbW/tDGK2lFlVvlVfm0VOnBlHCIMunR9tbz6 I62E6mahbkLF5iXlyGvaBxDk39lLiYN0IS+oKg2quZrQCmFKkGt9fo3VM sBOiW5cpUAvvC9Gw1QBAYS3Uyj18TMed2/qXjUgYNFz1PE4PyjEyB2zY2 H+LpHHs3sypZQvdGbHJq0K12AwNHob4KP6v87sCXI8Zx7mis+gixxCPI6 PEc7oJwv8IFMQ8BO/XezfRIHpqRdDDWwFlmtEuqbqtuqJfGcM1PsMdKyG g7xY4i4jhRO0UlJyMYvvVn32eECi91+zgszOuKR266ZryklIWO+8LlBNW A==; X-CSE-ConnectionGUID: bmQ2cirAQcyRfo7zcOnwsQ== X-CSE-MsgGUID: 57mzsil6TD67+thyncuGNA== X-IronPort-AV: E=Sophos;i="6.09,199,1716242400"; d="scan'208";a="37851191" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 11 Jul 2024 08:09:34 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DC37C16337A; Thu, 11 Jul 2024 08:09:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1720678170; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=QBuVxZ+CIJsoZMfw6oza9mwGhGFZwvp47x+oLEaEdKc=; b=c8WToPMmOGAkAnSNMB6k7awwrlBlkzONkd5ic6VhVslNJNmDekAUYTuPICzYD6csqMii1A wKRqMeZQJMdfPccs2RN5xcvTQLQTffM5EO3iHLe/QZ5Xwca32hUNoGWExcS+akyrkgpLjm iY09iuodtYgLKgxxcEccSnML068PDz2pgEocBIjB4MBU3JVT0jn2TwKGiOWUSRK/KwphBo Gg3ws1VQGPC/BzKtTt4xet1ihUI5F4njbir04/ZdzSPjPbAsiIRVO6q+Mrb0jk5KZMe9OO syZ7DJ7aO1ZJn5vIFHYuOgqUMMJuhW1EtAGEvRx786xCXsaGtKmWLYakGh8npA== From: Alexander Stein To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org Cc: Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, Shenwei Wang , Shenwei Wang Subject: Re: [PATCH] arm64: dts: imx93: update default value for snps,clk-csr Date: Thu, 11 Jul 2024 08:09:33 +0200 Message-ID: <2280257.iZASKD2KPV@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240710200833.153521-1-shenwei.wang@nxp.com> References: <20240710200833.153521-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240710_230937_323421_07597882 X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 10. Juli 2024, 22:08:33 CEST schrieb Shenwei Wang: > For the i.MX93 SoC, the clock rate for the IP of STMMAC EQOS is 315 MHz. Are you talking about enet_qos (IMX93_CLK_ENET_QOS_GATE)? Downstream 6.1 kernel shows: sys_pll_pfd2 1 1 0 625000000 = 0 0 50000 Y wakeup_axi_root 4 4 0 312500000 = 0 0 50000 Y enet_qos 5 5 0 312500000 = 0 0 50000 Y Also RM gives a maximum of 312.5 MHz. > According to the following mapping table from the i.MX93 reference manual, > this clock rate corresponds to a CSR value of 6. >=20 > 0100: CSR clock =3D 150-250 MHz; MDC clock =3D CSR clock/102 > 0101: CSR clock =3D 250-300 MHz; MDC clock =3D CSR clock/124 > 0110: CSR clock =3D 300-500 MHz; MDC clock =3D CSR clock/204 > 0111: CSR clock =3D 500-800 MHz; MDC clock =3D CSR clock/324 As the old value is 0 you should at least add that entry as well. But AFAICS enet_qos is passed as clock 'mem' to this device. So instead of hard-coding this into DT, this divider should be calculated f= rom actual enet_qos clock. Best regards, Alexander > Signed-off-by: Shenwei Wang > --- > arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/d= ts/freescale/imx93.dtsi > index 4a3f42355cb8..a0993022c102 100644 > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > @@ -1105,7 +1105,7 @@ eqos: ethernet@428a0000 { > <&clk IMX93_CLK_SYS_PLL_PFD0_DIV2>; > assigned-clock-rates =3D <100000000>, <250000000>; > intf_mode =3D <&wakeupmix_gpr 0x28>; > - snps,clk-csr =3D <0>; > + snps,clk-csr =3D <6>; > nvmem-cells =3D <ð_mac2>; > nvmem-cell-names =3D "mac-address"; > status =3D "disabled"; >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/