From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBF7EC28B30 for ; Sun, 23 Mar 2025 16:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W8RJ8Z/RHpnWc3LGsmd97JoZyFLCP+Pu3qjQfO7gn9I=; b=kJXUZaTeaLXwg3nXIWWJTkJdTc Z8JtSb+3MrCFJV/apXXLZ6hYaN9sU5XTTJbmCHy206pnkEB5e0TFkvkY3OoVKMDHytseoRNdc0idE McoKzZkA6ol3WZc0/sHNcPcT2apiHP6MXnLjs1b1JFqUVPgIhfxXeNM7omI9pBSSuG0/qsvPtxa5w +LlnPqhONDZ0cwHhkHnsAF9fpr4JlE+idA6ra76QaTe1FMV3CjYwK8UvTjDXf14nlEGJdglrZBZFl VsdiW4icKics1TTGcUMOO+RCRBJTcWocoO+DdPAjZuZIpL8cTkeDCSAWVivl2ksD0kzu9LKgWc1j1 cj+XqshQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1twO47-00000001Smf-0vrU; Sun, 23 Mar 2025 16:20:47 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1twO2Q-00000001SeS-193u for linux-arm-kernel@lists.infradead.org; Sun, 23 Mar 2025 16:19:03 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-224100e9a5cso65811275ad.2 for ; Sun, 23 Mar 2025 09:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742746741; x=1743351541; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=W8RJ8Z/RHpnWc3LGsmd97JoZyFLCP+Pu3qjQfO7gn9I=; b=gW5EN4SszLynbGZ9DEafoS0KeIyAx/RdObIIT7490sbPjfNg3vPQke7AJaCQpjSQ6y FYuzivHYzr1YqJBVTmzw6cB493vx2wknF8g9ISzgX8RqJ0KC+92cYen4JjQcrfv8Gcg3 YoxusructM37gIi2klsBXpZwc+sez24XmnkTS53c8wXz/OOlLbQqaCTynQFxyu8dqwI7 9AmV/+JiLWbUiOFOUFnUz/SjS61fzWUlSETrHbGxEkM9/DqpmhEshnTegG4AQHt9Yxty FySkMadGqnTkhc1Qo8jtGjUgt12BNSyBQPDpok3Nyj9Uc5o48NFwtosRfl29nJt94E4d QnFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742746741; x=1743351541; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W8RJ8Z/RHpnWc3LGsmd97JoZyFLCP+Pu3qjQfO7gn9I=; b=LrBzXPSIGdoeJoYE0NOfM1Pz9LfIIp09LJOdqGl9P9rYa2/zWH6yAmiWRZy7Iz9fKs Fzrn0Ggtjuo6X/2Ja5XpSNz3SAUA+vL9sVrwmflDyo7CWJH3Knz1MXF9jaaciUx+WAKn k/Jn0WLBsNQ/lGt9dh49WWuQZJ+Ylztta5vCfotzrfZCUetCgYm/pSAZqW5FDKinXFoY dzj1e7fWHmTBaUAeH6Dh1ml2LHHnhJqnR/XVaPUv9RMejvSVNUz8xyOPeEhhyyJxihI0 tWwDA3iBfJr00UqmPx4UCXSl8VspdiZPCNiGCf92eU/IQ/vXChlKoSIWh8j3TABvwDMS WUCQ== X-Forwarded-Encrypted: i=1; AJvYcCXgqUaCtmwwR1tZ7rPSW3jELKYwSFn6k2WV1aPeZOljYPePIwXWirfFUSXISjkFFBtxXqanJG4axQ3AK25t5KT/@lists.infradead.org X-Gm-Message-State: AOJu0YxtmY5Ie7Xn1T/H8uR7G9CwHA7dYXciSD+OpK0ETx1KinqMBq1R kQlJkV1bPZGPIc2PrIMoA7b0nHN0+DtHW7zDXPhstmBR7eDTpfZZ X-Gm-Gg: ASbGncvvcA3Hh4Os/lUnnraK09Br9gYZZEPgeuFRWX6Bw0B7YsnpRowFewn172Mbf8o KzLmKFcRDHxO2C5dEEE7ZD3dNYbj1K8dCiacjXqh80fp6D3AfvBvosj672p42fL0xyCfShb55DH DKSkUyVovPiH15fCKC2X0Xh3ZuBYjJuTgnqcvU4jK8JwCoqrMqPcOc/O7bbD2TwCX7o0MkIiVWs 1RKA+/zn8PFlUVKd0cnPHg7VuSIHu7Y6eqX1KQ+CrgZT4QbT3liZEprbe4DI328NeTmvwvfbRnx FKhZSRpYQQp6KJP64hi7haBoAxSceeUZnkmpp6RQpZfg1KYVMaLhx0d16b1xM/BIRSADUI8lZ/D X0wiui4ki4/QtHgRbD5ReZB21ab0i X-Google-Smtp-Source: AGHT+IHo250qwi/lpasJeLUVqvJ1a8Gc4OglOyLVqF0R9kKJhzrb9+w7mS4jN+yzknNmRSCbqAhcAw== X-Received: by 2002:a17:903:46c5:b0:224:191d:8a87 with SMTP id d9443c01a7336-22780d88c6cmr175299435ad.26.1742746740495; Sun, 23 Mar 2025 09:19:00 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-227811da38asm53584125ad.186.2025.03.23.09.18.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Mar 2025 09:18:59 -0700 (PDT) Message-ID: <22812c03-1b64-4e1c-b260-cddc14ea3e8f@roeck-us.net> Date: Sun, 23 Mar 2025 09:18:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/12] lib/crc_kunit.c: add KUnit test suite for CRC library functions To: Ard Biesheuvel Cc: Eric Biggers , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, Zhihang Shao , Vinicius Peixoto , "Martin K. Petersen" References: <20241202012056.209768-1-ebiggers@kernel.org> <20241202012056.209768-9-ebiggers@kernel.org> <389b899f-893c-4855-9e30-d8920a5d6f91@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250323_091902_338852_B2039BFA X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/23/25 08:35, Ard Biesheuvel wrote: [ ... ] >> kernel_neon_end() calls local_bh_enable() which apparently conflicts with >> the local_irq_disable() in above code. >> > > This seems to be an oversight on my part. Can you try the below please? > > diff --git a/arch/arm/include/asm/simd.h b/arch/arm/include/asm/simd.h > index 82191dbd7e78..56ddbd3c4997 100644 > --- a/arch/arm/include/asm/simd.h > +++ b/arch/arm/include/asm/simd.h > @@ -4,5 +4,6 @@ > > static __must_check inline bool may_use_simd(void) > { > - return IS_ENABLED(CONFIG_KERNEL_MODE_NEON) && !in_hardirq(); > + return IS_ENABLED(CONFIG_KERNEL_MODE_NEON) && > + !in_hardirq() && !irqs_disabled(); > } > Yes, that fixes the problem. Thanks, Guenter