From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 09 Dec 2014 13:29:29 +0100 Subject: [PATCH] arm64: psci: Fix build breakage without PM_SLEEP In-Reply-To: <1418125716-18528-1-git-send-email-k.kozlowski@samsung.com> References: <1418125716-18528-1-git-send-email-k.kozlowski@samsung.com> Message-ID: <2290734.BRljGaICu4@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 09 December 2014 12:48:36 Krzysztof Kozlowski wrote: > Fix build failure of defconfig when PM_SLEEP is disabled (e.g. by > disabling SUSPEND) and CPU_IDLE enabled: > > arch/arm64/kernel/psci.c:543:2: error: unknown field ?cpu_suspend? specified in initializer > .cpu_suspend = cpu_psci_cpu_suspend, > ^ > arch/arm64/kernel/psci.c:543:2: warning: initialization from incompatible pointer type [enabled by default] > arch/arm64/kernel/psci.c:543:2: warning: (near initialization for ?cpu_psci_ops.cpu_prepare?) [enabled by default] > make[1]: *** [arch/arm64/kernel/psci.o] Error 1 > > The cpu_operations.cpu_suspend field exists only if ARM64_CPU_SUSPEND is > defined, not CPU_IDLE. > > Signed-off-by: Krzysztof Kozlowski > No objection to fixing this obvious build bug, but why do we even have an ARM64_CPU_SUSPEND option? On ARM32 we only have the respective option because we have a random collection of platform specific drivers that use the symbols, but that's not the case on ARM64. Arnd