From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CCFFC47DDF for ; Thu, 25 Jan 2024 07:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0pJjO0YYA/duzi43whA+LTQlcc5MuClCTGw8TjkGUSg=; b=jnW6n8yVroSQZN jtj/kwUE5m0QTalUFpqMX4kEuF/5+7x2ylEqzKkoGv4HA4oihblx02ptb6fqdE9Zlh+3EfHM7Q6Cl fDIXranVzEqbsKxrKJrZJPPdfyBtRGWiBov1uLa2BogK0cBnWOcZ6aPsDD6cc00NA9/cleQ+Cg3h2 VyOQKFNyJL7U5FFxXH/0PU4CgsgYZCM7BjF0BnQEM3rhMkml7mYtHaREoePG02bP7WJ1a7gTcYdrg r7y2kk5HtKMbRUf8Of8Ypk0MvKyGGWA1C5TeSQ1k4dRDA6q4OexQCzRocsHsFIfvtql3gEXRsRpp0 1c76/XcXC0rp8GhyBHNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rStk3-006vxC-2A; Thu, 25 Jan 2024 07:01:43 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSsaE-006Ysk-1i for linux-arm-kernel@lists.infradead.org; Thu, 25 Jan 2024 05:47:29 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 40P5lHdZ002805; Wed, 24 Jan 2024 23:47:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1706161637; bh=XYm18jVRWbK0xPk1IDYRqvQ4AolTdoU+U2rtIDmzOAs=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=tkSBl/n72J8iF9D82TzBERbnqxFsMd9EkjXnYnThKyglQZkiqfaEookLAEtX7Uxw/ sbe5G+LV6wpsyf1EIrgbSXYFDDaB3d9yTW2c+VhG/aFZqh1+qSPYxgJZrq3ous2RE7 kcvmcncp7DytXGP5SGB4PLqC+B+2ZIn8X2Kla7iQ= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 40P5lH57043952 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 24 Jan 2024 23:47:17 -0600 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 24 Jan 2024 23:47:16 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 24 Jan 2024 23:47:16 -0600 Received: from [10.24.69.142] ([10.24.69.142]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 40P5lCbK094683; Wed, 24 Jan 2024 23:47:13 -0600 Message-ID: <2291204f-97d5-4887-b68f-8789fe85f838@ti.com> Date: Thu, 25 Jan 2024 11:17:12 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes Content-Language: en-US To: Nishanth Menon , Jayesh Choudhary CC: , , , , , , , , , References: <20240121134017.374992-1-vaishnav.a@ti.com> <0fcec921-0220-4251-afa4-44db5e80d2ef@ti.com> <20240124172151.ngxaq6k5tnvsx4jr@proud> From: Vaishnav Achath In-Reply-To: <20240124172151.ngxaq6k5tnvsx4jr@proud> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240124_214726_681332_64347044 X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth, On 24/01/24 22:51, Nishanth Menon wrote: > On 11:26-20240124, Jayesh Choudhary wrote: >> Hello Vaishnav, >> >> On 21/01/24 19:10, Vaishnav Achath wrote: >>> K3 Remoteproc R5 driver requires reserved memory carveouts and >>> mailbox configuration to instantiate the cores successfully. >>> Since this is a board level dependency, keep the R5 subsytem >>> disabled at SoC dtsi, otherwise it results in probe errors like >>> below during AM62P SK boot: >>> >>> r5fss@79000000: reserved memory init failed, ret = -22 >>> r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22 >>> r5fss@78000000: reserved memory init failed, ret = -22 >>> r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22 >>> >>> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs") >>> >>> Signed-off-by: Vaishnav Achath >> >> Reviewed-by: Jayesh Choudhary >> >>> --- >>> arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++ >>> arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 + >>> 2 files changed, 3 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi >>> index c4b0b91d70cf..14eb9ba836d3 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi >>> @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 { >>> ranges = <0x79000000 0x00 0x79000000 0x8000>, >>> <0x79020000 0x00 0x79020000 0x8000>; >>> power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; >>> + status = "disabled"; >>> + >>> mcu_r5fss0_core0: r5f@79000000 { >>> compatible = "ti,am62-r5f"; >>> reg = <0x79000000 0x00008000>, >>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi >>> index 19f42b39394e..10a7059b2d9b 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi >>> @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 { >>> ranges = <0x78000000 0x00 0x78000000 0x8000>, >>> <0x78100000 0x00 0x78100000 0x8000>; >>> power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; >>> + status = "disabled"; > > Is there a reason for difference in white space addition? > For mcu_r5fss0_core0 child node there was no blank line as per the recommended coding style : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n124 So I added a newline there and wkup_r5fss0 already had it correct, since the change was trivial it was not mentioned in commit message. Thanks and Regards, Vaishnav >>> wkup_r5fss0_core0: r5f@78000000 { >>> compatible = "ti,am62-r5f"; >> >> Thanks. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel