From: Heiko Stuebner <heiko@sntech.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 22/31] thermal: rockchip: Convert to platform remove callback returning void
Date: Mon, 02 Oct 2023 00:53:53 +0200 [thread overview]
Message-ID: <2298407.ElGaqSPkdT@phil> (raw)
In-Reply-To: <20230927193736.2236447-23-u.kleine-koenig@pengutronix.de>
Am Mittwoch, 27. September 2023, 21:37:27 CEST schrieb Uwe Kleine-König:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-01 22:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230927193736.2236447-1-u.kleine-koenig@pengutronix.de>
2023-09-27 19:37 ` [PATCH 03/31] thermal: bcm2835: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 08/31] thermal: imx8mm: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 09/31] thermal: imx: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 18/31] thermal: lvts: " Uwe Kleine-König
2023-09-28 11:13 ` AngeloGioacchino Del Regno
2023-09-27 19:37 ` [PATCH 22/31] thermal: rockchip: " Uwe Kleine-König
2023-10-01 22:53 ` Heiko Stuebner [this message]
2023-09-27 19:37 ` [PATCH 24/31] thermal: exynos_tmu: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 27/31] thermal: stm: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 31/31] thermal: uniphier: " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2298407.ElGaqSPkdT@phil \
--to=heiko@sntech.de \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).