From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A74C8E8FDBF for ; Wed, 4 Oct 2023 00:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GS0lXNHp5BrwtOoFYZQnSOgVIiQktAmwlvCEH/JQ8e0=; b=WNZ4ZolALc0SRcm6GBZ7mJLFwv YSkFhFP1fy30D+LTCZmK2MRSNjXLcOeGLY2ncJY/csb5qgBiq40WOcC5KMEIGMuYLYerkxGs2rDxf oETp8kh25rW9bCNMa+C7cX8vNrXZRm/TahExozv+PzgMNJyY4wh3BhoZt8+aI4UBD5fvXBxjy6fVr NHEsFxBZ3ml0qELGF8IBd1isxHBRRJdwgQ9iFG34tsk2n7AlF7/kuc5He0xPc5UcddNKZQYCRzZRJ 8T2QZWHrFPhb3hWZxj+MwsF8QgIwNyTKrvoMypSmQBu7j4oxFdSR8lDWsBfa/atD30KjIBX3itVp5 uXCw9grA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnpsH-00FfiH-3B; Wed, 04 Oct 2023 00:36:25 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnpsD-00Ffhk-01 for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 00:36:24 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-533d6a8d6b6so2816226a12.2 for ; Tue, 03 Oct 2023 17:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696379776; x=1696984576; darn=lists.infradead.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=9XJRvSjw9vE3ViTEA7+Fc+ROzh6Ut2Xh1WXhdCCyUoM=; b=ZegBDin1pUON9xbhcBiSCtvJN8ZXgyX2Pm8zx+nCpqgUNWFsmwMpSbRI6q737u5rwf hri1wo0arMMdpQZFppYt4CwL8//X2uAt3RD/sfDjRDpcYzV6aSRXQnAsoQX6rN7Jvu0D ueE61uwKlHscnppv283iIDVA7i/VOkGiJ44QZRxIWF38sHKmqjgBIqtIdL9arGy7MVh4 GhnKjhUDd9EI01s9jZ+y3YqO7nXhlSXrhLJf6GHjghXDbgbpuq1zRZMOGE1HgyXXh+WF VQxVLtat3sT9aMPPynJ7MQbLh2BEQIXYyvWLhEzG+0IL0u5aV4rwS3oonjNhrNknR9XM BApw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696379776; x=1696984576; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9XJRvSjw9vE3ViTEA7+Fc+ROzh6Ut2Xh1WXhdCCyUoM=; b=P8sRbk5h8JA9NdcRrppVL0ZwOJ31RtJTDevI8qSZfDwvQjQFP+2VNbhGBZDki5zBr5 xf4d7C3J5veqvQDFOIioKhu8z6/GNnz30/Ph8pAa2GM6C1y6bPp7tIEvudrlKyg4arqc foliw2y3BTyyhsiFlI0PKVTPzrxa8A6n3GMjK76XuSQn/oub6Mc6IYYkwf1bDhcDL06n 7KPy2/IWqTC9zYJ5yMFVC7HlKJV2AYCqa/wR3cGq6DeGh9LRR8S9D835ETMMLfY8+aRc n26sn66w3OC/OO5r3t8WAvCm/9vhkIpLNPFqqZVo/xXpF5fAGeySMFr3QmGubsdE0Uk/ 0C8Q== X-Gm-Message-State: AOJu0Yzzjro+SIs77TOJeTy3bj7jkXqQuuaKVRSjOCINEdN7gHg6GVGx Z8g68aLJw9LZkRwi/473HHI= X-Google-Smtp-Source: AGHT+IHmdDNcvb1k/uz4FIW9trWjcu9894h81mL2637ya7mGbZk+fy69n/xEa9hiU+L3T6dxpq2o7A== X-Received: by 2002:aa7:c409:0:b0:530:a925:77a6 with SMTP id j9-20020aa7c409000000b00530a92577a6mr653446edq.8.1696379776395; Tue, 03 Oct 2023 17:36:16 -0700 (PDT) Received: from dell.localnet (77-255-201-154.dynamic.inetia.pl. [77.255.201.154]) by smtp.gmail.com with ESMTPSA id c4-20020a056402120400b00537963f692esm1575392edw.0.2023.10.03.17.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 17:36:15 -0700 (PDT) From: Janusz Krzysztofik To: Linus Walleij , Tony Lindgren Cc: Aaro Koskinen , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Bartosz Golaszewski , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH] OMAP/gpio: drop MPUIO static base Date: Wed, 04 Oct 2023 02:36:13 +0200 Message-ID: <2298936.ElGaqSPkdT@dell> In-Reply-To: <20230926070953.GV5285@atomide.com> References: <20230912-omap-mpuio-base-v1-1-290d9bd24b23@linaro.org> <20230926070953.GV5285@atomide.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_173622_387375_3D5FD36D X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0944893081491180339==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0944893081491180339== Content-Type: multipart/signed; boundary="nextPart4836419.GXAFRqVoOG"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPart4836419.GXAFRqVoOG Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Janusz Krzysztofik Subject: Re: [PATCH] OMAP/gpio: drop MPUIO static base Date: Wed, 04 Oct 2023 02:36:13 +0200 Message-ID: <2298936.ElGaqSPkdT@dell> In-Reply-To: <20230926070953.GV5285@atomide.com> MIME-Version: 1.0 Hi Linus, Tony, Dnia wtorek, 26 wrze=C5=9Bnia 2023 09:09:53 CEST Tony Lindgren pisze: > * Linus Walleij [230912 08:45]: > > The OMAP GPIO driver hardcodes the MPIO chip base, but there > > is no point: we have already moved all consumers over to using > > descriptor look-ups. > >=20 > > Drop the MPUIO GPIO base and use dynamic assignment. On my OMAP1510 based ams_delta with the patch applied on top of v6.6-rc4: root@amsdelta:~# cat /sys/kernel/debug/gpio=20 gpiochip0: GPIOs 512-527, parent: platform/omap_gpio.0, mpuio: gpio-512 ( |data ) in lo=20 gpio-513 ( |data ) in lo=20 gpio-514 ( |data ) in lo=20 gpio-515 ( |data ) in lo=20 gpio-516 ( |data ) in lo=20 gpio-517 ( |data ) in lo=20 gpio-518 ( |data ) in lo=20 gpio-519 ( |data ) in lo=20 gpiochip1: GPIOs 528-543, parent: platform/omap_gpio.1, gpio-0-15: gpio-528 ( |keybrd_data ) in lo=20 gpio-529 ( |keybrd_clk ) in lo IRQ=20 gpio-530 ( |modem_irq ) in lo=20 gpio-532 ( |hook_switch ) in hi IRQ=20 gpio-540 ( |rdy ) in hi=20 gpiochip2: GPIOs 544-551, parent: platform/basic-mmio-gpio.0, latch1: gpio-544 ( |camera ) out lo=20 =2E.. GPIO based hardware seems to be working correctly. I'm only not sure if=20 we should maybe change the name to something else than gpio-0-15 (mpuio=20 looks OK). > >=20 > > Root out the unused instances of the OMAP_MPUIO() macro and > > delete the unused OMAP_GPIO_IS_MPUIO() macro. > >=20 > > Signed-off-by: Linus Walleij > > --- > > Maybe Bartosz can merge this into the GPIO tree with Tony's > > et al blessing? >=20 > Best to wait for Tested-by from Aaro on this one. >=20 > As far as I'm concerned, good to see this: >=20 > Reviewed-by: Tony Lindgren Tested-by: Janusz Krzysztofik --nextPart4836419.GXAFRqVoOG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEnyr6IsGnTYAeAkHJ2WqSnltsjBoFAmUcs30ACgkQ2WqSnlts jBrU9Qf9F6VXtPldEIdUb7pt3KTUg58jkYvLTvNhaMxSQqqjU1Q/xkMtpw+LPEDu DYdApDvzsunX458kK6XW3biK43fNMTAda6dYCRGIY993q4y9UIbpwyEqezIoJgAs cs3lx8wrFDGKAXhISeDfYry9PjDv5YOwRqI6efF0NBSb7hhxkHn46mKdblBl0CIR HpNzQahyC6fE4bBGdZ+TgArmLC5C4vxBc+VNWXQMAmuNk24J7Vpw9mgViflMaclE 8E6prcJQ8R8bilvQzDTB5jLYQhb+K4jVdiwqKdzHHfCVA3ftvNm8sWpP8VmN6Wr3 9O8MIfAyDbmk9ML33M/3LIK2Mamibg== =wcDK -----END PGP SIGNATURE----- --nextPart4836419.GXAFRqVoOG-- --===============0944893081491180339== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0944893081491180339==--