From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E6A5C3A59E for ; Wed, 21 Aug 2019 15:34:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 348E5206BB for ; Wed, 21 Aug 2019 15:34:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RQC+/z3i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 348E5206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hIp7jJPeWmMXRsHoX/t3fdh/RacJLWDQEteB+9sJJLs=; b=RQC+/z3i1E5LACx8/PuAXrKgQ rJwQBGhFMCrHLs1YqwNxtvf6Wywvp/DKbtE5mQHXWVxNYb4RP7VvJXxCBIIZX+OsMekVx2sD01prj hbGh9rZntJndJcg7hYbMUu9/MBli1zZHOEHrxfCiFcPG822/+P1cZ50MVDxKbSDEiuM6eTCnkUApC cKoolEy/hzXkHZgDhgLaLhsxfIPJlfHgty3xjBEohTU4ZtYURWq73onL9GdS6ayBngMgP9KTdDLPM zj3rDxK/Ta6+ElF5SLI53H2ObIXvY2HaqlXe9oplXBt6zIZYN6+yYdohgtWBBKtGneEpgGfMElgLc HhLUpcuEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0SdB-0005ka-Ol; Wed, 21 Aug 2019 15:34:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0Sd9-0005jj-Mb; Wed, 21 Aug 2019 15:34:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB655337; Wed, 21 Aug 2019 08:34:31 -0700 (PDT) Received: from [10.1.197.57] (e110467-lin.cambridge.arm.com [10.1.197.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E11F53F718; Wed, 21 Aug 2019 08:34:28 -0700 (PDT) Subject: Re: [PATCH v10 09/23] iommu/io-pgtable-arm-v7s: Extend to support PA[33:32] for MediaTek To: Will Deacon , Yong Wu References: <1566395606-7975-1-git-send-email-yong.wu@mediatek.com> <1566395606-7975-10-git-send-email-yong.wu@mediatek.com> <20190821152448.qmoqjh5zznfpdi6n@willie-the-truck> From: Robin Murphy Message-ID: <22a79977-5074-7af1-97b8-8a3e549b23c1@arm.com> Date: Wed, 21 Aug 2019 16:34:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190821152448.qmoqjh5zznfpdi6n@willie-the-truck> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190821_083435_783429_3385A0E0 X-CRM114-Status: GOOD ( 20.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, Nicolas Boichat , cui.zhang@mediatek.com, srv_heupstream@mediatek.com, chao.hao@mediatek.com, Joerg Roedel , linux-kernel@vger.kernel.org, Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Matthias Kaehlcke , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/08/2019 16:24, Will Deacon wrote: > On Wed, Aug 21, 2019 at 09:53:12PM +0800, Yong Wu wrote: >> MediaTek extend the arm v7s descriptor to support up to 34 bits PA where >> the bit32 and bit33 are encoded in the bit9 and bit4 of the PTE >> respectively. Meanwhile the iova still is 32bits. >> >> Regarding whether the pagetable address could be over 4GB, the mt8183 >> support it while the previous mt8173 don't, thus keep it as is. >> >> Signed-off-by: Yong Wu >> --- >> drivers/iommu/io-pgtable-arm-v7s.c | 32 +++++++++++++++++++++++++------- >> include/linux/io-pgtable.h | 7 +++---- >> 2 files changed, 28 insertions(+), 11 deletions(-) > > [...] > >> @@ -731,7 +747,9 @@ static struct io_pgtable *arm_v7s_alloc_pgtable(struct io_pgtable_cfg *cfg, >> { >> struct arm_v7s_io_pgtable *data; >> >> - if (cfg->ias > ARM_V7S_ADDR_BITS || cfg->oas > ARM_V7S_ADDR_BITS) >> + if (cfg->ias > ARM_V7S_ADDR_BITS || >> + (cfg->oas > ARM_V7S_ADDR_BITS && >> + !(cfg->quirks & IO_PGTABLE_QUIRK_ARM_MTK_EXT))) > > Please can you instead change arm_v7s_alloc_pgtable() so that it allows an > ias of up to 34 when the IO_PGTABLE_QUIRK_ARM_MTK_EXT is set? You mean oas, right? I believe the hardware *does* actually support a 32-bit ias as well, but we shouldn't pretend to support that while __arm_v7s_alloc_table() still only knows how to allocate normal-sized tables. Robin. > > With that change: > > Acked-by: Will Deacon > > Will > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel