linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages
Date: Sun, 23 Oct 2016 23:48:32 -0400	[thread overview]
Message-ID: <22ad2e6b-e4da-1eba-0d2c-b7b86b2a4dbc@codeaurora.org> (raw)
In-Reply-To: <CAJZ5v0jm-n8hbS_GFUY4EVKHiRaNPrkNcWDY+6c3SRxWhy4VAg@mail.gmail.com>

On 10/20/2016 5:39 PM, Rafael J. Wysocki wrote:
>> @@ -871,7 +871,7 @@ static int __init acpi_irq_penalty_update(char *str, int used)
>> >  void acpi_penalize_isa_irq(int irq, int active)
>> >  {
>> >         if ((irq >= 0) && (irq < ARRAY_SIZE(acpi_isa_irq_penalty)))
>> > -               acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) +
>> > +               acpi_isa_irq_penalty[irq] = acpi_isa_irq_penalty[irq] +
> This looks slightly odd.  What about
> 
> +               acpi_isa_irq_penalty[irq] +=
> 
>> >                   (active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING);
>> >  }

Makes sense.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2016-10-24  3:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19 22:21 [PATCH V4 0/3] ACPI, PCI, IRQ: revert penalty calculation for ISA and SCI interrupts Sinan Kaya
2016-10-19 22:21 ` [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages Sinan Kaya
2016-10-20 21:39   ` Rafael J. Wysocki
2016-10-24  3:48     ` Sinan Kaya [this message]
2016-10-21  1:39   ` Bjorn Helgaas
2016-10-21 14:07     ` Bjorn Helgaas
2016-10-24  3:22     ` Sinan Kaya
2016-10-23  3:48   ` [V4, " Jonathan Liu
2016-10-24  4:17     ` Sinan Kaya
2016-10-24  4:21       ` Jonathan Liu
2016-10-19 22:21 ` [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function" Sinan Kaya
2016-10-21  1:58   ` Bjorn Helgaas
2016-10-21 14:45     ` Bjorn Helgaas
2016-10-21 16:13       ` Sinan Kaya
2016-10-22 14:57         ` Bjorn Helgaas
2016-10-24  3:48         ` Sinan Kaya
2016-10-22 23:28     ` Bjorn Helgaas
2016-10-24  3:48     ` Sinan Kaya
2016-10-23  3:49   ` [V4,2/3] " Jonathan Liu
2016-10-19 22:21 ` [PATCH V4 3/3] Revert "ACPI, PCI, IRQ: separate ISA penalty calculation" Sinan Kaya
2016-10-21  2:31   ` Bjorn Helgaas
2016-10-21  2:58     ` Sinan Kaya
2016-10-22 23:59       ` Bjorn Helgaas
2016-10-24  4:16         ` Sinan Kaya
2016-10-23  3:49   ` [V4,3/3] Revert "ACPI,PCI,IRQ: " Jonathan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22ad2e6b-e4da-1eba-0d2c-b7b86b2a4dbc@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).