From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 564C1C76191 for ; Sun, 21 Jul 2019 23:01:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 286442083B for ; Sun, 21 Jul 2019 23:01:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a2rSLqVO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 286442083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TT80eMcGC7olCaP/6Ey/EdAJKMSgxWV5f4H2ymlctKQ=; b=a2rSLqVO7EgSK+ yBpSQCzJ2Gn28YjB+4v7qBBNt2S73yMzf8mIF7blNw+PK1PE7EWsiNt1LUwasn1fOnn9jw1w5t+oB RGtYtFQobQbUtyCGttwIOmMCy4jcvzSKoOuhgSK2lFI9dou3MvMO9I9kpDved5PpuYxLYzpar8eO+ guCcng3dEO3h5xxl3u9Jg+RoJvPSs4PtxVORz4PY37Le93BOEn86H77xAeFnSTGlPd7bDD+TPb2sO fp5ipbh+f5ttOS0a+hDa7wETMZf0SkHc+RvA2469GHGnVc81hWkVYHyf1MCTAvsTIfHLKYWshcBQL WCHYvSBAzniFOxaAf6UA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpKpE-0005zV-Jj; Sun, 21 Jul 2019 23:01:04 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpKpA-0005yw-P6 for linux-arm-kernel@lists.infradead.org; Sun, 21 Jul 2019 23:01:02 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 7E59628A24F Message-ID: <22d7eca4ad8aa2e73933c4f83c92221ce6e0945a.camel@collabora.com> Subject: Re: [PATCH] Enable backlight when trigger is activated From: Ezequiel Garcia To: Pavel Machek , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org, jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Date: Sun, 21 Jul 2019 20:00:44 -0300 In-Reply-To: <20190718190849.GA11409@amd> References: <20190718190849.GA11409@amd> Organization: Collabora User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190721_160100_948831_2FDB9A50 X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pavel, The commit log is lacking the proper "leds: triggers: ". Also... On Thu, 2019-07-18 at 21:08 +0200, Pavel Machek wrote: > Configuring backlight trigger from dts results in backlight off during > boot. Machine looks dead upon boot, which is not good. > > Fix that by enabling LED on trigger activation. > > Signed-off-by: Pavel Machek > > diff --git a/drivers/leds/trigger/ledtrig-backlight.c b/drivers/leds/trigger/ledtrig-backlight.c > index 487577d..6e6bc78 100644 > --- a/drivers/leds/trigger/ledtrig-backlight.c > +++ b/drivers/leds/trigger/ledtrig-backlight.c > @@ -114,6 +114,8 @@ static int bl_trig_activate(struct led_classdev *led) > n->old_status = UNBLANK; > n->notifier.notifier_call = fb_notifier_callback; > > + led_set_brightness(led, LED_ON); > + This looks fishy. Maybe you should use a default-state = "keep" instead? (and you'll have to support it in the LED driver). That'll give you proper "don't touch the LED if it was turned on" behavior, which is what you seem to want. Regards, Eze _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel