From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Joy Zou <joy.zou@nxp.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
catalin.marinas@arm.com, will@kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, ulf.hansson@linaro.org,
richardcochran@gmail.com, kernel@pengutronix.de,
festevam@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-pm@vger.kernel.or, ye.li@nxp.com, ping.bai@nxp.com,
aisheng.dong@nxp.com
Subject: Re: [PATCH v6 2/9] dt-bindings: soc: imx-blk-ctrl: add i.MX91 blk-ctrl compatible
Date: Wed, 25 Jun 2025 08:10:04 +0200 [thread overview]
Message-ID: <22d911a2-3bf1-45ee-9037-c6d8cbd686fa@kernel.org> (raw)
In-Reply-To: <aFr3yExb6vObn5W4@lizhi-Precision-Tower-5810>
On 24/06/2025 21:08, Frank Li wrote:
>>>>> + clock-names:
>>>>> + items:
>>>>> + - const: apb
>>>>> + - const: axi
>>>>> + - const: nic
>>>>> + - const: disp
>>>>> + - const: cam
>>>>> + - const: lcdif
>>>>> + - const: isi
>>>>> + - const: csi
>>>>
>>>> No, look at other bindings how they share clock lists.
>>>
>>> Sorry, this method is what I suggested. becuase there are pxp between cam
>>> and lcdif, can't use simple minItems/maxItems to limit list.
>>
>> The point is to put new items, so pxp, at the end.
>
> There are already a list for imx93. If change list order, it will break
> ABI. This was rejected at other binding doc review.
I see, I mixed the SoCs. It is a pity you upstream that way and do not
try to make the list common. Anyway names indeed need to be constrained
per variant, but the rest of the comments stay.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-25 6:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 9:57 [PATCH v6 0/9] Add i.MX91 platform support Joy Zou
2025-06-23 9:57 ` [PATCH v6 1/9] dt-bindings: arm: fsl: add i.MX91 11x11 evk board Joy Zou
2025-06-23 9:57 ` [PATCH v6 2/9] dt-bindings: soc: imx-blk-ctrl: add i.MX91 blk-ctrl compatible Joy Zou
2025-06-23 14:51 ` Frank Li
2025-06-24 7:28 ` Krzysztof Kozlowski
2025-06-24 14:51 ` Frank Li
2025-06-24 15:39 ` Krzysztof Kozlowski
2025-06-24 19:08 ` Frank Li
2025-06-25 6:10 ` Krzysztof Kozlowski [this message]
2025-06-23 9:57 ` [PATCH v6 3/9] arm64: dts: freescale: rename imx93.dtsi to imx91_93_common.dtsi and modify them Joy Zou
2025-06-23 9:57 ` [PATCH v6 4/9] arm64: dts: imx91: add i.MX91 dtsi support Joy Zou
2025-06-23 9:57 ` [PATCH v6 5/9] arm64: dts: freescale: add i.MX91 11x11 EVK basic support Joy Zou
2025-06-23 14:57 ` Frank Li
2025-06-23 18:17 ` Andrew Lunn
2025-06-23 9:57 ` [PATCH v6 6/9] arm64: dts: freescale: move aliases from imx91_93_common.dtsi to board dts Joy Zou
2025-06-23 15:10 ` Frank Li
2025-06-23 9:57 ` [PATCH v6 7/9] arm64: defconfig: enable i.MX91 pinctrl Joy Zou
2025-06-23 9:57 ` [PATCH v6 8/9] pmdomain: imx93-blk-ctrl: mask DSI and PXP PD domain register on i.MX91 Joy Zou
2025-06-23 12:56 ` Fabio Estevam
2025-06-23 9:57 ` [PATCH v6 9/9] net: stmmac: imx: add i.MX91 support Joy Zou
2025-06-24 7:29 ` [PATCH v6 0/9] Add i.MX91 platform support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22d911a2-3bf1-45ee-9037-c6d8cbd686fa@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.or \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ping.bai@nxp.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox