linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm: exynos: clean up dma_addr_t use
Date: Thu, 26 Feb 2015 09:46:39 +0100	[thread overview]
Message-ID: <2303513.m1GhqAXJBa@wuerfel> (raw)
In-Reply-To: <2463296.ej1sNijqo7@wuerfel>

On Wednesday 25 February 2015 16:36:46 Arnd Bergmann wrote:

> @@ -671,6 +671,7 @@ static void fimd_win_commit(struct exynos_drm_crtc *crtc, int zpos)
>  	struct fimd_win_data *win_data;
>  	int win = zpos;
>  	unsigned long val, alpha, size;
> +	dma_addr_t end;
>  	unsigned int last_x;
>  	unsigned int last_y;
>  
> @@ -705,16 +706,16 @@ static void fimd_win_commit(struct exynos_drm_crtc *crtc, int zpos)
>  	/* buffer end address */
>  	size = win_data->fb_width * win_data->ovl_height * (win_data->bpp >> 3);
> -	val = (unsigned long)(win_data->dma_addr + size);
> +	end = win_data->dma_addr + size;
>  	writel(val, ctx->regs + VIDWx_BUF_END(win, 0));
>  
> -	DRM_DEBUG_KMS("start addr = 0x%lx, end addr = 0x%lx, size = 0x%lx\n",
> -			(unsigned long)win_data->dma_addr, val, size);
> +	DRM_DEBUG_KMS("start addr = %pad, end addr = %pad, size = 0x%lx\n",
> +			&win_data->dma_addr, end, size);
>  	DRM_DEBUG_KMS("ovl_width = %d, ovl_height = %d\n",
>  			win_data->ovl_width, win_data->ovl_height);
>  

Unfortunately, I introduced a new bug here, please disregard this version
and use v2 of this patch instead.

	Arnd

      reply	other threads:[~2015-02-26  8:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 15:36 [PATCH] drm: exynos: clean up dma_addr_t use Arnd Bergmann
2015-02-26  8:46 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2303513.m1GhqAXJBa@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).