Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: pankaj.dubey@samsung.com (pankaj.dubey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: dts: exynos: Add USB 3.0 controller node for Exynos7
Date: Tue, 17 Jan 2017 19:39:41 +0530	[thread overview]
Message-ID: <23067cbb-08de-abd9-3530-246c81ba5931@samsung.com> (raw)
In-Reply-To: <3a607d18-acf9-37f5-a6d4-7f8fe538d27f@osg.samsung.com>

Hi Javier,

On Tuesday 17 January 2017 07:07 PM, Javier Martinez Canillas wrote:
> Hello Pankaj,
> 
> On 01/17/2017 07:32 AM, Pankaj Dubey wrote:
>> Add USB 3.0 DRD controller device node, with its clock
>> and phy information to enable the same on Exynos7.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> Signed-off-by: Vivek Gautam <gautamvivek1987@gmail.com>
> 
> The S-o-B order isn't correct. You are the one posting the patch so
> yours should be the last one.
> 
> Also, wasn't this patch originally from Vivek? If you didn't change
> that much, I think that he should be listed as the patch author.
> 

Thanks for review.

Just noticed, I missed to take care of this, as original patch could not
be applied on latest tree and I had to do all these changes manually,
will submit soon with Signed-off-by and author change.

Thanks,
Pankaj Dubey

> I don't have an Exynos7 manual to verify but the patch looks good.
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Best regards,
> 

  reply	other threads:[~2017-01-17 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170117102937epcas5p1f49119a781097709b6bd6d29730c0c0f@epcas5p1.samsung.com>
2017-01-17 10:32 ` [PATCH 0/2] Add USB DRD 3.0 device node for Exynos7 Pankaj Dubey
2017-01-17 10:32   ` [PATCH 1/2] arm64: dts: exynos: Add USB 3.0 controller " Pankaj Dubey
2017-01-17 13:37     ` Javier Martinez Canillas
2017-01-17 14:09       ` pankaj.dubey [this message]
2017-01-17 10:32   ` [PATCH 2/2] arm64: dts: exynos: Add regulators for Vbus and Vbus-Boost Pankaj Dubey
2017-01-17 13:47     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23067cbb-08de-abd9-3530-246c81ba5931@samsung.com \
    --to=pankaj.dubey@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox