linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: abx805 depends on i2c
Date: Sat, 28 Feb 2015 20:48:27 +0100	[thread overview]
Message-ID: <2307717.ct4mYzhCLm@wuerfel> (raw)

The recently added X805 rtc driver uses the i2c subsystem,
but has no Kconfig dependency, so it can result in a build
error when i2c is disabled:

drivers/rtc/rtc-abx805.c: In function 'abx805_read_multiple_regs':
drivers/rtc/rtc-abx805.c:55:2: error: implicit declaration of function 'i2c_transfer' [-Werror=implicit-function-declaration]

This adds the obvious dependency.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 9033ab8ddd29 ("rtc: add rtc-abx805, a driver for the Abracon AB 1805 i2c rtc")

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 61ea2e3b4071..80ae27ffe8ea 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1083,6 +1083,7 @@ config RTC_DRV_AB8500
 
 config RTC_DRV_ABX805
 	tristate "Abracon AB X805 RTC"
+	depends on I2C
 	help
 	  Select this to enable support for the Abracon AB X805 RTC.
 	  AB X805 is the i2c flavour of the AB 18X5 family of ultra-low-power

                 reply	other threads:[~2015-02-28 19:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2307717.ct4mYzhCLm@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).