From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: amd-seattle: Fix dma-ranges property
Date: Mon, 01 Dec 2014 14:33:42 +0100 [thread overview]
Message-ID: <2316008.jChdsJ8v0y@wuerfel> (raw)
In-Reply-To: <1417405600-19232-2-git-send-email-suravee.suthikulpanit@amd.com>
On Sunday 30 November 2014 21:46:39 suravee.suthikulpanit at amd.com wrote:
> From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>
> AMD Seattle should support 40-bit DMA.
>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>
The change looks good, but two things about the patch description:
- You should be a little more verbose, especially after we had discussed
this to some detail on IRC, explain why you use the specific values.
- You should configure git-send-email to know your full email address
including the name. Right now it gets sent from
"suravee.suthikulpanit at amd.com" instead of "Suravee Suthikulpanit
<Suravee.Suthikulpanit@amd.com>", and that causes the extra From
line at the start of the mail, besides looking a bit strange.
Thanks,
Arnd
next prev parent reply other threads:[~2014-12-01 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 3:46 [PATCH 0/2] arm64: amd-seattle: Misceleneous DT fix up suravee.suthikulpanit at amd.com
2014-12-01 3:46 ` [PATCH 1/2] arm64: amd-seattle: Fix dma-ranges property suravee.suthikulpanit at amd.com
2014-12-01 13:33 ` Arnd Bergmann [this message]
2014-12-02 14:12 ` Suthikulpanit, Suravee
2014-12-04 16:17 ` Arnd Bergmann
2014-12-01 3:46 ` [PATCH 2/2] arm64: amd-seattle: Fix PCI bus range due to SMMU limitation suravee.suthikulpanit at amd.com
2014-12-04 16:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2316008.jChdsJ8v0y@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox