Re: [PATCH 42/42] crypto: xilinx/zynqmp-sha - Convert to platform remove callback returning void

Michal Simek
2023-10-20T09:20:35Z

On 10/20/23 09:56, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/crypto/xilinx/zynqmp-sha.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/xilinx/zynqmp-sha.c b/drivers/crypto/xilinx/zynqmp-sha.c
> index 426bf1a72ba6..e6c45ceb4bf7 100644
> --- a/drivers/crypto/xilinx/zynqmp-sha.c
> +++ b/drivers/crypto/xilinx/zynqmp-sha.c
> @@ -238,20 +238,18 @@ static int zynqmp_sha_probe(struct platform_device *pdev)
> return err;
> }
>
> -static int zynqmp_sha_remove(struct platform_device *pdev)
> +static void zynqmp_sha_remove(struct platform_device *pdev)
> {
> sha3_drv_ctx.dev = platform_get_drvdata(pdev);
>
> dma_free_coherent(sha3_drv_ctx.dev, ZYNQMP_DMA_ALLOC_FIXED_SIZE, ubuf, update_dma_addr);
> dma_free_coherent(sha3_drv_ctx.dev, SHA3_384_DIGEST_SIZE, fbuf, final_dma_addr);
> crypto_unregister_shash(&sha3_drv_ctx.sha3_384);
> -
> - return 0;
> }
>
> static struct platform_driver zynqmp_sha_driver = {
> .probe = zynqmp_sha_probe,
> - .remove = zynqmp_sha_remove,
> + .remove_new = zynqmp_sha_remove,
> .driver = {
> .name = "zynqmp-sha3-384",
> },

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal