From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1881EC4345F for ; Wed, 24 Apr 2024 18:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QCT4//OF5ttsmHdQDJK/9bnZRxzZlc3Ueyf28kM4LTM=; b=t4csoxPL6tHAkH xBB2VA/UfqBdMr496R+I5Lcg3NtLKtfutPcDt6ftDx9ulZk+DpIBRPx1l0KtCQ75Eo1dsBWkoUkEJ CLgWvxYibgC+EWFu+BV/abPFD3rcbTVm8Y53rt7gtbSE4/tVzrZPYycXI2f92biylO/r1v2bgm4rt zggrSqHqnXuE2hyQe89BILq7zonQnF1fHXWeGOiYbvrkp/flYHlwhxzW8g6ReXrmNLQUSgXrXz5+v gqTWDs/vEyMGOIVfMPWiPKgJzzcLbDkSblkJJiO5QSzPv4nf3skEbp6A+gSOQ3MmSPbwvJMFx2DJz XBtyBBmWVdvD3nZBVVCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzhp0-00000005WG0-2Kyn; Wed, 24 Apr 2024 18:58:22 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzhow-00000005WDO-3dgx for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 18:58:20 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-56e47843cc7so142815a12.0 for ; Wed, 24 Apr 2024 11:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713985095; x=1714589895; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DwvbZeXK2LmNo0b/liHJV6gTDtg1IGPQpDm4DyK4ylU=; b=YcXl5SubkHQLizksSsKU2+SFKFQOffoLOigH9ov9SynyIQbRPodB0iIi6koE2FKvJS 1Fun0RijeaE7El8c2KX0CkjHpTqFr5xr2doYy0fmwdM00sNhxrENLaOkDeOAMq58G1jY rKHsOtyw50CaT1UXkcpdTyqSrEfMeCbo/CDwuTTCcvFyaCsrnS53djvcrWQkSe/ylb/o yDOJtASbm0CvXQxr7t7mxFKHR7HGNhXuiN5mudyqHDm5AOpZlBcPzgbfZBaiTktyu1es rFkrDrjLLQK0qkCe9LLrxCbYEX5gEr7U0OFB23qxqlT5XkeZJk/N+IN/Kgz9hVvS4Sev IQKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713985095; x=1714589895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DwvbZeXK2LmNo0b/liHJV6gTDtg1IGPQpDm4DyK4ylU=; b=Sn2KbuXi4eQ/Yr1ZKg5nbTS0ogIbNxHm0zE392dg+MbhIqdtt3dH8YGwnffsAXlD+A XfgR6G9h5NXWdPo/uQoFUmmOILanNm2yRKRJPtaGBqilMfAZcSS+vtXKS/eOexBIJHv6 uNHGJqt4/a0nU38a/mPe6NQfl7kXTif8Ier+F0efJQ7Zk+GMZWlgqtcFyqr4qCgQAOXz +33PZFMt/ZdRtmkH2KSF2h4Pa12F2WDkNri9u5ByKYF8M/1D7VjtQ7j9SVGYqr+mb9Ow pFWHbixnu1jHlEisaJnF+lxuoDZKplqVyJ95+ghJkm/Gx0ZEzTAB4a3kdVgVphk+u5pc QYXA== X-Forwarded-Encrypted: i=1; AJvYcCVr/QTdf67PUopsSYhuGRz6RbbSXd1rwgLRZNrfx6HjizYBhut2k31gE50VpyowNdbN+GE0NVmdPB5eoRrHsA8842iACuDf31PKXtaR9F8qyJXHbE4= X-Gm-Message-State: AOJu0Yyfer6iok1/RbsqFiONvk39T4qEEjzQAOJ29kPxSSQYBbwAOBgP Hv5kINIG2R5SDsMPY+9HrcJX2znH0qv++ofogOQ/9ru+8VoehGfL X-Google-Smtp-Source: AGHT+IFFeaRzMd/7Smdm00f104rcu/P7ErgzU3rDoChCfzP3EQsfV2DOJK5NtUDrizGxdpXgYZNMBQ== X-Received: by 2002:a50:c90a:0:b0:572:3cc4:2dcf with SMTP id o10-20020a50c90a000000b005723cc42dcfmr95098edh.14.1713985094787; Wed, 24 Apr 2024 11:58:14 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id ij6-20020a056402158600b005705bfeeb27sm8103284edb.66.2024.04.24.11.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 11:58:14 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Cc: Krzysztof Kozlowski Subject: Re: [PATCH] dt-bindings: mfd: allwinner,sun6i-a31-prcm: Use hyphens in node names Date: Wed, 24 Apr 2024 20:58:13 +0200 Message-ID: <2320577.ElGaqSPkdT@jernej-laptop> In-Reply-To: <20240424045521.31857-1-krzysztof.kozlowski@linaro.org> References: <20240424045521.31857-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_115818_947396_5A81E2E2 X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 24. april 2024 ob 06:55:21 GMT +2 je Krzysztof Kozlowski napisal(a): > Underscores should not be used in node names (dtc with W=2 warns about > them), so replace them with hyphens. This should have no impact on > known users: Linux MFD driver does not care about children node names. > DTS was already adjusted in commit 0f47ef3ff1bd ("arm: dts: allwinner: drop > underscore in node names"), so without this change, we observe > dtbs_check warnings: > > sun6i-a31s-colorfly-e708-q1.dtb: prcm@1f01400: 'ahb0-clk', 'apb0-clk', 'apb0-gates-clk', 'apb0-rst', 'ar100-clk', 'ir-clk' do not match any of the regexes: '^.*_(clk|rst)$', 'pinctrl-[0-9]+' > > Reported-by: Rob Herring > Closes: https://lore.kernel.org/all/CAL_JsqJfT-jui5P56CO4Fr37kr5iNN8dpxt8ecKeFmdVGnRYbA@mail.gmail.com/ > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > .../bindings/mfd/allwinner,sun6i-a31-prcm.yaml | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml b/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml > index 8789e3639ff7..ca0e9f1f2354 100644 > --- a/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml > +++ b/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml > @@ -20,7 +20,7 @@ properties: > maxItems: 1 > > patternProperties: > - "^.*_(clk|rst)$": > + "^.*-(clk|rst)$": > type: object > unevaluatedProperties: false > > @@ -171,7 +171,7 @@ examples: > compatible = "allwinner,sun6i-a31-prcm"; > reg = <0x01f01400 0x200>; > > - ar100: ar100_clk { > + ar100: ar100-clk { > compatible = "allwinner,sun6i-a31-ar100-clk"; > #clock-cells = <0>; > clocks = <&rtc 0>, <&osc24M>, > @@ -180,7 +180,7 @@ examples: > clock-output-names = "ar100"; > }; > > - ahb0: ahb0_clk { > + ahb0: ahb0-clk { > compatible = "fixed-factor-clock"; > #clock-cells = <0>; > clock-div = <1>; > @@ -189,14 +189,14 @@ examples: > clock-output-names = "ahb0"; > }; > > - apb0: apb0_clk { > + apb0: apb0-clk { > compatible = "allwinner,sun6i-a31-apb0-clk"; > #clock-cells = <0>; > clocks = <&ahb0>; > clock-output-names = "apb0"; > }; > > - apb0_gates: apb0_gates_clk { > + apb0_gates: apb0-gates-clk { > compatible = "allwinner,sun6i-a31-apb0-gates-clk"; > #clock-cells = <1>; > clocks = <&apb0>; > @@ -206,14 +206,14 @@ examples: > "apb0_i2c"; > }; > > - ir_clk: ir_clk { > + ir_clk: ir-clk { > #clock-cells = <0>; > compatible = "allwinner,sun4i-a10-mod0-clk"; > clocks = <&rtc 0>, <&osc24M>; > clock-output-names = "ir"; > }; > > - apb0_rst: apb0_rst { > + apb0_rst: apb0-rst { > compatible = "allwinner,sun6i-a31-clock-reset"; > #reset-cells = <1>; > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel