From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] dt-bindings: Add Reset Controller for MediaTek SoC
Date: Thu, 30 Oct 2014 11:10:20 +0100 [thread overview]
Message-ID: <2323181.epJX0Uxj7x@wuerfel> (raw)
In-Reply-To: <1414638733-10080-3-git-send-email-flora.fu@mediatek.com>
On Thursday 30 October 2014 11:12:12 flora.fu at mediatek.com wrote:
> +
> +example:
> + infrarst: reset-controller at 10001030 {
> + #reset-cells = <1>;
> + compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
> + mediatek,syscon-reset = <&infracfg 0x30 0x8>;
> + };
I think you need to change the 'unit-address' now, i.e. the @10001030
value above no longer matches any reg property. You could just
remove that part.
> +Specifying reset lines connected to IP modules
> +==============================================
> +
> +The reset controller(mtk-reset) manages various reset sources. Those device nodes should
> +specify the reset line on the rstc in their resets property, containing a phandle to the
> +rstc device node and a RESET_INDEX specifying which module to reset, as described in
> +reset.txt.
> +
> +For MediaTek SoC, RESET_INDEX is reset bit defined in INFRACFG or PERICFG registers.
> +
> +example:
> +pwrap: pwrap at 1000f000 {
> + compatible = "mediatek,mt8135-pwrap";
> + reg = <0 0x1000f000 0 0x1000>,
> + <0 0x11017000 0 0x1000>;
> + reg-names = "pwrap-base",
> + "pwrap-bridge-base";
> + resets = <&infrarst 7>, <&perirst 34>;
> + reset-names = "infrarst", "perirst";
> + };
> +};
>
You have an extraneous '};' here.
Arnd
next prev parent reply other threads:[~2014-10-30 10:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 3:12 [PATCH 0/3] Add Reset Controller for MediaTek SoC flora.fu at mediatek.com
2014-10-30 3:12 ` [PATCH 1/3] ARM: mediatek: " flora.fu at mediatek.com
2014-10-30 9:23 ` Philipp Zabel
2014-10-30 12:39 ` Matthias Brugger
2014-10-30 3:12 ` [PATCH 2/3] dt-bindings: " flora.fu at mediatek.com
2014-10-30 10:10 ` Arnd Bergmann [this message]
2014-10-30 3:12 ` [PATCH 3/3] ARM: dts: mt8135: " flora.fu at mediatek.com
2014-10-30 9:02 ` Philipp Zabel
2014-10-30 10:11 ` Arnd Bergmann
2014-10-31 3:35 ` Flora Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2323181.epJX0Uxj7x@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox