[REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[Rudraksha Gupta]

Hello all,


Found a regression with a platform that has the msm8960 SoC. Was hoping 
to code up a fix myself, but I'm not adept in ARM architecture or the 
Linux kernel, so I'm just reporting it here. Reverting this commit seems 
to fix it as well. Please let me know if there is anything else I should 
provide for this regression report.

#regzbot introduced 449d0d84bcd8246b508d07995326d13c54488b8c

Error: https://pastebin.com/SDRENUGk

Defconfig: https://pastebin.com/CRDjC39a

Platform: 
https://wiki.postmarketos.org/wiki/Samsung_Galaxy_Express_SGH-I437_(samsung-expressatt)


Thanks,
Rudraksha

Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[Linux regression tracking (Thorsten Leemhuis)]

Lo! Thx for your report!

On 25.08.24 08:51, Rudraksha Gupta wrote:
> 
> Found a regression with a platform that has the msm8960 SoC. Was hoping
> to code up a fix myself, but I'm not adept in ARM architecture or the
> Linux kernel, so I'm just reporting it here. Reverting this commit seems
> to fix it as well. Please let me know if there is anything else I should
> provide for this regression report.
> 
> #regzbot introduced 449d0d84bcd8246b508d07995326d13c54488b8c

FWIW, that is 449d0d84bcd824 ("firmware: qcom: scm: smc: switch to using
the SCM allocator") [v6.11-rc1] which was authored by Bartosz
Golaszewski and commited by Bjorn Andersson.
 
> Error: https://pastebin.com/SDRENUGk

Better include the exact problem you face in your report so
that search engines can do their magic; makes it also easier
to handle for everyone.

Furthermore two quick questions:

[    0.000000] Linux version 6.10.0-rc1-msm8960+ (a@fpx-l-AMER03105) (Ubuntu clang version 16.0.6 (15), Ubuntu LLD 16.0.6) #17 SMP Sat

Is that a vanilla kernel or one close to it? That "msm8960+" sounds
somewhat suspicious. 

And does the problem still happen with latest mainline? Cconsider
retrying with -rc5, which should be out in the next 24h.

And FWIW, here is the afaics relevant part of the problem: 

[    0.047411] Mount-cache hash table entries: 2048 (order: 1, 8192 bytes, linear)
[    0.051541] Mountpoint-cache hash table entries: 2048 (order: 1, 8192 bytes, linear)
[    0.060470] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000
[    0.066411] 8<--- cut here ---
[    0.071896] Unable to handle kernel NULL pointer dereference at virtual address 00000090 when read
[    0.074743] [00000090] *pgd=00000000
[    0.083675] Internal error: Oops: 5 [#1] SMP ARM
[    0.087283] Modules linked in:
[    0.091833] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.10.0-rc1-msm8960+ #17
[    0.094673] Hardware name: Generic DT based system
[    0.101804] PC is at qcom_scm_get_tzmem_pool+0x1c/0x24
[    0.106443] LR is at __scm_smc_call+0x30/0x2d4
[    0.111511] pc : [<c089176c>]    lr : [<c0893fb0>]    psr: 60000013
[    0.115896] sp : f0815d78  ip : f0815e98  fp : f0815d78
[    0.121995] r10: 00000002  r9 : f0815e18  r8 : 00000001
[    0.127150] r7 : c1106694  r6 : f0815e30  r5 : c126ff4c  r4 : 00000001
[    0.132308] r3 : f0815e18  r2 : 00000002  r1 : f0815e30  r0 : 00000000
[    0.138839] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
[    0.145288] Control: 10c5787d  Table: 8000406a  DAC: 00000051
[    0.152413] Register r0 information: NULL pointer
[    0.158083] Register r1 information: 2-page vmalloc region starting at 0xf0814000 allocated at copy_process+0x16c/0xddc
[    0.162735] Register r2 information: non-paged memory
[    0.173205] Register r3 information: 2-page vmalloc region starting at 0xf0814000 allocated at copy_process+0x16c/0xddc
[    0.178373] Register r4 information: non-paged memory
[    0.188845] Register r5 information: non-slab/vmalloc memory
[    0.194002] Register r6 information: 2-page vmalloc region starting at 0xf0814000 allocated at copy_process+0x16c/0xddc
[    0.199682] Register r7 information: non-slab/vmalloc memory
[    0.210069] Register r8 information: non-paged memory
[    0.215911] Register r9 information: 2-page vmalloc region starting at 0xf0814000 allocated at copy_process+0x16c/0xddc
[    0.220819] Register r10 information: non-paged memory
[    0.231292] Register r11 information: 2-page vmalloc region starting at 0xf0814000 allocated at copy_process+0x16c/0xddc
[    0.236460] Register r12 information: 2-page vmalloc region starting at 0xf0814000 allocated at copy_process+0x16c/0xddc
[    0.247372] Process swapper/0 (pid: 1, stack limit = 0x(ptrval))
[    0.258105] Stack: (0xf0815d78 to 0xf0816000)
[    0.264034] 5d60:                                                       f0815e08 c0893fb0
[    0.268257] 5d80: f0815d9c c01953fc c1118278 c1124508 00000037 00000000 c1118278 f0815da8
[    0.276334] 5da0: c125875c 00000800 00000036 00000000 039ab58a 00000000 c2000030 c0a5cee4
[    0.284411] 5dc0: f0815dd8 c01953fc c1118278 c1124508 00000037 00000000 c1118278 00000000
[    0.292489] 5de0: f0815e18 c01953fc dedf13d9 00000001 c126ff4c 00000000 c1106694 00000001
[    0.300564] 5e00: f0815ef0 00000000 f0815eb0 c0893658 00000001 c0195934 f0815e78 c0195934
[    0.308641] 5e20: f0815e48 00000000 f0815ebf f0815e4c 00000006 00000001 00000001 00000000
[    0.316718] 5e40: 02000601 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    0.324794] 5e60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    0.332873] 5e80: 00000000 00000000 00000000 00000000 00000002 00000000 f0815ebf dedf13d9
[    0.340950] 5ea0: 00000000 f0815ee0 00000000 00000000 f0815ed0 c0891aa0 f0815ec8 00a8fbe0
[    0.349027] 5ec0: f0815ef8 c0b8c08f 00000001 00000000 f0815f68 c0891980 00000001 c01012a0
[    0.357103] 5ee0: 00000001 00000001 00000002 00000000 00000001 00000000 801012a0 00000000
[    0.365180] 5f00: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    0.373258] 5f20: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    0.381335] 5f40: 00000002 00000000 dedf13d9 c1509100 00000001 c1568000 00000000 00000000
[    0.389411] 5f60: 00000000 00000000 f0815f80 c100bf5c c1509100 00000001 c1568000 00000000
[    0.397489] 5f80: f0815f98 c1001538 00000000 c0a8b56c 00000000 00000000 f0815fa8 c0a8b58c
[    0.405565] 5fa0: 00000000 00000000 00000000 c010014c 00000000 00000000 00000000 00000000
[    0.413643] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    0.421718] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000
[    0.429788] Call trace:
[    0.429813]  qcom_scm_get_tzmem_pool from __scm_smc_call+0x30/0x2d4
[    0.440444]  __scm_smc_call from __get_convention+0xac/0x128
[    0.446370]  __get_convention from qcom_scm_call_atomic+0x24/0x90
[    0.452214]  qcom_scm_call_atomic from qcom_scm_set_boot_addr+0xe4/0x100
[    0.458142]  qcom_scm_set_boot_addr from qcom_smp_prepare_cpus+0x1c/0x94
[    0.464849]  qcom_smp_prepare_cpus from kernel_init_freeable+0xcc/0x140
[    0.471462]  kernel_init_freeable from kernel_init+0x20/0x144
[    0.477734]  kernel_init from ret_from_fork+0x14/0x28
[    0.483571] Exception stack(0xf0815fb0 to 0xf0815ff8)
[    0.488561] 5fa0:                                     00000000 00000000 00000000 00000000
[    0.493554] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    0.501628] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[    0.509710] Code: e28dd004 e30f0f50 e34c0126 e5900000 (e5900090)
[    0.516140] ---[ end trace 0000000000000000 ]---
[    0.522249] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[    0.526890] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]---

> Defconfig: https://pastebin.com/CRDjC39a
> 
> Platform:
> https://wiki.postmarketos.org/wiki/Samsung_Galaxy_Express_SGH-I437_(samsung-expressatt)

Ciao, Thorsten

P.S.:

#regzbot title: firmware: qcom: scm: smc: msm8960 SoC fails to boot

Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[Rudraksha Gupta]

> Lo! Thx for your report!

Thanks for reading my report!


> Better include the exact problem you face in your report so
> that search engines can do their magic; makes it also easier
> to handle for everyone.

Ack. Some communities like to keep their messages tidy, so I assumed 
that was the case here as well.


> Furthermore two quick questions:
>
> [    0.000000] Linux version 6.10.0-rc1-msm8960+ (a@fpx-l-AMER03105) (Ubuntu clang version 16.0.6 (15), Ubuntu LLD 16.0.6) #17 SMP Sat
>
> Is that a vanilla kernel or one close to it? That "msm8960+" sounds
> somewhat suspicious.

It's vanilla. I use this script to build Linux and busybox and then 
flash it to my phone: 
https://codeberg.org/LogicalErzor/mainline_builder/src/branch/master/samsung/expressatt/build.sh

The msm8960 is defined as a localversion in the defconfig pastebin (I 
should've named it config instead). Not sure where the + came from though


> And does the problem still happen with latest mainline? Cconsider
> retrying with -rc5, which should be out in the next 24h.

Yes, -rc5's commit is 5be63fc19fcaa4c236b307420483578a56986a37 and I'm 
still encountering it. Pasted below

[    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Linux version 6.11.0-rc5-msm8960 (a@fpx-l-AMER03105) 
(Ubuntu clang version 16.0.6 (15), Ubuntu LLD 16.0.6) #19 SMP Sun Aug 25 
15:55:46 EDT 2024
[    0.000000] CPU: ARMv7 Processor [511f04d4] revision 4 (ARMv7), 
cr=10c5787d
[    0.000000] CPU: div instructions available: patching division code
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPT instruction 
cache
[    0.000000] OF: fdt: Machine model: Samsung Galaxy Express SGH-I437
[    0.000000] earlycon: msm_serial_dm0 at MMIO 0x16440000 (options 
'115200n8')
[    0.000000] printk: legacy bootconsole [msm_serial_dm0] enabled
[    0.000000] Memory policy: Data cache writealloc
[    0.000000] Zone ranges:
[    0.000000]   Normal   [mem 0x0000000080200000-0x00000000afffffff]
[    0.000000]   HighMem  [mem 0x00000000b0000000-0x00000000bfffffff]
[    0.000000] Movable zone start for each node
[    0.000000] Early memory node ranges
[    0.000000]   node   0: [mem 0x0000000080200000-0x0000000088cfffff]
[    0.000000]   node   0: [mem 0x0000000090000000-0x00000000bfffffff]
[    0.000000] Initmem setup node 0 [mem 
0x0000000080200000-0x00000000bfffffff]
[    0.000000] On node 0, zone Normal: 512 pages in unavailable ranges
[    0.000000] On node 0, zone Normal: 768 pages in unavailable ranges
[    0.000000] percpu: Embedded 19 pages/cpu s45144 r8192 d24488 u77824
[    0.000000] Kernel command line: earlycon clk_ignore_unused 
PMOS_NO_OUTPUT_REDIRECT console=ttyMSM0,115200
[    0.000000] Unknown kernel command line parameters 
"PMOS_NO_OUTPUT_REDIRECT", will be passed to user space.
[    0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288 
bytes, linear)
[    0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144 
bytes, linear)
[    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 232192
[    0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off
[    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=2, Nodes=1
[    0.000000] ftrace: allocating 38226 entries in 75 pages
[    0.000000] ftrace: allocated 75 pages with 4 groups
[    0.000000] trace event string verifier disabled
[    0.000000] rcu: Hierarchical RCU implementation.
[    0.000000] rcu:     RCU event tracing is enabled.
[    0.000000] rcu:     RCU restricting CPUs from NR_CPUS=4 to nr_cpu_ids=2.
[    0.000000]  Rude variant of Tasks RCU enabled.
[    0.000000]  Tracing variant of Tasks RCU enabled.
[    0.000000] rcu: RCU calculated value of scheduler-enlistment delay 
is 10 jiffies.
[    0.000000] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=2
[    0.000000] RCU Tasks Rude: Setting shift to 1 and lim to 1 
rcu_task_cb_adjust=1.
[    0.000000] RCU Tasks Trace: Setting shift to 1 and lim to 1 
rcu_task_cb_adjust=1.
[    0.000000] NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16
[    0.000000] rcu: srcu_init: Setting srcu_struct sizes based on 
contention.
[    0.000000] clocksource: dg_timer: mask: 0xffffffff max_cycles: 
0xffffffff, max_idle_ns: 283149695806 ns
[    0.000003] sched_clock: 32 bits at 7MHz, resolution 148ns, wraps 
every 318145725365ns
[    0.009533] Switching to timer-based delay loop, resolution 148ns
[    0.017921] Console: colour dummy device 80x30
[    0.023312] Calibrating delay loop (skipped), value calculated using 
timer frequency.. 13.50 BogoMIPS (lpj=67500)
[    0.027574] CPU: Testing write buffer coherency: ok
[    0.037857] pid_max: default: 32768 minimum: 301
[    0.042568] LSM: initializing lsm=capability
[    0.047412] Mount-cache hash table entries: 2048 (order: 1, 8192 
bytes, linear)
[    0.051538] Mountpoint-cache hash table entries: 2048 (order: 1, 8192 
bytes, linear)
[    0.060533] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000
[    0.066438] 8<--- cut here ---
[    0.071897] Unable to handle kernel NULL pointer dereference at 
virtual address 00000090 when read
[    0.074743] [00000090] *pgd=00000000
[    0.083672] Internal error: Oops: 5 [#1] SMP ARM
[    0.087285] Modules linked in:
[    0.091836] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 
6.11.0-rc5-msm8960 #19
[    0.094677] Hardware name: Generic DT based system
[    0.102149] PC is at qcom_scm_get_tzmem_pool+0x1c/0x24
[    0.106958] LR is at __scm_smc_call+0x30/0x2d4
[    0.112026] pc : [<c08986c0>]    lr : [<c089b1e4>]    psr: 60000013
[    0.116413] sp : f0815d78  ip : f0815e98  fp : f0815d78
[    0.122511] r10: 00000002  r9 : f0815e18  r8 : 00000001
[    0.127666] r7 : c1106694  r6 : f0815e30  r5 : c1270040  r4 : 00000001
[    0.132825] r3 : f0815e18  r2 : 00000002  r1 : f0815e30  r0 : 00000000
[    0.139355] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  
Segment none
[    0.145804] Control: 10c5787d  Table: 8000406a  DAC: 00000051
[    0.152930] Register r0 information: NULL pointer
[    0.158599] Register r1 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdec
[    0.163251] Register r2 information: non-paged memory
[    0.173722] Register r3 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdec
[    0.178889] Register r4 information: non-paged memory
[    0.189361] Register r5 information: non-slab/vmalloc memory
[    0.194518] Register r6 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdec
[    0.200197] Register r7 information: non-slab/vmalloc memory
[    0.210586] Register r8 information: non-paged memory
[    0.216428] Register r9 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdec
[    0.221336] Register r10 information: non-paged memory
[    0.231809] Register r11 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdec
[    0.236974] Register r12 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdec
[    0.247889] Process swapper/0 (pid: 1, stack limit = 0x(ptrval))
[    0.258620] Stack: (0xf0815d78 to 0xf0816000)
[    0.264550] 5d60: f0815e08 c089b1e4
[    0.268773] 5d80: f0815d9c c0193d54 c1117d70 c1124000 00000036 
00000000 c1117d70 f0815da8
[    0.276849] 5da0: c12589bc 00000800 00000035 00000000 039ba92c 
00000000 c2000030 c0a6f3a4
[    0.284927] 5dc0: f0815dd8 c0193d54 c1117d70 c1124000 00000036 
00000000 c1117d70 00000000
[    0.293004] 5de0: f0815e18 c0193d54 e37f60fb 00000001 c1270040 
00000000 c1106694 00000001
[    0.301080] 5e00: f0815ef0 00000000 f0815eb0 c089a830 00000001 
c019428c f0815e78 c019428c
[    0.309157] 5e20: f0815e48 00000000 f0815ebf f0815e4c 00000006 
00000001 00000001 00000000
[    0.317234] 5e40: 02000601 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.325310] 5e60: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.333387] 5e80: 00000000 00000000 00000000 00000000 00000002 
00000000 f0815ebf e37f60fb
[    0.341465] 5ea0: 00000000 f0815ee0 00000000 00000000 f0815ed0 
c08989f4 f0815ec8 00aa2034
[    0.349543] 5ec0: f0815ef8 c0b8d77f 00000001 00000000 f0815f68 
c08988d4 00000001 c01012a0
[    0.357618] 5ee0: 00000001 00000001 00000002 00000000 00000001 
00000000 801012a0 00000000
[    0.365695] 5f00: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.373771] 5f20: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.381851] 5f40: 00000002 00000000 e37f60fb c14ff100 00000001 
c1568000 00000000 00000000
[    0.389927] 5f60: 00000000 00000000 f0815f80 c100bf08 c14ff100 
00000001 c1568000 00000000
[    0.398005] 5f80: f0815f98 c1001538 00000000 c0a9dc8c 00000000 
00000000 f0815fa8 c0a9dcac
[    0.406082] 5fa0: 00000000 00000000 00000000 c010014c 00000000 
00000000 00000000 00000000
[    0.414158] 5fc0: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.422234] 5fe0: 00000000 00000000 00000000 00000000 00000013 
00000000 00000000 00000000
[    0.430303] Call trace:
[    0.430329]  qcom_scm_get_tzmem_pool from __scm_smc_call+0x30/0x2d4
[    0.440957]  __scm_smc_call from __get_convention+0xac/0x128
[    0.446885]  __get_convention from qcom_scm_call_atomic+0x24/0x90
[    0.452730]  qcom_scm_call_atomic from qcom_scm_set_boot_addr+0xe4/0x100
[    0.458658]  qcom_scm_set_boot_addr from qcom_smp_prepare_cpus+0x1c/0x94
[    0.465362]  qcom_smp_prepare_cpus from kernel_init_freeable+0xcc/0x140
[    0.471978]  kernel_init_freeable from kernel_init+0x20/0x144
[    0.478251]  kernel_init from ret_from_fork+0x14/0x28
[    0.484086] Exception stack(0xf0815fb0 to 0xf0815ff8)
[    0.489076] 5fa0:                                     00000000 
00000000 00000000 00000000
[    0.494068] 5fc0: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.502143] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[    0.510226] Code: e28dd004 e3000044 e34c0127 e5900000 (e5900090)
[    0.516655] ---[ end trace 0000000000000000 ]---
[    0.522765] Kernel panic - not syncing: Attempted to kill init! 
exitcode=0x0000000b
[    0.527408] ---[ end Kernel panic - not syncing: Attempted to kill 
init! exitcode=0x0000000b ]---


Thanks,

Rudraksha

Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[Linux regression tracking (Thorsten Leemhuis)]

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
for once, to make this easily accessible to everyone.

Hmm, from the outside it looks like nobody looked into below regression
report (reminder: culprit authored by Bartosz Golaszewski and commited
by Bjorn Andersson). Wonder why. Did it fall through the cracks or did I
miss anything?

Rudraksha Gupta: I assume the issue still happens?

/me considered bringing in Linus, but decided to wait a bit

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

On 25.08.24 22:40, Rudraksha Gupta wrote:
> [...]
>> Furthermore two quick questions:
>>
>> [    0.000000] Linux version 6.10.0-rc1-msm8960+ (a@fpx-l-AMER03105)
>> (Ubuntu clang version 16.0.6 (15), Ubuntu LLD 16.0.6) #17 SMP Sat
>>
>> Is that a vanilla kernel or one close to it? That "msm8960+" sounds
>> somewhat suspicious.
> 
> It's vanilla. I use this script to build Linux and busybox and then
> flash it to my phone: https://codeberg.org/LogicalErzor/
> mainline_builder/src/branch/master/samsung/expressatt/build.sh
> 
> The msm8960 is defined as a localversion in the defconfig pastebin (I
> should've named it config instead). Not sure where the + came from though
> 
>> And does the problem still happen with latest mainline? Cconsider
>> retrying with -rc5, which should be out in the next 24h.
> 
> Yes, -rc5's commit is 5be63fc19fcaa4c236b307420483578a56986a37 and I'm
> still encountering it. Pasted below
> 
> [    0.000000] Booting Linux on physical CPU 0x0
> [    0.000000] Linux version 6.11.0-rc5-msm8960 (a@fpx-l-AMER03105)
> (Ubuntu clang version 16.0.6 (15), Ubuntu LLD 16.0.6) #19 SMP Sun Aug 25
> 15:55:46 EDT 2024
> [    0.000000] CPU: ARMv7 Processor [511f04d4] revision 4 (ARMv7),
> cr=10c5787d
> [    0.000000] CPU: div instructions available: patching division code
> [    0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPT instruction
> cache
> [    0.000000] OF: fdt: Machine model: Samsung Galaxy Express SGH-I437
> [    0.000000] earlycon: msm_serial_dm0 at MMIO 0x16440000 (options
> '115200n8')
> [    0.000000] printk: legacy bootconsole [msm_serial_dm0] enabled
> [    0.000000] Memory policy: Data cache writealloc
> [    0.000000] Zone ranges:
> [    0.000000]   Normal   [mem 0x0000000080200000-0x00000000afffffff]
> [    0.000000]   HighMem  [mem 0x00000000b0000000-0x00000000bfffffff]
> [    0.000000] Movable zone start for each node
> [    0.000000] Early memory node ranges
> [    0.000000]   node   0: [mem 0x0000000080200000-0x0000000088cfffff]
> [    0.000000]   node   0: [mem 0x0000000090000000-0x00000000bfffffff]
> [    0.000000] Initmem setup node 0 [mem
> 0x0000000080200000-0x00000000bfffffff]
> [    0.000000] On node 0, zone Normal: 512 pages in unavailable ranges
> [    0.000000] On node 0, zone Normal: 768 pages in unavailable ranges
> [    0.000000] percpu: Embedded 19 pages/cpu s45144 r8192 d24488 u77824
> [    0.000000] Kernel command line: earlycon clk_ignore_unused
> PMOS_NO_OUTPUT_REDIRECT console=ttyMSM0,115200
> [    0.000000] Unknown kernel command line parameters
> "PMOS_NO_OUTPUT_REDIRECT", will be passed to user space.
> [    0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288
> bytes, linear)
> [    0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144
> bytes, linear)
> [    0.000000] Built 1 zonelists, mobility grouping on.  Total pages:
> 232192
> [    0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off
> [    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=2, Nodes=1
> [    0.000000] ftrace: allocating 38226 entries in 75 pages
> [    0.000000] ftrace: allocated 75 pages with 4 groups
> [    0.000000] trace event string verifier disabled
> [    0.000000] rcu: Hierarchical RCU implementation.
> [    0.000000] rcu:     RCU event tracing is enabled.
> [    0.000000] rcu:     RCU restricting CPUs from NR_CPUS=4 to
> nr_cpu_ids=2.
> [    0.000000]  Rude variant of Tasks RCU enabled.
> [    0.000000]  Tracing variant of Tasks RCU enabled.
> [    0.000000] rcu: RCU calculated value of scheduler-enlistment delay
> is 10 jiffies.
> [    0.000000] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=2
> [    0.000000] RCU Tasks Rude: Setting shift to 1 and lim to 1
> rcu_task_cb_adjust=1.
> [    0.000000] RCU Tasks Trace: Setting shift to 1 and lim to 1
> rcu_task_cb_adjust=1.
> [    0.000000] NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16
> [    0.000000] rcu: srcu_init: Setting srcu_struct sizes based on
> contention.
> [    0.000000] clocksource: dg_timer: mask: 0xffffffff max_cycles:
> 0xffffffff, max_idle_ns: 283149695806 ns
> [    0.000003] sched_clock: 32 bits at 7MHz, resolution 148ns, wraps
> every 318145725365ns
> [    0.009533] Switching to timer-based delay loop, resolution 148ns
> [    0.017921] Console: colour dummy device 80x30
> [    0.023312] Calibrating delay loop (skipped), value calculated using
> timer frequency.. 13.50 BogoMIPS (lpj=67500)
> [    0.027574] CPU: Testing write buffer coherency: ok
> [    0.037857] pid_max: default: 32768 minimum: 301
> [    0.042568] LSM: initializing lsm=capability
> [    0.047412] Mount-cache hash table entries: 2048 (order: 1, 8192
> bytes, linear)
> [    0.051538] Mountpoint-cache hash table entries: 2048 (order: 1, 8192
> bytes, linear)
> [    0.060533] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000
> [    0.066438] 8<--- cut here ---
> [    0.071897] Unable to handle kernel NULL pointer dereference at
> virtual address 00000090 when read
> [    0.074743] [00000090] *pgd=00000000
> [    0.083672] Internal error: Oops: 5 [#1] SMP ARM
> [    0.087285] Modules linked in:
> [    0.091836] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.11.0-
> rc5-msm8960 #19
> [    0.094677] Hardware name: Generic DT based system
> [    0.102149] PC is at qcom_scm_get_tzmem_pool+0x1c/0x24
> [    0.106958] LR is at __scm_smc_call+0x30/0x2d4
> [    0.112026] pc : [<c08986c0>]    lr : [<c089b1e4>]    psr: 60000013
> [    0.116413] sp : f0815d78  ip : f0815e98  fp : f0815d78
> [    0.122511] r10: 00000002  r9 : f0815e18  r8 : 00000001
> [    0.127666] r7 : c1106694  r6 : f0815e30  r5 : c1270040  r4 : 00000001
> [    0.132825] r3 : f0815e18  r2 : 00000002  r1 : f0815e30  r0 : 00000000
> [    0.139355] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM 
> Segment none
> [    0.145804] Control: 10c5787d  Table: 8000406a  DAC: 00000051
> [    0.152930] Register r0 information: NULL pointer
> [    0.158599] Register r1 information: 2-page vmalloc region starting
> at 0xf0814000 allocated at copy_process+0x16c/0xdec
> [    0.163251] Register r2 information: non-paged memory
> [    0.173722] Register r3 information: 2-page vmalloc region starting
> at 0xf0814000 allocated at copy_process+0x16c/0xdec
> [    0.178889] Register r4 information: non-paged memory
> [    0.189361] Register r5 information: non-slab/vmalloc memory
> [    0.194518] Register r6 information: 2-page vmalloc region starting
> at 0xf0814000 allocated at copy_process+0x16c/0xdec
> [    0.200197] Register r7 information: non-slab/vmalloc memory
> [    0.210586] Register r8 information: non-paged memory
> [    0.216428] Register r9 information: 2-page vmalloc region starting
> at 0xf0814000 allocated at copy_process+0x16c/0xdec
> [    0.221336] Register r10 information: non-paged memory
> [    0.231809] Register r11 information: 2-page vmalloc region starting
> at 0xf0814000 allocated at copy_process+0x16c/0xdec
> [    0.236974] Register r12 information: 2-page vmalloc region starting
> at 0xf0814000 allocated at copy_process+0x16c/0xdec
> [    0.247889] Process swapper/0 (pid: 1, stack limit = 0x(ptrval))
> [    0.258620] Stack: (0xf0815d78 to 0xf0816000)
> [    0.264550] 5d60: f0815e08 c089b1e4
> [    0.268773] 5d80: f0815d9c c0193d54 c1117d70 c1124000 00000036
> 00000000 c1117d70 f0815da8
> [    0.276849] 5da0: c12589bc 00000800 00000035 00000000 039ba92c
> 00000000 c2000030 c0a6f3a4
> [    0.284927] 5dc0: f0815dd8 c0193d54 c1117d70 c1124000 00000036
> 00000000 c1117d70 00000000
> [    0.293004] 5de0: f0815e18 c0193d54 e37f60fb 00000001 c1270040
> 00000000 c1106694 00000001
> [    0.301080] 5e00: f0815ef0 00000000 f0815eb0 c089a830 00000001
> c019428c f0815e78 c019428c
> [    0.309157] 5e20: f0815e48 00000000 f0815ebf f0815e4c 00000006
> 00000001 00000001 00000000
> [    0.317234] 5e40: 02000601 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [    0.325310] 5e60: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [    0.333387] 5e80: 00000000 00000000 00000000 00000000 00000002
> 00000000 f0815ebf e37f60fb
> [    0.341465] 5ea0: 00000000 f0815ee0 00000000 00000000 f0815ed0
> c08989f4 f0815ec8 00aa2034
> [    0.349543] 5ec0: f0815ef8 c0b8d77f 00000001 00000000 f0815f68
> c08988d4 00000001 c01012a0
> [    0.357618] 5ee0: 00000001 00000001 00000002 00000000 00000001
> 00000000 801012a0 00000000
> [    0.365695] 5f00: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [    0.373771] 5f20: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [    0.381851] 5f40: 00000002 00000000 e37f60fb c14ff100 00000001
> c1568000 00000000 00000000
> [    0.389927] 5f60: 00000000 00000000 f0815f80 c100bf08 c14ff100
> 00000001 c1568000 00000000
> [    0.398005] 5f80: f0815f98 c1001538 00000000 c0a9dc8c 00000000
> 00000000 f0815fa8 c0a9dcac
> [    0.406082] 5fa0: 00000000 00000000 00000000 c010014c 00000000
> 00000000 00000000 00000000
> [    0.414158] 5fc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [    0.422234] 5fe0: 00000000 00000000 00000000 00000000 00000013
> 00000000 00000000 00000000
> [    0.430303] Call trace:
> [    0.430329]  qcom_scm_get_tzmem_pool from __scm_smc_call+0x30/0x2d4
> [    0.440957]  __scm_smc_call from __get_convention+0xac/0x128
> [    0.446885]  __get_convention from qcom_scm_call_atomic+0x24/0x90
> [    0.452730]  qcom_scm_call_atomic from qcom_scm_set_boot_addr+0xe4/0x100
> [    0.458658]  qcom_scm_set_boot_addr from qcom_smp_prepare_cpus+0x1c/0x94
> [    0.465362]  qcom_smp_prepare_cpus from kernel_init_freeable+0xcc/0x140
> [    0.471978]  kernel_init_freeable from kernel_init+0x20/0x144
> [    0.478251]  kernel_init from ret_from_fork+0x14/0x28
> [    0.484086] Exception stack(0xf0815fb0 to 0xf0815ff8)
> [    0.489076] 5fa0:                                     00000000
> 00000000 00000000 00000000
> [    0.494068] 5fc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [    0.502143] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [    0.510226] Code: e28dd004 e3000044 e34c0127 e5900000 (e5900090)
> [    0.516655] ---[ end trace 0000000000000000 ]---
> [    0.522765] Kernel panic - not syncing: Attempted to kill init!
> exitcode=0x0000000b
> [    0.527408] ---[ end Kernel panic - not syncing: Attempted to kill
> init! exitcode=0x0000000b ]---
> 
> 
> Thanks,
> 
> Rudraksha
> 
> 
> 

--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke

Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[Bartosz Golaszewski]

On Sun, 25 Aug 2024 at 08:51, Rudraksha Gupta <guptarud@gmail.com> wrote:
>
> Hello all,
>
>
> Found a regression with a platform that has the msm8960 SoC. Was hoping
> to code up a fix myself, but I'm not adept in ARM architecture or the
> Linux kernel, so I'm just reporting it here. Reverting this commit seems
> to fix it as well. Please let me know if there is anything else I should
> provide for this regression report.
>
> #regzbot introduced 449d0d84bcd8246b508d07995326d13c54488b8c
>
> Error: https://pastebin.com/SDRENUGk
>
> Defconfig: https://pastebin.com/CRDjC39a
>

Looks like qcom_scm_get_tzmem_pool() returns NULL. Not sure how this
happens. Can you confirm that the QCom SCM driver probed correctly?

Bart

> Platform:
> https://wiki.postmarketos.org/wiki/Samsung_Galaxy_Express_SGH-I437_(samsung-expressatt)
>
>
> Thanks,
> Rudraksha
>

Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[Rudraksha Gupta]

> Hmm, from the outside it looks like nobody looked into below regression
> report (reminder: culprit authored by Bartosz Golaszewski and commited
> by Bjorn Andersson). Wonder why. Did it fall through the cracks or did I
> miss anything?
>
> Rudraksha Gupta: I assume the issue still happens?
Thanks for poking this. Wasn't sure how fast this is supposed to be 
reverted/patched. And yep! Pasted below:

[    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Linux version 6.11.0-rc6-msm8960+ (user@localhost) 
(Alpine clang version 18.1.8, LLD 18.1.8) #2 SMP Sat Sep  7 01:22:22 PDT 
2024
[    0.000000] CPU: ARMv7 Processor [511f04d4] revision 4 (ARMv7), 
cr=10c5787d
[    0.000000] CPU: div instructions available: patching division code
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPT instruction 
cache
[    0.000000] OF: fdt: Machine model: Samsung Galaxy Express SGH-I437
[    0.000000] earlycon: msm_serial_dm0 at MMIO 0x16440000 (options 
'115200n8')
[    0.000000] printk: legacy bootconsole [msm_serial_dm0] enabled
[    0.000000] Memory policy: Data cache writealloc
[    0.000000] Zone ranges:
[    0.000000]   Normal   [mem 0x0000000080200000-0x00000000afffffff]
[    0.000000]   HighMem  [mem 0x00000000b0000000-0x00000000bfffffff]
[    0.000000] Movable zone start for each node
[    0.000000] Early memory node ranges
[    0.000000]   node   0: [mem 0x0000000080200000-0x0000000088cfffff]
[    0.000000]   node   0: [mem 0x0000000090000000-0x00000000bfffffff]
[    0.000000] Initmem setup node 0 [mem 
0x0000000080200000-0x00000000bfffffff]
[    0.000000] On node 0, zone Normal: 512 pages in unavailable ranges
[    0.000000] On node 0, zone Normal: 768 pages in unavailable ranges
[    0.000000] percpu: Embedded 19 pages/cpu s45144 r8192 d24488 u77824
[    0.000000] Kernel command line: earlycon clk_ignore_unused 
PMOS_NO_OUTPUT_REDIRECT console=ttyMSM0,115200
[    0.000000] Unknown kernel command line parameters 
"PMOS_NO_OUTPUT_REDIRECT", will be passed to user space.
[    0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288 
bytes, linear)
[    0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144 
bytes, linear)
[    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 232192
[    0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off
[    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=2, Nodes=1
[    0.000000] ftrace: allocating 38347 entries in 75 pages
[    0.000000] ftrace: allocated 75 pages with 4 groups
[    0.000000] trace event string verifier disabled
[    0.000000] rcu: Hierarchical RCU implementation.
[    0.000000] rcu:     RCU event tracing is enabled.
[    0.000000] rcu:     RCU restricting CPUs from NR_CPUS=4 to nr_cpu_ids=2.
[    0.000000]  Rude variant of Tasks RCU enabled.
[    0.000000]  Tracing variant of Tasks RCU enabled.
[    0.000000] rcu: RCU calculated value of scheduler-enlistment delay 
is 10 jiffies.
[    0.000000] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=2
[    0.000000] RCU Tasks Rude: Setting shift to 1 and lim to 1 
rcu_task_cb_adjust=1.
[    0.000000] RCU Tasks Trace: Setting shift to 1 and lim to 1 
rcu_task_cb_adjust=1.
[    0.000000] NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16
[    0.000000] rcu: srcu_init: Setting srcu_struct sizes based on 
contention.
[    0.000000] clocksource: dg_timer: mask: 0xffffffff max_cycles: 
0xffffffff, max_idle_ns: 283149695806 ns
[    0.000002] sched_clock: 32 bits at 7MHz, resolution 148ns, wraps 
every 318145725365ns
[    0.009532] Switching to timer-based delay loop, resolution 148ns
[    0.017997] Console: colour dummy device 80x30
[    0.023311] Calibrating delay loop (skipped), value calculated using 
timer frequency.. 13.50 BogoMIPS (lpj=67500)
[    0.027572] CPU: Testing write buffer coherency: ok
[    0.037875] pid_max: default: 32768 minimum: 301
[    0.042565] LSM: initializing lsm=capability
[    0.047408] Mount-cache hash table entries: 2048 (order: 1, 8192 
bytes, linear)
[    0.051555] Mountpoint-cache hash table entries: 2048 (order: 1, 8192 
bytes, linear)
[    0.060527] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000
[    0.066424] 8<--- cut here ---
[    0.071895] Unable to handle kernel NULL pointer dereference at 
virtual address 00000090 when read
[    0.074743] [00000090] *pgd=00000000
[    0.083659] Internal error: Oops: 5 [#1] SMP ARM
[    0.087283] Modules linked in:
[    0.091834] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 
6.11.0-rc6-msm8960+ #2
[    0.094674] Hardware name: Generic DT based system
[    0.102146] PC is at qcom_scm_get_tzmem_pool+0x1c/0x24
[    0.106956] LR is at __scm_smc_call+0x30/0x2d4
[    0.112025] pc : [<c08944b4>]    lr : [<c0896fd0>] psr: 60000013
[    0.116411] sp : f0815d78  ip : f0815e98  fp : f0815d78
[    0.122510] r10: 00000002  r9 : f0815e18  r8 : 00000001
[    0.127666] r7 : c1106694  r6 : f0815e30  r5 : c1270038  r4 : 00000001
[    0.132824] r3 : f0815e18  r2 : 00000002  r1 : f0815e30  r0 : 00000000
[    0.139354] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM 
Segment none
[    0.145803] Control: 10c5787d  Table: 8000406a  DAC: 00000051
[    0.152929] Register r0 information: NULL pointer
[    0.158597] Register r1 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdd8
[    0.163248] Register r2 information: non-paged memory
[    0.173721] Register r3 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdd8
[    0.178887] Register r4 information: non-paged memory
[    0.189361] Register r5 information: non-slab/vmalloc memory
[    0.194518] Register r6 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdd8
[    0.200197] Register r7 information: non-slab/vmalloc memory
[    0.210585] Register r8 information: non-paged memory
[    0.216427] Register r9 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdd8
[    0.221335] Register r10 information: non-paged memory
[    0.231807] Register r11 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdd8
[    0.236973] Register r12 information: 2-page vmalloc region starting 
at 0xf0814000 allocated at copy_process+0x16c/0xdd8
[    0.247888] Process swapper/0 (pid: 1, stack limit = 0x(ptrval))
[    0.258619] Stack: (0xf0815d78 to 0xf0816000)
[    0.264548] 
5d60:                                                       f0815e08 
c0896fd0
[    0.268771] 5d80: f0815d9c c0193bfc c1117d70 c1124000 00000036 
00000000 c1117d70 f0815da8
[    0.276848] 5da0: c12589bc 00000800 00000035 00000000 039b929b 
00000000 c2000030 c0a68a64
[    0.284925] 5dc0: f0815dd8 c0193bfc c1117d70 c1124000 00000036 
00000000 c1117d70 00000000
[    0.293002] 5de0: f0815e18 c0193bfc c078b204 00000001 c1270038 
00000000 c1106694 00000001
[    0.301078] 5e00: f0815ef0 00000000 f0815eb0 c0896624 00000001 
c0194138 f0815e78 c0194138
[    0.309155] 5e20: f0815e48 00000000 f0815ebf f0815e4c 00000006 
00000001 00000001 00000000
[    0.317232] 5e40: 02000601 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.325308] 5e60: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.333387] 5e80: 00000000 00000000 00000000 00000000 00000002 
00000000 f0815ebf c078b204
[    0.341464] 5ea0: 00000000 f0815ee0 00000000 00000000 f0815ed0 
c08947e8 f0815ec8 00a9b284
[    0.349541] 5ec0: f0815ef8 c0b8d6b7 00000001 00000000 f0815f68 
c08946c8 00000001 c01012a0
[    0.357618] 5ee0: 00000001 00000001 00000002 00000000 00000001 
00000000 801012a0 00000000
[    0.365693] 5f00: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.373771] 5f20: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.381848] 5f40: 00000002 00000000 c078b204 c14ff100 00000001 
c1568000 00000000 00000000
[    0.389926] 5f60: 00000000 00000000 f0815f80 c100be5c c14ff100 
00000001 c1568000 00000000
[    0.398003] 5f80: f0815f98 c1001538 00000000 c0a96fa8 00000000 
00000000 f0815fa8 c0a96fc8
[    0.406079] 5fa0: 00000000 00000000 00000000 c010014c 00000000 
00000000 00000000 00000000
[    0.414157] 5fc0: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.422233] 5fe0: 00000000 00000000 00000000 00000000 00000013 
00000000 00000000 00000000
[    0.430303] Call trace:
[    0.430327]  qcom_scm_get_tzmem_pool from __scm_smc_call+0x30/0x2d4
[    0.440957]  __scm_smc_call from __get_convention+0xac/0x128
[    0.446885]  __get_convention from qcom_scm_call_atomic+0x24/0x90
[    0.452729]  qcom_scm_call_atomic from qcom_scm_set_boot_addr+0xe4/0x100
[    0.458658]  qcom_scm_set_boot_addr from qcom_smp_prepare_cpus+0x1c/0x94
[    0.465362]  qcom_smp_prepare_cpus from kernel_init_freeable+0xcc/0x140
[    0.471977]  kernel_init_freeable from kernel_init+0x20/0x144
[    0.478250]  kernel_init from ret_from_fork+0x14/0x28
[    0.484086] Exception stack(0xf0815fb0 to 0xf0815ff8)
[    0.489073] 5fa0:                                     00000000 
00000000 00000000 00000000
[    0.494068] 5fc0: 00000000 00000000 00000000 00000000 00000000 
00000000 00000000 00000000
[    0.502143] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[    0.510224] Code: e28dd004 e300003c e34c0127 e5900000 (e5900090)
[    0.516642] ---[ end trace 0000000000000000 ]---
[    0.522765] Kernel panic - not syncing: Attempted to kill init! 
exitcode=0x0000000b
[    0.527406] ---[ end Kernel panic - not syncing: Attempted to kill 
init! exitcode=0x0000000b ]---


> /me considered bringing in Linus, but decided to wait a bit

Big fan of his and everyone's work! :)

Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[Rudraksha Gupta]

> Looks like qcom_scm_get_tzmem_pool() returns NULL. Not sure how this
> happens. Can you confirm that the QCom SCM driver probed correctly?

Thanks for looking into this! Please let me know how I can help!


I've been building the driver into the kernel I believe. Here's the 
relevant line in the config:

$ rg -i "scm"
samsung/expressatt/linux.defconfig
1615:# CONFIG_ARM_SCMI_PROTOCOL is not set
1627:CONFIG_QCOM_SCM=y
1628:# CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT is not set


It seems like the scm driver is being probed:

~ # dmesg | grep scm
[    0.066438] qcom_scm: convention: smc legacy
[    0.362543] bus: 'platform': add driver qcom_scm


Also here is the complete dmesg output (Had to paste in pastebin as it 
made the email bigger than 100 KB):

https://pastebin.com/4iWKvZ8z

Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[Dmitry Baryshkov]

On Sat, Sep 07, 2024 at 01:49:02AM GMT, Rudraksha Gupta wrote:
> > Looks like qcom_scm_get_tzmem_pool() returns NULL. Not sure how this
> > happens. Can you confirm that the QCom SCM driver probed correctly?
> 
> Thanks for looking into this! Please let me know how I can help!
> 
> 
> I've been building the driver into the kernel I believe. Here's the relevant
> line in the config:
> 
> $ rg -i "scm"
> samsung/expressatt/linux.defconfig
> 1615:# CONFIG_ARM_SCMI_PROTOCOL is not set
> 1627:CONFIG_QCOM_SCM=y
> 1628:# CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT is not set
> 
> 
> It seems like the scm driver is being probed:
> 
> ~ # dmesg | grep scm
> [    0.066438] qcom_scm: convention: smc legacy
> [    0.362543] bus: 'platform': add driver qcom_scm

The scm driver is added, but it is not probed as there is no SCM node in
DT. I'll send and RFT patch to add it. However the issue still persists:
the driver should not crash if there is no SCM device on a system.
qcom_scm_*_alloc should fall back if there is no SCM.

> 
> 
> Also here is the complete dmesg output (Had to paste in pastebin as it made
> the email bigger than 100 KB):
> 
> https://pastebin.com/4iWKvZ8z

-- 
With best wishes
Dmitry

Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

[Bartosz Golaszewski]

On Sat, 7 Sept 2024 at 11:57, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On Sat, Sep 07, 2024 at 01:49:02AM GMT, Rudraksha Gupta wrote:
> > > Looks like qcom_scm_get_tzmem_pool() returns NULL. Not sure how this
> > > happens. Can you confirm that the QCom SCM driver probed correctly?
> >
> > Thanks for looking into this! Please let me know how I can help!
> >
> >
> > I've been building the driver into the kernel I believe. Here's the relevant
> > line in the config:
> >
> > $ rg -i "scm"
> > samsung/expressatt/linux.defconfig
> > 1615:# CONFIG_ARM_SCMI_PROTOCOL is not set
> > 1627:CONFIG_QCOM_SCM=y
> > 1628:# CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT is not set
> >
> >
> > It seems like the scm driver is being probed:
> >
> > ~ # dmesg | grep scm
> > [    0.066438] qcom_scm: convention: smc legacy
> > [    0.362543] bus: 'platform': add driver qcom_scm
>
> The scm driver is added, but it is not probed as there is no SCM node in
> DT. I'll send and RFT patch to add it. However the issue still persists:
> the driver should not crash if there is no SCM device on a system.
> qcom_scm_*_alloc should fall back if there is no SCM.
>

Ugh, so some SCM calls seem to expect that they can get called without
the SCM driver. It's not very intuitive, I would expect that the
driver must be up for SCM to work at all.

I think we should fall back to using kzalloc() in such cases as
there's no struct device to use with the DMA alloc APIs. I'll prepare
a patch.

Bart