From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF212C4332F for ; Fri, 23 Dec 2022 11:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9AN7PdJbACVzW6rDB8j2FDk+RTDwcpBCNoCNhLib/RY=; b=3puGFQyMM1lNMC sgVYeyJjciJuKB3vb3qQGhCWGyNvWdXBEOM+yCMv4EEBo9P0/zTMX13i9pQympaK1I/55NHR4yqZ0 aBrfY7Ok0DeBSeY3t5Q2UpzTwUlb044KS9KjMHZMdlBCSLYnpINsWOvwq77Yhj3c8WqAIiFBKXQ2e fyAF9Zr6h9b2/1+Bv+m4h8uoMn/rWmLddXREovbfl6WDLzYigNg1puFtBPD9JYYNOCNyJRJu869CI 0p9E6kbVmFRZ7/zE6fPdfyATncKJ7Q3yhRqWl2DXAL59NhWE5eXm//1BVDzFpU2MvF5TiS6aOvrQ9 uEcowEBdT+Ty/7GcPoYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8g8a-0078H9-Ni; Fri, 23 Dec 2022 11:22:53 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8g8R-00782U-9S for linux-arm-kernel@lists.infradead.org; Fri, 23 Dec 2022 11:22:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D26B3B82033; Fri, 23 Dec 2022 11:22:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECC9EC433D2; Fri, 23 Dec 2022 11:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671794558; bh=iml0LYBf4pgDoBM3uptB0jlwdBiRt0cmsJC1LuqZC2A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aY5TgDlrecotk9zN++iFVn917CJ+lpYtPgCOsLqE6mlo5PYbmGFNIjI5j/sG2V9Ve mP1VBTBOiM+b2tyDgBQA/PUos0IbAVXAk7nmRqJlSNskSxf/GJLIX3s8aspc9Fwavq mtVmuSnoXNdbk6sY51QgOH5WocjpZTjle+vrrz5dtyjLj1H9sjgfqmCSrNHBIsAuLS gA+547InUUE5VZrRI/bjIe/z2agrxZQvVNhiILZ2p/DS+sADk/ErmUs52Xhq0mb22w o+9Q/YR2BLRUjlg8xurCRGkcMDRoK2etrW6x7RfzuGUVnr0Lg2BzhkanNjbTEAz5d1 r6sJb5SJOgpcg== Message-ID: <23436455-098f-6e21-2330-d91158a591ad@kernel.org> Date: Fri, 23 Dec 2022 12:22:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 4/5] dt-bindings: firmware: arm,scmi: Add support for syspower protocol Content-Language: en-US To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, Rob Herring , devicetree@vger.kernel.org References: <20221222183823.518856-1-cristian.marussi@arm.com> <20221222183823.518856-5-cristian.marussi@arm.com> <3d89e135-c8e4-ede4-950f-03900a660822@kernel.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221223_032243_527148_639A8554 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/12/2022 11:37, Cristian Marussi wrote: >>> >>> + protocol@12: >>> + type: object >>> + properties: >>> + reg: >>> + const: 0x12 >>> + >> >> Why? It did not got lost, it's already covered by pattern. If you refer >> to particular warning, please paste it in commit msg. Otherwise it looks >> incorrect. >> > > Yes indeed, but as a matter of fact it seemed to me that we used to add an > entry and an example for all the currently published standard SCMI protocols, > even though already covered by the patternProp (which covers also any > custom-vendor protocol in the wild) and not sporting any additional > custom properties (see protocol@18), but maybe this is just a unneeded wrong > habit adding only cruft to the bindings. > > If you think it does not add any value I can happily drop this, or > limiting the addition just to the example (and/or drop equally the unneeded > protocol@18 node too in this case). Duplicating the node (once in properties, second in patternProperties) is not needed. I am also not sure what would be the point to add to the example - example does not have to be complete DTS for all cases, but illustrate the binding and allow is to test it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel