From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7412C54E67 for ; Wed, 27 Mar 2024 19:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FtQb1FzggfOiIKTXs751GYJWFXf3XQ6wEZazwDErTAo=; b=0wBYRHANrQ5/Mr HCQT/EQ4W8s+rAvkYovpLeD4iTo9Xn8pPKi95Gig+f3T6gLbiPnAEtugKfJIIf2+Yqo1Pm9fg2y31 8ndm2RICj1exOkE16pqCfAH7NYOnNrldqDIttxqrQhyRoid068JQTTDddB/0GBfkVWVVPFnQ4+622 shy1tX+8MmB3xCrP4oXXTjTfYfFP25N1pvu28Ev+QUZl2qw7MDtZHLOYetboV4zO3NC8r/yh0L/8Y IdoCfqpFbBIIGzqxN2rtS2x0ghE4zYGyjHJwJ+BHt80PCJ+r/EVvabW/ORExL05bxjFzvA66ziy1w bVDlYm2bpubRlGjQZ2fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpZLA-0000000AsXE-3geX; Wed, 27 Mar 2024 19:53:40 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpZL7-0000000AsWM-0uZq for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 19:53:38 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a4715d4c2cbso25575166b.1 for ; Wed, 27 Mar 2024 12:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711569214; x=1712174014; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qdNTF6Kva1P11bABP85E0dh07br2jNGfWJsQyRATEsM=; b=DnOzA5dsI+QH2bK5KN1pNEXcn0cBAzmG433b7jHoOIeLHj3ZEcjlrSvtI4LpOPBrsE 4IDIUitcaUbCd9Bvp9i35HqYF400jU0p3vmtIn/d0HfjM8Q6KDRwDK7VaMZief78fSB5 21Mm8pQO99bxPOmUxGoMPIc4eJG9Tas5uOrkH2nnvXHJ8ccjrZvUiyPGKxmTFiAYFbcz 6Iqbhow6qTdWXOaAIOtgoETVOaAwxyju3STzzz59hewYJoiC0pxHpXdqToaZa8PaXU+h KPjhkmuo4mRghvsuFGuvH7lkq5NFBSpStkWoMXS7+9iPN9kcwl44LXUbecjTkbtx9uHN 8vVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711569214; x=1712174014; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qdNTF6Kva1P11bABP85E0dh07br2jNGfWJsQyRATEsM=; b=l4bVFbfie8ZFlTR1Y8XKWYFEhsUEUuoA+v882+ZR6PI8W6226vvf6OWlHZ5++E4XY6 OhFg36AV2RreqHDOaWGZ2VSFDzqhB/ANMvCKikNfnogbtmlF3FdsJcTgEpCjJ4ISUUEa SnF++ZRdGAE6BAz/vaclonhcOlDcXX3J7aCRHGa5PmjAS4inmMVui4NEgLIBbnNGVwUI F2BkYD0Yeygu3asxBFtccNcXPbIjd2GdllZXp91fsdStuWzLJ4GsHj4zLg4LYlW6+iky B3VvOGWIPVlCvY6X2YEnOJ9A3YJ3mkP/xt9BmiIdlOkQnYQDMG9NfC2SPFCcZTA1yYMJ +OkQ== X-Forwarded-Encrypted: i=1; AJvYcCVnwnyF7gitOQ9Ulu5SY8cablZAbn98qAybQCdKv4Ej4JKopyQOTX+Lpry4oVyKtZtzxgtyX4zJFoxoU4UuoetI5Ql/NfKvVLgJO28wtB7FwnWenO4= X-Gm-Message-State: AOJu0Yyf7B0Aw/K229ePsYR+j3SvD5HL7hgli1yv3h/rTULf5pawYkAZ SNG14hQ26ESf31NG0E/bBK+4jQZn3jO0hnM4J91I8FG3on3Y3ilE X-Google-Smtp-Source: AGHT+IEJHCTAYc5wMgN6Si7Qw5l/pWCJQkkzN4bIwHlGrIGZr8/mrHXa8XC/hK8xrg65wMHL8M4lnw== X-Received: by 2002:a17:906:e59:b0:a4e:a7a:84e0 with SMTP id q25-20020a1709060e5900b00a4e0a7a84e0mr335504eji.34.1711569213895; Wed, 27 Mar 2024 12:53:33 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id z11-20020a1709060acb00b00a4733982ba9sm5757294ejf.160.2024.03.27.12.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 12:53:33 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , John Watts Cc: linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, John Watts Subject: Re: [PATCH] ASoC: sunxi: sun4i-i2s: Enable 32-bit audio formats Date: Wed, 27 Mar 2024 20:53:32 +0100 Message-ID: <23447395.6Emhk5qWAg@jernej-laptop> In-Reply-To: <20240326-sunxi_s32-v1-1-899f71dcb1e6@jookia.org> References: <20240326-sunxi_s32-v1-1-899f71dcb1e6@jookia.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_125337_366316_59BF9C3B X-CRM114-Status: GOOD ( 25.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 26. marec 2024 ob 04:50:03 CET je John Watts napisal(a): > The I2S driver already supports and checks for 32-bit sample sizes, > so indicate this size is available for use in the DAI driver. > > This change has been tested on the T113-S3, but it should work just > fine on older hardware as get_sr checks for sample size support > correctly according to each core's datasheet. > > Signed-off-by: John Watts > --- > This patch enables support for 32-bit audio in the sunxi I2S driver. > > I have only tested this on the Allwinner T113 but I'm fairly > certain it will work on older boards. > --- > sound/soc/sunxi/sun4i-i2s.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > index a736f632bf0b..aeea852141c1 100644 > --- a/sound/soc/sunxi/sun4i-i2s.c > +++ b/sound/soc/sunxi/sun4i-i2s.c > @@ -1103,7 +1103,8 @@ static const struct snd_soc_dai_ops sun4i_i2s_dai_ops = { > > #define SUN4I_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \ > SNDRV_PCM_FMTBIT_S20_LE | \ > - SNDRV_PCM_FMTBIT_S24_LE) > + SNDRV_PCM_FMTBIT_S24_LE | \ > + SNDRV_PCM_FMTBIT_S32_LE) I wish it would be that simple. SUN4I_FORMATS is cross section of all I2S variants that are supported by this driver. If you check A10, you'll see that it doesn't support S32. If you want to add support for S32, you'll have to add new quirk for each variant. Best regards, Jernej > > static struct snd_soc_dai_driver sun4i_i2s_dai = { > .capture = { > > --- > base-commit: 72fb52fb0ac44b6a1edd9bc390e44bce3acccd26 > change-id: 20240326-sunxi_s32-f2ab25b8e688 > > Best regards, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel