From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BB92C32772 for ; Tue, 23 Aug 2022 11:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CtrpPjydt1IjezHFcIEPBi/lj1jalUrahRYTFkKO/TU=; b=xZvT4yi1Z0KgOg fAYEbLv4s2y4Sgv5hc0LBVeXOTPKqFNF0pWXLgJipVvFrIzw7maHYxcd5h+4c/hL/FLBrmn4fFiKl CjgBqMIZCVUPAtY1gHx5NH7TrIig3QHGenIjfQCI0vicHfuQHuTJKBLz0lcLfqbpDi/bAQRn7VsNU jIGU7G37BG6VVYryB7Wq8ohvvm6hAYUlZHO2NpiBtoBcQppzDFpO+pCd865ricp359fEHhZDtorRM 3Vhd0p990GAfWUclXJEvIlglBUn8YwkkQyOtARI77vrA9n2kdbJRX4smcS9V/46xp26muHdDdRNn1 1qzFapFmC9zE73xualGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQSVB-005ahB-R0; Tue, 23 Aug 2022 11:55:26 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQSTk-005ZpY-Vd; Tue, 23 Aug 2022 11:54:01 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oQSTe-0004TT-EA; Tue, 23 Aug 2022 13:53:50 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring , Krzysztof Kozlowski , Vinod Koul , Chris Ruehl , Jensen Huang , Brian Norris , Doug Anderson Cc: Jensen Huang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on rk3399 Date: Tue, 23 Aug 2022 13:53:49 +0200 Message-ID: <23552842.6Emhk5qWAg@diego> In-Reply-To: <20220822074139.3810-1-jensenhuang@friendlyarm.com> References: <20220822074139.3810-1-jensenhuang@friendlyarm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_045358_961175_31BB52FD X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 22. August 2022, 09:41:39 CEST schrieb Jensen Huang: > Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled > by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode. > > Tested on NanoPC-T4. > > Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts") > Signed-off-by: Jensen Huang ok, so this looks like it restores previous functionality. I'm just wondering as the "offending" patch is from 2020, why this only turns up now. Any ideas? > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 9d5b0e8c9cca..9491cafbbaa3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1561,6 +1561,7 @@ emmc_phy: phy@f780 { > clock-names = "emmcclk"; > drive-impedance-ohm = <50>; > #phy-cells = <0>; > + rockchip,enable-strobe-pulldown; > status = "disabled"; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel