From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C7A8C433F5 for ; Tue, 15 Mar 2022 19:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qqatTZmI322qA53BUCDps3O7CeNtvWJvSHRXle4eWXM=; b=jZnnSGoc3i+Iyk GbRB6gWyYcagYxTJZlUpHvSlZuvpR1OqrdcDi2TDscUDm9spAhMcJTK2q4PvbgWD4XJ5dY7l/LKba iHqbqKR2ijaxFNDPPmjYMGifuvaV1OuKRIieus1heVKILv0NEv5/iDjZ1EycYuLJDItEG7OIfDcVR ShFj02HGN0v+3Dj+qIZzpn4bcFAij6nH7bygnPYUSYmdHv4jd0D7oKab37Aal4mgsQPz1YOwKBPjN YFqoSRvSZxuC8T3IWCPLSzPSomvjZq3ySaGpwOUP88gjigFzQ13jQzE18VEOnepfJu6Hw4ZGGfWs7 /aEufFhfr/Tbbi8xf1aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUCl0-00AQwx-4P; Tue, 15 Mar 2022 19:22:58 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUCkw-00AQwP-As for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 19:22:56 +0000 Received: by mail-ej1-x62a.google.com with SMTP id pv16so4297270ejb.0 for ; Tue, 15 Mar 2022 12:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YUZLGSm75zNh7rcYmCCbe97E+affE9AzchNO0OWxx4o=; b=cCFx+shCgIVka6s5fOiT+wREmOnQNIvnqKe3Op2trhAh9UheCWIrFXkW+s4OGLFZg8 3f/hmiwIx6xETfTpBaDhyvsp5e+la/BaRAVUo2Hkn6VhJXBpNLUZ/CebWTe5+I+2TArn ZoBmhqvS42Fi+0U9YGhV3OF6TPzuxEBnrZBiIsOD4DMGpr5lWzbl78BTF0XGGGVBuHvd Nfw9hlez1k1oCKSRv2Y4mmiL6RFdUgYbaZvJjwxwucRWtjNXJqOEnjyewIILyqKQzY8A ptO4vaPR/B9wl75cLXCpPreHkpJaVDgWAjbySHrWO/oP3/F6vfvVFzIh7iUTLmAPk1c+ VoSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YUZLGSm75zNh7rcYmCCbe97E+affE9AzchNO0OWxx4o=; b=psFXU43+E/V7PC+E6cgvWIHsuuReZVQLP5cvFQ/HEUo21lorDXcRSozUCsfEboTZFg QpEKdVc8LY1Q9J6j58xZQWH3XsgjT4+NnL5Kzv4tga9FyOiIwzgxJKtHg/FSUxEDlknl UZpc0SVWwlHW80wtODufwEGzZ3aub1F9bZHdismPhx9GsM/Ddhd80qyYSAX9eyf9oAP/ CC/v64QHbQ7e1pt3vVfBZnVzwZPLlQ8TmMqrJOBk0boYdrvXcLCSiKy5/kvczXRTB8GC znbXAQ2LH9uGsq8dYandxuaquJ5upGTEQVQYr6ojm/S/G8VApTTmjlao6Xcc82J0NySy efdA== X-Gm-Message-State: AOAM530X3E3nnB1sIP3tCXEVViRHgThWDmhVyq3AxPZxzWhNLMf1DIg/ w3GV/PVvnu4XHHFdg4/bsOg= X-Google-Smtp-Source: ABdhPJx3oMQvDZcegvWM9E7xJZyXa9HzvY7rQWf3ct9h7oMvijJQwqMRKb2G2l22n3jGgUQYENCK5Q== X-Received: by 2002:a17:906:52c7:b0:6ce:a880:50a3 with SMTP id w7-20020a17090652c700b006cea88050a3mr23528658ejn.437.1647372172743; Tue, 15 Mar 2022 12:22:52 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id n4-20020a056402060400b00415a1f9a4dasm9918377edv.91.2022.03.15.12.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 12:22:52 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Paul Kocialkowski Cc: Yong Deng , Paul Kocialkowski , Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v3 03/46] media: sun6i-csi: Grab bus clock instead of passing it to regmap Date: Tue, 15 Mar 2022 20:22:50 +0100 Message-ID: <2361247.jE0xQCEvom@kista> In-Reply-To: <20220311143532.265091-4-paul.kocialkowski@bootlin.com> References: <20220311143532.265091-1-paul.kocialkowski@bootlin.com> <20220311143532.265091-4-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_122254_420472_B50D7775 X-CRM114-Status: GOOD ( 21.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul! Dne petek, 11. marec 2022 ob 15:34:49 CET je Paul Kocialkowski napisal(a): > Since the bus clock alone is not enough to get access to the registers, > don't pass it to regmap and manage it instead just like the other > clocks. > Let me ask it in another way, is bus clock needed only for register access? If yes, it makes sense to keep it enabled only during register access. Best regards, Jernej > Signed-off-by: Paul Kocialkowski > --- > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 10 ++++++++-- > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 1 + > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/ media/platform/sunxi/sun6i-csi/sun6i_csi.c > index 5fbaa1e99412..dc79f3c14336 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > @@ -827,13 +827,19 @@ static int sun6i_csi_resource_request(struct sun6i_csi_device *csi_dev, > if (IS_ERR(io_base)) > return PTR_ERR(io_base); > > - csi_dev->regmap = devm_regmap_init_mmio_clk(&pdev->dev, "bus", io_base, > - &sun6i_csi_regmap_config); > + csi_dev->regmap = devm_regmap_init_mmio(&pdev->dev, io_base, > + &sun6i_csi_regmap_config); > if (IS_ERR(csi_dev->regmap)) { > dev_err(&pdev->dev, "Failed to init register map\n"); > return PTR_ERR(csi_dev->regmap); > } > > + csi_dev->clk_bus = devm_clk_get(&pdev->dev, "bus"); > + if (IS_ERR(csi_dev->clk_bus)) { > + dev_err(&pdev->dev, "Unable to acquire bus clock\n"); > + return PTR_ERR(csi_dev->clk_bus); > + } > + > csi_dev->clk_mod = devm_clk_get(&pdev->dev, "mod"); > if (IS_ERR(csi_dev->clk_mod)) { > dev_err(&pdev->dev, "Unable to acquire csi clock\n"); > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h b/drivers/ media/platform/sunxi/sun6i-csi/sun6i_csi.h > index e4e7ac6c869f..356661b413f8 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h > @@ -51,6 +51,7 @@ struct sun6i_csi_device { > struct sun6i_video video; > > struct regmap *regmap; > + struct clk *clk_bus; > struct clk *clk_mod; > struct clk *clk_ram; > struct reset_control *reset; > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel