From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36AE4C433EF for ; Tue, 19 Oct 2021 05:56:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAA9A61154 for ; Tue, 19 Oct 2021 05:56:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EAA9A61154 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=C9PtONUDJC3pDdJ2Z1Lm0tTteYMhFHlwUjY95kQRZOA=; b=VJs+D0+WesYohreTdP/yCabHhU EnxTzr4R34bcObkuNBs8b2yksVPPWNafxTAFfZ4it40PPZJyGB1qf5CimlsUSS29UsXMf23h8dkuB CSW9N/P+AH9frg3DF7ipI62uSnjwZ9U1rQNtNnyA3fgMVaFzTkVSxnhYwj30N7ItTuAkVZ1Fghg1u tLwUU8QWdQkUSta8BrFxPkk/bkcCISYeu8EfzTuNeJl9R5LtQwNZesYlLKMZp2vpy4vx/FwFVn3fK vGRXBzHS6VHJHEQTyBV3NxzexFCjz1o/jkobF2uLpNtkINNdvPEtkxsPjPr12WUC8Cut+E5A+4BM0 B88ftCiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mci5i-000CzD-QM; Tue, 19 Oct 2021 05:55:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mci5e-000Cyo-Va for linux-arm-kernel@lists.infradead.org; Tue, 19 Oct 2021 05:55:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 96E3E2F; Mon, 18 Oct 2021 22:55:07 -0700 (PDT) Received: from [10.163.74.241] (unknown [10.163.74.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 572E93F73D; Mon, 18 Oct 2021 22:55:04 -0700 (PDT) Subject: Re: [PATCH v5 12/15] coresight: trbe: Make sure we have enough space To: Suzuki K Poulose , will@kernel.org, mathieu.poirier@linaro.org Cc: catalin.marinas@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, maz@kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211014223125.2605031-1-suzuki.poulose@arm.com> <20211014223125.2605031-13-suzuki.poulose@arm.com> From: Anshuman Khandual Message-ID: <2363663b-72b4-e249-49d1-b036866fc4fe@arm.com> Date: Tue, 19 Oct 2021 11:25:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211014223125.2605031-13-suzuki.poulose@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_225511_099296_8008FCD4 X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/15/21 4:01 AM, Suzuki K Poulose wrote: > The TRBE driver makes sure that there is enough space for a meaningful > run, otherwise pads the given space and restarts the offset calculation > once. But there is no guarantee that we may find space or hit "no space". > Make sure that we repeat the step until, either : > - We have the minimum space > OR > - There is NO space at all. > > Cc: Anshuman Khandual > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Leo Yan > Reviewed-by: Mathieu Poirier > Signed-off-by: Suzuki K Poulose Reviewed-by: Anshuman Khandual > --- > drivers/hwtracing/coresight/coresight-trbe.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index 4a50309a892d..5fb9f49eab33 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -477,10 +477,14 @@ static unsigned long trbe_normal_offset(struct perf_output_handle *handle) > * If the head is too close to the limit and we don't > * have space for a meaningful run, we rather pad it > * and start fresh. > + * > + * We might have to do this more than once to make sure > + * we have enough required space. > */ > - if (limit && ((limit - head) < trbe_min_trace_buf_size(handle))) { > + while (limit && ((limit - head) < trbe_min_trace_buf_size(handle))) { > trbe_pad_buf(handle, limit - head); > limit = __trbe_normal_offset(handle); > + head = PERF_IDX2OFF(handle->head, buf); > } > return limit; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel