Re: [PATCH v2 00/12] media: rkvdec: Add support for VDPU381 and VDPU383

[Detlev Casanova <detlev.casanova@collabora.com>]

Hi Heiko,

On Monday, 11 August 2025 05:56:00 EDT Heiko Stübner wrote:
> Hi Detlev,
> 
> Am Freitag, 8. August 2025, 22:03:22 Mitteleuropäische Sommerzeit schrieb 
Detlev Casanova:
> > These variants are found respectively in the RK3588 and RK3576 SoCs.
> > This patch only adds support for H264 and H265 in both variants.
> > 
> > As there is a considerable part of the code that can be shared with the
> > already supported rkvdec decoder driver, the support for these variants
> > is added here rather than writing a new driver.
> > 
> > This patch set uses the newly introduced hevc_ext_sps_[ls]t_rps v4l2
> > controls for HEVC [1].
> > Therefore, a patched version of userpace tools is needed for HEVC
> > support (added for GStreamer[2] and in an early stage for FFmpeg[3]).
> > 
> > This patch set also depends on the preparation patch set sent earlier [4]
> > as well as the iommu restore fix [5] (already merged in linux-media) and
> > Nicolas Frattaroli's bitmap patch [6] to support setting registers that
> > uses upper 16 bits as masks.
> > 
> > [1]:
> > https://lore.kernel.org/all/20250807194327.69900-1-detlev.casanova@collab
> > ora.com/ [2]:
> > https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9355
> > [3]: https://gitlab.collabora.com/detlev/ffmpeg
> > [4]:
> > https://lore.kernel.org/all/20250623160722.55938-1-detlev.casanova@collab
> > ora.com/ [5]:
> > https://lore.kernel.org/all/20250508-rkvdec-iommu-reset-v1-1-c46b6efa6e9b
> > @collabora.com/ [6]:
> > https://lore.kernel.org/all/20250623-byeword-update-v2-1-cf1fc08a2e1f@col
> > labora.com/> 
> > Changes since v1:
> >  - Add parsing of the short and long term ref frame sets from the new v4l2
> >  
> >    controls
> >  
> >  - Add RPS cache to avoid parsing the same data again
> >  - Fix HEVC pixel formats selection
> >  - Fix multiple indentation errors
> 
> when applying the series, git was a bit unhappy about some whitespaces:

Mmh, it looks like some rebase issues. Thanks, I'll fix those !

> > Detlev Casanova (12):
> >   media: rkvdec: Switch to using structs instead of writel
> >   media: rkvdec: Move cabac table to its own source file
> 
> Applying: media: rkvdec: Move cabac table to its own source file
> .git/rebase-apply/patch:535: new blank line at EOF.
> +
> Warnung: 1 Zeile fügt Whitespace-Fehler hinzu.
> 
> >   media: rkvdec: Use structs to represent the HW RPS
> >   media: rkvdec: Move h264 functions to common file
> 
> Applying: media: rkvdec: Move h264 functions to common file
> .git/rebase-apply/patch:278: new blank line at EOF.
> +
> Warnung: 1 Zeile fügt Whitespace-Fehler hinzu.
> 
> >   media: rkvdec: Add per variant configuration
> >   media: rkvdec: Add RCB and SRAM support
> 
> Applying: media: rkvdec: Add RCB and SRAM support
> .git/rebase-apply/patch:200: new blank line at EOF.
> +
> Warnung: 1 Zeile fügt Whitespace-Fehler hinzu.
> 
> >   media: rkvdec: Support per-variant interrupt handler
> >   media: rkvdec: Enable all clocks without naming them
> >   media: rkvdec: Add H264 support for the VDPU381 variant
> >   media: rkvdec: Add H264 support for the VDPU383 variant
> >   media: rkvdec: Add HEVC support for the VDPU381 variant
> 
> Applying: media: rkvdec: Add HEVC support for the VDPU381 variant
> .git/rebase-apply/patch:3483: new blank line at EOF.
> +
> .git/rebase-apply/patch:4035: new blank line at EOF.
> +
> Warnung: 2 Zeilen fügen Whitespace-Fehler hinzu.
> 
> 
> Heiko