From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AC5C00A89 for ; Mon, 2 Nov 2020 21:02:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFEE32072C for ; Mon, 2 Nov 2020 21:02:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aDIrOlFQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=vt-edu.20150623.gappssmtp.com header.i=@vt-edu.20150623.gappssmtp.com header.b="Zj0XH4Gp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFEE32072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Message-ID:Date:Mime-Version:References:In-Reply-To:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=urNep20LqGP8r6IwhOTZbiyS8+ETdaaWq+w1E94uEaM=; b=aDIrOlFQL/peHdB2DFc2mtNwQ BJGlNmLilYaL4FizMN5nBUDZ5QFt04ps+5pgEcaiRw4DVXrZRJaQZdxpMjqzBE1fetCEutieoR3U/ 4gBV1vcFe+YjDh1lgP4w2H9kY2/CLuVxe2rN/3oKG+YzcQ/Hkx0SqI4mLvQrv7av3mYcy5tTvXaW6 Dgp6n8ONUFaxBlAYt9hsOEObbWMeC2UF5LeLEeQ+760eBJcqT2ni03yyXQ1EgKXPCOlPRgZaNc8xo oqTw1X6Ptyv05HqHgspEpf2RuTrF+F20R6Qj45rNkMuJiWZZvm+hK1juJ4XM5O2teGHcm+sfRstY0 zwqMyrsEQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZgxY-0001bg-Di; Mon, 02 Nov 2020 21:01:48 +0000 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZgxU-0001am-6e for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 21:01:46 +0000 Received: by mail-qv1-xf43.google.com with SMTP id ed14so3231616qvb.4 for ; Mon, 02 Nov 2020 13:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:in-reply-to:references:mime-version :content-transfer-encoding:date:message-id; bh=sfssJoSVarUrVMLVURV+BvhAdC7/uwArT8ZmhaNO1+Y=; b=Zj0XH4GpUc6+gpMRh2RhlFy5ROiQJ/QdeeWeLLNEhIH/tedSB7zeX1UfCOgmwMQJ2b J8JrNgPJiXdnGVTB+1pyA5lOUruh706QskZmam4gGhKW+odm+4SC3AD67PNqO1QvNkMW VHxflaF8RUMBRUbTdfvrsPS6cBRMxscKQ+co/+7DDODfrBtf7A9+1Y+OTl04xARGGv/B MM8bccZPgF71lc7IeQbdKqo3CUMRNloPObxAnpQGohyRKjVP8Uwyh3QevOqv/gRgVBl8 Es+nm53gtl+jRCr9So8QaCgUrUGUq/MqaVu3sW+uCS2HIwO5hkeZVRra+uLeNRdIbdoF zBrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=sfssJoSVarUrVMLVURV+BvhAdC7/uwArT8ZmhaNO1+Y=; b=M7OnnptgIydzZmWwlmmiUrszHVibyIm1akyL726dyiXHQdpvg6iuenbxiLoQwV2/ij Nyzh1uFMT2bfnRuTAJKoakqhDCUrPczSrxgBo3BsxewKKfbUfd/UBRFgsYopr5zcneYa 7g5lswRZ7z256qpjZFMnqP7vp3Ywf+FihWcvWItnjfWLIoU1dAhfmBSJBNPMpFYq9DTM fK3kEQWhwdxMLyWOTkFy3lxriJpZaqSgr5xbZNS9EF4PoejZbJ8Ly8ia/eGfqkXn0d5/ XMCYgQHSWcSGti4iNfxv25yN6Ds6n3k6/7xHWBVFqx+GY9Clxv+z6lKMB2l5FepAfd7L ++Zg== X-Gm-Message-State: AOAM532nuH7JhSVLueJFsagQaWFD/hZ9Cl1YBxAROdon37Jjpo8s029u 4gX976bLz/P+i95ZHMU9k2L1N7DY2+wo7A== X-Google-Smtp-Source: ABdhPJxjFuxtaEy0PCizL0CmEhKqRKfoe98V4mJlXUms3rhVSIcHT8UkAbapQUXa2aa8X7flf2Dn+g== X-Received: by 2002:a0c:f3d0:: with SMTP id f16mr15065713qvm.42.1604350902180; Mon, 02 Nov 2020 13:01:42 -0800 (PST) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id y3sm8751323qto.2.2020.11.02.13.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 13:01:40 -0800 (PST) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Randy Dunlap Subject: Re: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o In-Reply-To: <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org> References: <208469.1604318525@turing-police> <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org> Mime-Version: 1.0 Date: Mon, 02 Nov 2020 16:01:39 -0500 Message-ID: <238534.1604350899@turing-police> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_160144_452377_EE4C5A16 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7880087019016614580==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7880087019016614580== Content-Type: multipart/signed; boundary="==_Exmh_1604350899_216810P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --==_Exmh_1604350899_216810P Content-Type: text/plain; charset=us-ascii On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said: > also > Reported-by: kernel test robot > > However, this driver does not directly use . Just my luck - I looked at 3 or 4 other things that include of_platform.h and they all *did* include module.h. > platform_device.h #includes , which is where the > problem lies: > > uses macros that are provided by > so should #include . > > and that fixes this commit: > > commit 4c002c978b7f2f2306d53de051c054504af920a9 > Author: Greg Kroah-Hartman > Date: Mon Dec 9 20:33:03 2019 +0100 > > device.h: move 'struct driver' stuff out to device/driver.h OK.. who's going to do that? Me, or Randy, or Greg? --==_Exmh_1604350899_216810P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBX6BzsgdmEQWDXROgAQKfjg//RIaEOb6EyTQqKOPfGtJ4KcMOdHgJwcC/ tYMiOn2Em2wycFf71WP/tBsIDqUXcPVUDfU5zyQPYPKjbRJjMUe1PraO3qrSlhke N6XwkcCo4V16PVFJFpcdVJfxo6nPxlIZ9lq3Hd4T26gnUPfS9p5rPHtGNYDAKyD8 c3mlwDN3inQnuBuON73p7pS+OopVJHjmU6zvvEgbsiJcUpoJk+13uKvTG4RbWmNz i1PKb1+dk4uEETAZCMftFqfji80ugWUuMXKRCapS12nqBOkLgxUmWED5XZJC4H5X pogktUAGKxTivLqhVTz/JWvrAnACKiM1OUfRCNcJh40hgt3wGvuUxLpALT2Rfiqp ANRl4q2UzivUIhbee+V9h4m+ZthBkOmHU7nfDQDeZYzKHAGthUfKGdmTXEG2dAmH R5p7E/k4GfKvBdGYp86LL/s+wlARvqbfg/R0fTIlsTgfPsnOkigP41s5w0Ccm656 7YIXHJomsOL8cjWyvLI/FpbhFs92c11Pt8nlKj2PEl+M9GjoL7gp7NSSJM7DaEri UrEcmlaNN12hu5giSsJ7N1olVqkgMqylM0JptP33eObCC5uHx+Tz/sOWpFrKCuBi kZVXKKFL6QOe/fAVvYPfcP1ThTbRv5Giv4iDLVB6AXxre74nb7QbUYPDeu18DIMv bcY4c26AjmI= =PXZH -----END PGP SIGNATURE----- --==_Exmh_1604350899_216810P-- --===============7880087019016614580== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7880087019016614580==--